jeffy-g
fd71eb2c85
fix broken regex on "src/services/completions.ts#getCompletionData" ( #37546 )
...
* fix broken regex on src/services/completions.ts#840
* update forslash test
breaking changes fourslash test
Temporarily retain the before fix code for easy comparison
* regex
* fourslash test (Temporary code
* regex: more restrictive in terms of jsdoc format
fourslash test
* regex: max indent restriction
* achieved goal by partial match strategy (probably
* cleanup
* apply requested changes
* Change to a version with minimal modifications
2020-05-11 13:02:20 -07:00
Wenqi
1b7b3eb0f7
report error for duplicate @type declaration ( #38340 )
2020-05-11 12:47:49 -07:00
Alexander T
738b6b5b68
fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' ( #38107 )
2020-05-11 12:25:25 -07:00
lissein
946abeadb0
Changed template strings to emit void 0 instead of undefined ( #38430 )
...
undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.
2020-05-09 04:53:14 +02:00
Wesley Wigham
7b03835b77
Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit ( #38368 )
...
* Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit
* Add special lookups test case, rename helper
* Accept slightly modified baselines
2020-05-08 10:46:28 -07:00
David Sherret
84f89f8702
Fix some JSDoc factory function return types.
2020-05-08 12:26:50 -04:00
csigs
92b7d8b6f2
LEGO: check in for master to temporary branch.
2020-05-08 16:13:19 +00:00
Manuel Thalmann
cbc959ba35
Make isDynamicFileName available publicly ( #38269 )
...
* Make isDynamicFileName available publicly
This commit fixes #37987
* Acknowledge Public APIs
2020-05-08 07:31:59 -07:00
csigs
ece47d9d9a
LEGO: check in for master to temporary branch.
2020-05-08 04:10:54 +00:00
csigs
9ba861904b
LEGO: check in for master to temporary branch.
2020-05-07 22:11:10 +00:00
Anders Hejlsberg
0091fd6c64
Exclude arrays and tuples from full intersection property check ( #38395 )
...
* Exclude arrays and tuples from full intersection property check
* Add regression test
2020-05-07 15:03:51 -07:00
Anders Hejlsberg
7798f532df
Fix crash caused by assertion with evolving array type ( #38398 )
...
* Properly finalize evolving array type in getTypeAtFlowCall
* Add regression test
2020-05-07 14:05:57 -07:00
csigs
1d2414822d
LEGO: check in for master to temporary branch.
2020-05-07 16:10:38 +00:00
Eli Barzilay
29cf049e61
moveToNewFile: handle namespace imports too
...
Fixes #35591
2020-05-07 11:46:36 -04:00
Jack Williams
05d59a1f1a
Unify logic in typeof narrowing ( #33434 )
2020-05-06 15:15:24 -07:00
csigs
c08b020ae9
LEGO: check in for master to temporary branch.
2020-05-06 22:10:57 +00:00
Alexander T
683b3ec058
feat(37782): 'declare method' quick fix for adding a private method ( #37806 )
...
* feat(37782): add quick-fix action to declare a private method for names that start from underscore
* better merge order in messages json
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:10:02 -07:00
Wenlu Wang
e66ce879a9
expose jsdoc factory ( #29539 )
...
* expose jsdoc factory
* refactor jsdoc factory
* correctly jsdoc factory types
* update jsdoc factory
* Add check for delete expression must be optional
* accept new basseline
* Revert "Add check for delete expression must be optional"
This reverts commit 76937c3b1a .
* remove newline
* make linter happy
* Add deprecated comment
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:06:12 -07:00
Wenlu Wang
8d78984558
Add support of contextual quick info ( #37451 )
...
* Add support of contextual quick info
* Avoid document comment map
* Make lint happy
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:05:31 -07:00
Nathan Shively-Sanders
35c1ba67ba
Update LKG 2020 05 06 ( #38371 )
...
* Update LKG
* remove now-extraneous casts
2020-05-06 14:42:05 -07:00
Josh Goldberg
be2eb8a2e1
Allowed comment directives to be multiline ( #38228 )
...
* Allowed comment directives to be multiline
* Added tests, and perhaps fixed a test runner bug?
* I think it's going to need a consistent variable to loop over
* Used dynamically computed indexes in verifies
* Added multiline tests
* Increased flexibility for multiline comment parsing
* Undid a couple of formatting changes; removed backslashes from multiline regexp
* Added baseline tests for multiline comment skipping
Co-authored-by: Orta Therox <orta.therox@gmail.com >
2020-05-06 13:09:29 -07:00
Ron Buckton
4b08c0582d
Fix regression in name resolution in parameter ( #38351 )
2020-05-06 12:04:28 -07:00
Alexander T
ec93a7cf7b
fix(36055): forbid union type with invalid types in the 'in' operator ( #37786 )
2020-05-06 11:41:50 -07:00
csigs
c33d6044fa
LEGO: check in for master to temporary branch.
2020-05-06 04:10:41 +00:00
Anders Hejlsberg
2524fb164a
Consistent narrowing by discriminant ( #38311 )
...
* Consistent requirements for narrowing by discriminant
* Add tests
2020-05-05 20:06:07 -07:00
Alexander T
c219fdae08
fix(37703): forbid required parameter after optional ( #38155 )
2020-05-05 10:29:17 -07:00
Alexander T
d86bdf4e5c
add outlining spans for the tuple type ( #38179 )
2020-05-05 09:48:33 -07:00
Alexander T
2bdc8fdc94
add outlining spans for array destructuring elements ( #38191 )
2020-05-05 09:29:24 -07:00
Marcel Laverdet
44c6cf74cb
Fix updateBinary operator parameter ( #38129 )
...
* Fix `updateBinary` `operator` parameter
There is an issue in `updateBinary` where attempting to update
`operator` without updating `left` or `right` results in a silent no-op.
* Use defaulted parameter in `updateBinary`
2020-05-05 09:05:02 -07:00
Daniel Rosenwasser
94c5c3ff47
Add missing arguments to typeToTypeNode. ( #38336 )
...
* Add missing arguments to typeToTypeNode.
* Use returnTypeNode as the enclosingDeclaration.
* Add a test.
2020-05-04 19:32:27 -07:00
Anders Hejlsberg
e6390efb01
Properly handle private/protected members in unions of object types ( #38277 )
...
* Property handle private/protected properties in unions of object types
* Add regression test
2020-05-04 15:28:00 -07:00
Wesley Wigham
d9c9c9d9e4
Harden node builder APIs to no longer return undefined for a node when NodeBuilderFlags.IgnoreErrors is provided ( #38273 )
2020-05-04 14:47:39 -07:00
Sheetal Nandi
aa37b28246
Fix incorrect line text computation to stop comment directive searching ( #38296 )
...
Fixes #38289
2020-05-04 13:02:54 -07:00
Anders Hejlsberg
a09470f013
Fix index signatures on unions of intersections ( #38278 )
...
* Add missing getApparentType call
* Add regression tests
2020-05-04 12:46:14 -07:00
Alexander T
5e0e254ef7
fix(38177): add auto-import for missing argument type in new functions/methods ( #38213 )
2020-05-04 12:37:04 -07:00
Eli Barzilay
ba02f4303e
Make getAwaitedType private
...
Also, fix an additional baseline change and break up huge line.
2020-05-04 13:18:52 -04:00
Alexander T
0503da225d
feat(36266): add a quick fix for incorrect return types in async functions
2020-05-04 13:18:52 -04:00
Leko
275ed548df
disallows exponentials with BigInts for targets lower than ES2016
2020-05-04 13:14:48 -04:00
Wesley Wigham
5b0194b311
Fix jsdoc variadic type nodes not being remapped to equivalent TS in output ( #38276 )
2020-05-02 01:43:59 -07:00
csigs
e746c6883b
LEGO: check in for master to temporary branch.
2020-04-30 22:10:46 +00:00
Andrew Branch
53320f59a4
Fix crash on duplicate default exports ( #38272 )
2020-04-30 12:21:02 -07:00
Jack Works
6f7faa7636
Fix: convertFunctionToEs6Class cannot recognize x.prototype = {} pattern ( #35219 )
...
* fix: convertFunctionToEs6Class cannot recognize `x.prototype = {}` pattern
* test: add test for convert fn to es6
* chore: add more tests
* chore: move tests around
* chore: make code more clear
2020-04-30 11:06:46 -07:00
csigs
836d9aaac0
LEGO: check in for master to temporary branch.
2020-04-30 16:10:36 +00:00
Jacob Bandes-Storch
0b1cb74530
fix order and tests
2020-04-29 23:04:24 -07:00
Jacob Bandes-Storch
fd4eccee6c
Merge remote-tracking branch 'upstream/master' into diagnose-accidental-accessor-call
2020-04-29 23:00:16 -07:00
Jacob Bandes-Storch
6051fc1814
move to invocationErrorDetails
2020-04-29 22:58:18 -07:00
csigs
10fd1fa347
LEGO: check in for master to temporary branch.
2020-04-29 22:10:59 +00:00
csigs
6916387597
LEGO: check in for master to temporary branch.
2020-04-29 16:10:44 +00:00
Orta
0258db2210
Adds support for looking up past Blocks in expando objects ( #38031 )
...
* Adds support for looking up past Blocks in expando objects
* Adds JS tests to validate the JS parsing also works
* Get the top level block expando tests green
2020-04-29 10:35:33 -04:00
Anders Hejlsberg
d9ad27f2dd
Early couldContainTypeVariables check in instantiateType ( #37844 )
...
* Shared early couldContainTypeVariables check in instantiateType
* Defer creation of map object in createUnionOrIntersectionProperty
* Types with top-level non-generic type alias reference no type variables
2020-04-28 17:02:52 -07:00