Alexander T
c00aeb5486
fix(33286): add outlining for arrow function with one parameter ( #38631 )
2020-05-21 08:07:47 -07:00
Nathan Shively-Sanders
0b531720d4
Make new error an error, not message
2020-05-20 16:53:17 -07:00
Nathan Shively-Sanders
fc83d10388
Merge branch 'master' into diagnose-accidental-accessor-call
2020-05-20 16:46:34 -07:00
Nathan Shively-Sanders
3340142dda
Merge pull request #38607 from a-tarasyuk/bug/38295
...
fix(38295): Duplicated object key in const not detected when the key is a number preceded by `-` or `+`
2020-05-20 14:52:09 -07:00
Alexander T
4e945fbc98
fix(38299): use string literals as keys to creating rest result ( #38600 )
2020-05-20 13:52:52 -07:00
Nathan Shively-Sanders
68f8f22032
Merge pull request #38425 from dsherret/fixJSDocTagFactoryFuncReturnTypes
...
Fix some JSDoc factory function return types
2020-05-20 13:22:21 -07:00
Nathan Shively-Sanders
c526b425ef
Merge pull request #38498 from ShuiRuTian/make-atomics.notify-type-correct
...
make Atomics.notify last parameter optional
2020-05-20 11:55:01 -07:00
Anders Hejlsberg
a56960303d
Intersection check for empty object type shouldn't cause circularities ( #38673 )
...
* isEmptyAnonymousObjectType shouldn't require full member resolution
* Add regression test
2020-05-20 10:56:14 -07:00
Alexander T
bbf56b044b
Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38295
2020-05-20 20:13:50 +03:00
Dmitry Makhnev
dbaeed5ad8
Add d.ts for Intl.RelativeTimeFormat ( #36084 )
...
* feat(lib/es2020.intl): Add `Intl.RelativeTimeFormat` (part of #29129 );
* fix(lib/es2020.intl): fix for tests and linters `Intl.RelativeTimeFormat` (part of #29129 );
* feat(lib/es2020.intl): Add TSDoc for `Intl.RelativeTimeFormat` by review request https://github.com/microsoft/TypeScript/pull/36084#issuecomment-584769420 ;
* fix(lib/es2020.intl): Fix for tests;
Co-authored-by: Dmitry Makhnev <dmitriy.makhnev@jugru.org >
2020-05-20 11:06:28 -04:00
Alexander T
e04ab6938a
fix(38295): handle duplicate object literal keys which contain '+' and '-' tokens
2020-05-20 14:32:41 +03:00
Wesley Wigham
5f597e69b2
Support naming tuple members ( #38234 )
...
* Initial draft of named tuple members
* Show tuple labels and documentation in completions
* Swap allowed syntax to parameter-like
* Add quickfix for labeled tuple syntax mistakes
* Add refactoring to convert list of signatures to single overload
* Fix small bug in visitor verification
* Signature help for rest parameters which are unions of tuples are displayed as seperate entries now
* Expand sanity check test cases in conformance suite
* Add tests and code for preserving tuple names through spreads where possible
* More refactoring tests, some comment preservation and some fixed formatting of multiline tuples
* Handle missing parameter named in isValidDeclarationForTupleLabel
* Minor text fixes
2020-05-19 15:54:02 -07:00
csigs
0e4f1cb407
LEGO: check in for master to temporary branch.
2020-05-19 22:11:18 +00:00
Jack Works
7ec467e270
fix: extract const in jsx ( #37912 )
...
* fix: extract const in jsx
* Update src/services/refactors/extractSymbol.ts
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
* Update src/services/refactors/extractSymbol.ts
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
2020-05-19 14:29:49 -07:00
Daniel Rosenwasser
46f100f8ac
Merge pull request #38500 from a-tarasyuk/bug/38485
...
regression(38485): Unable to specify `rawText` when programmatically creating tagged template literals
2020-05-19 14:24:25 -07:00
Nathan Shively-Sanders
415b2e7969
Merge pull request #38656 from a-tarasyuk/bug/33233
...
fix(33233): Code Folding on es5 object functions does not work (getOutliningSpans)
2020-05-19 14:18:42 -07:00
Anders Hejlsberg
7ba0a6592d
No contextual types from circular mapped type properties ( #38653 )
...
* No contextual types from circular mapped type properties
* Add regression test
2020-05-19 13:42:30 -07:00
Andrew Branch
707e977056
Ensure formatter can always get a newline character ( #38579 )
...
* Ensure formatter can always get a newline character
* Make FormatContext.host optional since it’s not necessary if format options are all applied
* Make FormattingHost required again
2020-05-19 13:14:32 -07:00
csigs
90b772a751
LEGO: check in for master to temporary branch.
2020-05-19 04:10:35 +00:00
csigs
92dc5b8754
LEGO: check in for master to temporary branch.
2020-05-18 22:10:33 +00:00
csigs
48d6e8dee5
LEGO: check in for master to temporary branch.
2020-05-18 16:10:40 +00:00
Alexander T
2b703d254a
fix(33233): add outlining for comments before property access expression
2020-05-18 15:26:46 +03:00
csigs
437d68d64b
LEGO: check in for master to temporary branch.
2020-05-18 10:10:25 +00:00
Anders Hejlsberg
3c1f37e913
Use control flow analysis to check 'super(...)' call before 'this' access ( #38612 )
...
* Use CFA graph to check this/super accesses are preceded by super() call
* Accept cleaned-up API baselines
* Accept new baselines
* Add tests
2020-05-16 19:58:17 -07:00
csigs
d154b58406
LEGO: check in for master to temporary branch.
2020-05-16 22:10:40 +00:00
Eli Barzilay
33c3e9e2c6
Make processTaggedTemplateExpression visit a returned node
...
This problem was introduced in 70399e146e (from PR #23801 ), which added
a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`,
before that, it would fallback to the default of `visitNode`. So re-add
that happen in `processTaggedTemplateExpression`.
Since it doesn't hurt, I left a `Debug.checkDefined(property.name)`
instead of `!`-ing it.
Fixes #38558 .
2020-05-15 19:46:45 -04:00
Eli Barzilay
d7dd06e36d
goToDefinition: find only the value if it's the RHS of an assignment
2020-05-15 18:55:57 -04:00
Jesse Trinity
1a15717bc4
Fix regression organize imports duplicates comments ( #38599 )
...
* delete import comments on organize imports
* add unit test
* accept new baseline
* respond to review comment
2020-05-15 14:25:11 -07:00
Ron Buckton
1cbe7ef000
Fix crash in JS declaration emit ( #38508 )
...
* Fix crash in JS decl emit
* Emit as class with private ctor
2020-05-15 14:00:59 -07:00
Wesley Wigham
7fc456f2d7
Include unknown in spread prop override check ( #38577 )
2020-05-14 14:36:38 -07:00
Greg Hurrell
cfc4573c82
Fix (cosmetic) typos in checker.ts comments
...
Just some small things I noticed while looking at some recent PRs.
2020-05-14 19:40:41 +02:00
Anders Hejlsberg
c1f676dd3f
Perform intersection reduction before and after getApparentType ( #38565 )
...
* Perform intersection reduction before and after getApparentType
* Add regression tests
2020-05-13 20:57:17 -07:00
Alexander T
71711257ea
fix(33836): allow readonly modifier for a field with only get accessor ( #36543 )
2020-05-13 13:28:32 -07:00
Wenlu Wang
9725d623ce
Fix build type error ( #38525 )
2020-05-13 07:44:49 -04:00
Daniel Rosenwasser
b682ee1a8a
Merge pull request #38489 from microsoft/removeDuplicateInfo
...
Remove duplicate JSDoc comments
2020-05-12 12:52:15 -07:00
Daniel Rosenwasser
c2b559403d
Merge pull request #38502 from alan-agius4/export-star-colon
...
fix: add missing semi-colon to `__exportStar` unnamed function
2020-05-12 10:59:03 -07:00
Sheetal Nandi
5d6a5d04ea
Fix detecting default project when file is part for more than one project but not part of default configured project (eg because its output of that projet) ( #38429 )
...
Fixes #38366
2020-05-12 10:16:59 -07:00
Nathan Shively-Sanders
3f06adf662
Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements
...
feat: Add outlining spans for object destructuring elements
2020-05-12 07:35:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed
feat(38225): change diagnostic message for remove braces from arrow function body ( #38226 )
2020-05-12 07:27:09 -07:00
Alexander T
5895493815
fix(37877): include in NavigationBar default exported child items ( #38255 )
2020-05-12 07:26:31 -07:00
Alan Agius
7ec21e93fe
fix: add missing semi-colon to __exportStar unnamed function
...
Fixes #38501
2020-05-12 13:27:01 +02:00
Alexander T
ee3f2ce362
regression(38485): allow using rawText property in processing a tagged template
2020-05-12 12:30:46 +03:00
Song Gao
df772327fe
make last para of Actomics.notify optional.
2020-05-12 16:55:36 +08:00
csigs
0e37296396
LEGO: check in for master to temporary branch.
2020-05-12 04:10:41 +00:00
Daniel Rosenwasser
f9e1bcd0c4
Merge pull request #38439 from lissein/void-0-template-strings
...
Changed template strings to emit void 0 instead of undefined (#38430 )
2020-05-11 17:09:28 -07:00
Daniel
e9867a7353
Add and use the 'intersperse' helper function.
2020-05-11 22:17:01 +00:00
csigs
27b9daf0a3
LEGO: check in for master to temporary branch.
2020-05-11 22:10:44 +00:00
Ron Buckton
d07e866a28
Fix for jsdoc modifiers on constructor params ( #38403 )
...
* Fix for jsdoc modifiers on constructor params
* Update Public API baseline and fix unique symbol grammar check for js
2020-05-11 15:07:43 -07:00
Daniel
74d6d04d70
Don't add duplicates of JSDoc comments.
2020-05-11 21:39:47 +00:00
Nathan Shively-Sanders
1a88430a7e
Improve assert message in binder ( #38270 )
...
* Improve assert message in binder
Looking at the code, I don't think the assert can ever fire, but it
clearly does, or did in the past. This will make it easier for people to
create a repro.
* fix lint
* Use BindableStaticNameExpression not BindableStaticAccessExpression
This type does allow identifiers, but those are ruled out earlier, so I added
an assert for that case.
2020-05-11 13:40:54 -07:00