microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-20 05:17:43 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix updateBinary operator parameter (#38129)

Browse Source 
* Fix `updateBinary` `operator` parameter

There is an issue in `updateBinary` where attempting to update
`operator` without updating `left` or `right` results in a silent no-op.

* Use defaulted parameter in `updateBinary`
This commit is contained in:
Marcel Laverdet
2020-05-05 09:05:02 -07:00
committed by GitHub
parent 94c5c3ff47
commit 44c6cf74cb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/factoryPublic.ts
View File

@@ -1411,10 +1411,11 @@ namespace ts {
return node;
}
export function updateBinary(node: BinaryExpression, left: Expression, right: Expression, operator?: BinaryOperator | BinaryOperatorToken) {
export function updateBinary(node: BinaryExpression, left: Expression, right: Expression, operator: BinaryOperator | BinaryOperatorToken = node.operatorToken) {
return node.left !== left
|| node.right !== right
? updateNode(createBinary(left, operator || node.operatorToken, right), node)
|| node.operatorToken !== operator
? updateNode(createBinary(left, operator, right), node)
: node;
}