microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-12 09:50:11 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Fix #39316. When the hover content is empty, do not show the hover widget container.

Browse Source
This commit is contained in:
Peng Lyu
2017-11-30 11:29:36 -08:00
parent 19341cae4c
commit f16ee654ab
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/editor/contrib/hover/modesContentHover.ts
View File

@@ -295,7 +295,8 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
// update column from which to show
var renderColumn = Number.MAX_VALUE,
highlightRange = messages[0].range,
fragment = document.createDocumentFragment();
fragment = document.createDocumentFragment(),
isEmptyHoverContent = true;
let containColorPicker = false;
messages.forEach((msg) => {
@@ -312,6 +313,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
.forEach(contents => {
const renderedContents = this._markdownRenderer.render(contents);
fragment.appendChild($('div.hover-row', null, renderedContents));
isEmptyHoverContent = false;
});
} else {
containColorPicker = true;
@@ -392,7 +394,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
// show
if (!containColorPicker) {
if (!containColorPicker && !isEmptyHoverContent) {
this.showAt(new Position(renderRange.startLineNumber, renderColumn), this._shouldFocus);
this.updateContents(fragment);
}