From f16ee654ab2e175faefc54b62fb91bcd4e332904 Mon Sep 17 00:00:00 2001
From: Peng Lyu <penn.lv@gmail.com>
Date: Thu, 30 Nov 2017 11:29:36 -0800
Subject: [PATCH] Fix #39316. When the hover content is empty, do not show the
 hover widget container.

---
 src/vs/editor/contrib/hover/modesContentHover.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/vs/editor/contrib/hover/modesContentHover.ts b/src/vs/editor/contrib/hover/modesContentHover.ts
index 00ec6881e85..4e93efdcb96 100644
--- a/src/vs/editor/contrib/hover/modesContentHover.ts
+++ b/src/vs/editor/contrib/hover/modesContentHover.ts
@@ -295,7 +295,8 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
 		// update column from which to show
 		var renderColumn = Number.MAX_VALUE,
 			highlightRange = messages[0].range,
-			fragment = document.createDocumentFragment();
+			fragment = document.createDocumentFragment(),
+			isEmptyHoverContent = true;
 
 		let containColorPicker = false;
 		messages.forEach((msg) => {
@@ -312,6 +313,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
 					.forEach(contents => {
 						const renderedContents = this._markdownRenderer.render(contents);
 						fragment.appendChild($('div.hover-row', null, renderedContents));
+						isEmptyHoverContent = false;
 					});
 			} else {
 				containColorPicker = true;
@@ -392,7 +394,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
 
 		// show
 
-		if (!containColorPicker) {
+		if (!containColorPicker && !isEmptyHoverContent) {
 			this.showAt(new Position(renderRange.startLineNumber, renderColumn), this._shouldFocus);
 			this.updateContents(fragment);
 		}