microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-13 21:47:12 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Fix TypeScript Verbose Logging not Printing Out Argument Values (#17559)

Browse Source 
Fixes #17488

**Bug**
In the calls to `JSON.stringify`, we are currently passing in `[]` as a whitelist. This results in no argument values being printed.

**Fix**
Pass in null instead so that we print all argument values
This commit is contained in:
Matt Bierner
2016-12-19 13:36:59 -08:00
committed by GitHub
parent da6faa4f96
commit ab481aac77
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript/src/typescriptServiceClient.ts
View File

@@ -709,7 +709,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
}
let data: string | undefined = undefined;
if (this.trace === Trace.Verbose && request.arguments) {
data = `Arguments: ${JSON.stringify(request.arguments, [], 4)}`;
data = `Arguments: ${JSON.stringify(request.arguments, null, 4)}`;
}
this.logTrace(`Sending request: ${request.command} (${request.seq}). Response expected: ${responseExpected ? 'yes' : 'no'}. Current queue length: ${this.requestQueue.length}`, data);
}
@@ -720,7 +720,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
}
let data: string | undefined = undefined;
if (this.trace === Trace.Verbose && response.body) {
data = `Result: ${JSON.stringify(response.body, [], 4)}`;
data = `Result: ${JSON.stringify(response.body, null, 4)}`;
}
this.logTrace(`Response received: ${response.command} (${response.request_seq}). Request took ${Date.now() - startTime} ms. Success: ${response.success} ${!response.success ? '. Message: ' + response.message : ''}`, data);
}
@@ -731,7 +731,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
}
let data: string | undefined = undefined;
if (this.trace === Trace.Verbose && event.body) {
data = `Data: ${JSON.stringify(event.body, [], 4)}`;
data = `Data: ${JSON.stringify(event.body, null, 4)}`;
}
this.logTrace(`Event received: ${event.event} (${event.seq}).`, data);
}