From ab481aac77276e773cf911ccacc2ec42fef73020 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 19 Dec 2016 13:36:59 -0800 Subject: [PATCH] Fix TypeScript Verbose Logging not Printing Out Argument Values (#17559) Fixes #17488 **Bug** In the calls to `JSON.stringify`, we are currently passing in `[]` as a whitelist. This results in no argument values being printed. **Fix** Pass in null instead so that we print all argument values --- extensions/typescript/src/typescriptServiceClient.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/typescript/src/typescriptServiceClient.ts b/extensions/typescript/src/typescriptServiceClient.ts index 0255d63de50..01e987c5511 100644 --- a/extensions/typescript/src/typescriptServiceClient.ts +++ b/extensions/typescript/src/typescriptServiceClient.ts @@ -709,7 +709,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient } let data: string | undefined = undefined; if (this.trace === Trace.Verbose && request.arguments) { - data = `Arguments: ${JSON.stringify(request.arguments, [], 4)}`; + data = `Arguments: ${JSON.stringify(request.arguments, null, 4)}`; } this.logTrace(`Sending request: ${request.command} (${request.seq}). Response expected: ${responseExpected ? 'yes' : 'no'}. Current queue length: ${this.requestQueue.length}`, data); } @@ -720,7 +720,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient } let data: string | undefined = undefined; if (this.trace === Trace.Verbose && response.body) { - data = `Result: ${JSON.stringify(response.body, [], 4)}`; + data = `Result: ${JSON.stringify(response.body, null, 4)}`; } this.logTrace(`Response received: ${response.command} (${response.request_seq}). Request took ${Date.now() - startTime} ms. Success: ${response.success} ${!response.success ? '. Message: ' + response.message : ''}`, data); } @@ -731,7 +731,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient } let data: string | undefined = undefined; if (this.trace === Trace.Verbose && event.body) { - data = `Data: ${JSON.stringify(event.body, [], 4)}`; + data = `Data: ${JSON.stringify(event.body, null, 4)}`; } this.logTrace(`Event received: ${event.event} (${event.seq}).`, data); }