Commit Graph

30176 Commits

Author SHA1 Message Date
Sheetal Nandi
5d6a5d04ea Fix detecting default project when file is part for more than one project but not part of default configured project (eg because its output of that projet) (#38429)
Fixes #38366
2020-05-12 10:16:59 -07:00
Nathan Shively-Sanders
3f06adf662 Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements
feat: Add outlining spans for object destructuring elements
2020-05-12 07:35:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed feat(38225): change diagnostic message for remove braces from arrow function body (#38226) 2020-05-12 07:27:09 -07:00
Alexander T
5895493815 fix(37877): include in NavigationBar default exported child items (#38255) 2020-05-12 07:26:31 -07:00
csigs
f4872eb493 LEGO: Merge pull request 38492
LEGO: Merge pull request 38492
2020-05-11 21:11:26 -07:00
csigs
0e37296396 LEGO: check in for master to temporary branch. 2020-05-12 04:10:41 +00:00
Daniel Rosenwasser
f9e1bcd0c4 Merge pull request #38439 from lissein/void-0-template-strings
Changed template strings to emit void 0 instead of undefined (#38430)
2020-05-11 17:09:28 -07:00
csigs
db0cd30898 LEGO: Merge pull request 38488
LEGO: Merge pull request 38488
2020-05-11 15:11:55 -07:00
csigs
27b9daf0a3 LEGO: check in for master to temporary branch. 2020-05-11 22:10:44 +00:00
Ron Buckton
d07e866a28 Fix for jsdoc modifiers on constructor params (#38403)
* Fix for jsdoc modifiers on constructor params

* Update Public API baseline and fix unique symbol grammar check for js
2020-05-11 15:07:43 -07:00
Nathan Shively-Sanders
1a88430a7e Improve assert message in binder (#38270)
* Improve assert message in binder

Looking at the code, I don't think the assert can ever fire, but it
clearly does, or did in the past. This will make it easier for people to
create a repro.

* fix lint

* Use BindableStaticNameExpression not BindableStaticAccessExpression

This type does allow identifiers, but those are ruled out earlier, so I added
an assert for that case.
2020-05-11 13:40:54 -07:00
jeffy-g
fd71eb2c85 fix broken regex on "src/services/completions.ts#getCompletionData" (#37546)
* fix broken regex on src/services/completions.ts#840

* update forslash test

breaking changes fourslash test

Temporarily retain the before fix code for easy comparison

* regex

* fourslash test (Temporary code

* regex: more restrictive in terms of jsdoc format

fourslash test

* regex: max indent restriction

* achieved goal by partial match strategy (probably

* cleanup

* apply requested changes

* Change to a version with minimal modifications
2020-05-11 13:02:20 -07:00
Wenqi
1b7b3eb0f7 report error for duplicate @type declaration (#38340) 2020-05-11 12:47:49 -07:00
Alexander T
738b6b5b68 fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (#38107) 2020-05-11 12:25:25 -07:00
TypeScript Bot
4109bba9e1 Update user baselines (#38472)
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-05-11 11:05:15 -07:00
TypeScript Bot
5653cecc17 Update user baselines (#38405)
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-05-11 09:00:10 -07:00
lissein
946abeadb0 Changed template strings to emit void 0 instead of undefined (#38430)
undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.
2020-05-09 04:53:14 +02:00
Wesley Wigham
7b03835b77 Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (#38368)
* Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit

* Add special lookups test case, rename helper

* Accept slightly modified baselines
2020-05-08 10:46:28 -07:00
csigs
083dbe4b8c LEGO: Merge pull request 38424
LEGO: Merge pull request 38424
2020-05-08 09:15:52 -07:00
csigs
92b7d8b6f2 LEGO: check in for master to temporary branch. 2020-05-08 16:13:19 +00:00
Manuel Thalmann
cbc959ba35 Make isDynamicFileName available publicly (#38269)
* Make isDynamicFileName available publicly

This commit fixes #37987

* Acknowledge Public APIs
2020-05-08 07:31:59 -07:00
csigs
7ac641d6a4 LEGO: Merge pull request 38411
LEGO: Merge pull request 38411
2020-05-07 21:11:59 -07:00
csigs
ece47d9d9a LEGO: check in for master to temporary branch. 2020-05-08 04:10:54 +00:00
csigs
e4950b245f LEGO: Merge pull request 38404
LEGO: Merge pull request 38404
2020-05-07 15:11:59 -07:00
csigs
9ba861904b LEGO: check in for master to temporary branch. 2020-05-07 22:11:10 +00:00
Anders Hejlsberg
0091fd6c64 Exclude arrays and tuples from full intersection property check (#38395)
* Exclude arrays and tuples from full intersection property check

* Add regression test
2020-05-07 15:03:51 -07:00
Anders Hejlsberg
7798f532df Fix crash caused by assertion with evolving array type (#38398)
* Properly finalize evolving array type in getTypeAtFlowCall

* Add regression test
2020-05-07 14:05:57 -07:00
TypeScript Bot
f08863d2fc Update user baselines (#38128)
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-05-07 13:05:02 -07:00
csigs
35d4a063eb LEGO: Merge pull request 38393
LEGO: Merge pull request 38393
2020-05-07 09:11:27 -07:00
csigs
1d2414822d LEGO: check in for master to temporary branch. 2020-05-07 16:10:38 +00:00
Eli Barzilay
29cf049e61 moveToNewFile: handle namespace imports too
Fixes #35591
2020-05-07 11:46:36 -04:00
Jack Williams
05d59a1f1a Unify logic in typeof narrowing (#33434) 2020-05-06 15:15:24 -07:00
csigs
ab63176052 LEGO: Merge pull request 38375
LEGO: Merge pull request 38375
2020-05-06 15:11:42 -07:00
csigs
c08b020ae9 LEGO: check in for master to temporary branch. 2020-05-06 22:10:57 +00:00
Alexander T
683b3ec058 feat(37782): 'declare method' quick fix for adding a private method (#37806)
* feat(37782): add quick-fix action to declare a private method for names that start from underscore

* better merge order in messages json

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-05-06 15:10:02 -07:00
Wenlu Wang
e66ce879a9 expose jsdoc factory (#29539)
* expose jsdoc factory

* refactor jsdoc factory

* correctly jsdoc factory types

* update jsdoc factory

* Add check for delete expression must be optional

* accept new basseline

* Revert "Add check for delete expression must be optional"

This reverts commit 76937c3b1a.

* remove newline

* make linter happy

* Add deprecated comment

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-05-06 15:06:12 -07:00
Wenlu Wang
8d78984558 Add support of contextual quick info (#37451)
* Add support of contextual quick info

* Avoid document comment map

* Make lint happy

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-05-06 15:05:31 -07:00
Nathan Shively-Sanders
35c1ba67ba Update LKG 2020 05 06 (#38371)
* Update LKG

* remove now-extraneous casts
2020-05-06 14:42:05 -07:00
Josh Goldberg
be2eb8a2e1 Allowed comment directives to be multiline (#38228)
* Allowed comment directives to be multiline

* Added tests, and perhaps fixed a test runner bug?

* I think it's going to need a consistent variable to loop over

* Used dynamically computed indexes in verifies

* Added multiline tests

* Increased flexibility for multiline comment parsing

* Undid a couple of formatting changes; removed backslashes from multiline regexp

* Added baseline tests for multiline comment skipping

Co-authored-by: Orta Therox <orta.therox@gmail.com>
2020-05-06 13:09:29 -07:00
Ron Buckton
4b08c0582d Fix regression in name resolution in parameter (#38351) 2020-05-06 12:04:28 -07:00
Alexander T
ec93a7cf7b fix(36055): forbid union type with invalid types in the 'in' operator (#37786) 2020-05-06 11:41:50 -07:00
Andrei Arkhipov
8746d1708f Updating dependencies (#37788)
* Bump fs-extra from 6.0.1 to 9.0.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 6.0.1 to 9.0.0.
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases)
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jprichardson/node-fs-extra/compare/6.0.1...9.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump azure-devops-node-api from 8.1.1 to 10.1.0

Bumps [azure-devops-node-api](https://github.com/Microsoft/azure-devops-node-api) from 8.1.1 to 10.1.0.
- [Release notes](https://github.com/Microsoft/azure-devops-node-api/releases)
- [Commits](https://github.com/Microsoft/azure-devops-node-api/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump eslint-plugin-jsdoc from 21.0.0 to 22.1.0

Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 21.0.0 to 22.1.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v21.0.0...v22.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump @typescript-eslint/eslint-plugin from 2.18.0 to 2.26.0

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 2.18.0 to 2.26.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.26.0/packages/eslint-plugin)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump eslint-plugin-import from 2.20.0 to 2.20.2

Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.0 to 2.20.2.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.20.0...v2.20.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump eslint-formatter-autolinkable-stylish from 1.1.1 to 1.1.2

Bumps [eslint-formatter-autolinkable-stylish](https://github.com/a-tarasyuk/eslint-formatter-autolinkable-stylish) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/a-tarasyuk/eslint-formatter-autolinkable-stylish/releases)
- [Commits](https://github.com/a-tarasyuk/eslint-formatter-autolinkable-stylish/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump @typescript-eslint/parser from 2.18.0 to 2.27.0

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 2.18.0 to 2.27.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.27.0/packages/parser)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump @typescript-eslint/eslint-plugin from 2.26.0 to 2.27.0

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 2.26.0 to 2.27.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.27.0/packages/eslint-plugin)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump @typescript-eslint/experimental-utils from 2.18.0 to 2.27.0

Bumps [@typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 2.18.0 to 2.27.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/experimental-utils/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.27.0/packages/experimental-utils)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-06 11:38:49 -07:00
csigs
4f4b44cc20 LEGO: Merge pull request 38355
LEGO: Merge pull request 38355
2020-05-05 21:11:30 -07:00
csigs
c33d6044fa LEGO: check in for master to temporary branch. 2020-05-06 04:10:41 +00:00
Anders Hejlsberg
2524fb164a Consistent narrowing by discriminant (#38311)
* Consistent requirements for narrowing by discriminant

* Add tests
2020-05-05 20:06:07 -07:00
Alexander T
c219fdae08 fix(37703): forbid required parameter after optional (#38155) 2020-05-05 10:29:17 -07:00
Alexander T
d86bdf4e5c add outlining spans for the tuple type (#38179) 2020-05-05 09:48:33 -07:00
Alexander T
2bdc8fdc94 add outlining spans for array destructuring elements (#38191) 2020-05-05 09:29:24 -07:00
Marcel Laverdet
44c6cf74cb Fix updateBinary operator parameter (#38129)
* Fix `updateBinary` `operator` parameter

There is an issue in `updateBinary` where attempting to update
`operator` without updating `left` or `right` results in a silent no-op.

* Use defaulted parameter in `updateBinary`
2020-05-05 09:05:02 -07:00
Daniel Rosenwasser
94c5c3ff47 Add missing arguments to typeToTypeNode. (#38336)
* Add missing arguments to typeToTypeNode.

* Use returnTypeNode as the enclosingDeclaration.

* Add a test.
2020-05-04 19:32:27 -07:00