Benjamin Lichtman
0e985eb342
Merge branch 'master' into asyncCatchUniqueNames
2018-09-14 09:50:27 -07:00
Benjamin Lichtman
98055ad540
Use separate map with smaller scope to track renames
2018-09-14 09:46:58 -07:00
Benjamin Lichtman
13deedf841
Merge pull request #26930 from uniqueiniquity/onlyReportExpectedPromiseArgs
...
Only perform async code fix if it can successfully refactor all parts
2018-09-14 09:41:34 -07:00
Andy
95c1570c4b
Fix bug: VariableDeclaration may have SemanticMeaning.All if an @enum in JS ( #27085 )
2018-09-14 09:20:54 -07:00
Andy
009dc0f1b9
For completion in string literal union, don't include strings already in the union ( #26755 )
2018-09-14 09:20:11 -07:00
Benjamin Lichtman
57a6dbd6fa
Add clarifying comments
2018-09-14 08:50:18 -07:00
Andy
ee7d0e21da
getEditsForFileRename: Don't resolve to a.js when a.ts is moved ( #27081 )
2018-09-13 15:49:42 -07:00
Andy
f71d6005a2
Use nextToken() after parsing a tag name so we can parse type keywords ( #26915 )
...
* Use nextToken() after parsing a tag name so we can parse type keywords
* Make callback to skipWhitespaceOrAsterisk non-optional
2018-09-13 15:49:06 -07:00
Andy
ebfcc1b52d
Fix bug: Ignore @enum tag in TS ( #27076 )
2018-09-13 15:24:49 -07:00
Nathan Shively-Sanders
64d0e0d448
Shorten more internal names to JS or TS ( #27080 )
2018-09-13 15:05:57 -07:00
Dan Rollo
2b0e9e686b
typo: missing word: "to" ( #27079 )
...
Change:
...a resolve callback used resolve the promise...
to:
...a resolve callback used to resolve the promise...
This PR suggested from: https://github.com/Microsoft/TypeScript/pull/27075
2018-09-13 14:23:56 -07:00
Andy
1a69f78fba
Fix bug: Ensure export = symbol always has a valueDeclaration ( #26973 )
2018-09-13 12:53:46 -07:00
Benjamin Lichtman
e700022cef
Remove unnecessary case
2018-09-13 09:46:40 -07:00
Benjamin Lichtman
d12110d3e5
Respond to CR
2018-09-13 09:32:38 -07:00
Benjamin Lichtman
504b5f2985
Add and update tests
2018-09-13 09:04:52 -07:00
Benjamin Lichtman
905578cf37
Use existing identifier when possible for renaming functions
2018-09-13 09:02:02 -07:00
Andy
cc7bfc0349
Support testing jsdoc tags of completions ( #26962 )
2018-09-13 08:47:50 -07:00
Daniel Rosenwasser
932e14e661
Merge pull request #27064 from Microsoft/makeFileLevelOptimisticUniqueName
...
makeFileLevelOptmiisticUniqueName -> makeFileLevelOptimisticUniqueName
2018-09-13 01:45:55 -07:00
Daniel Rosenwasser
ea7ff15307
makeFileLevelOptmiisticUniqueName -> makeFileLevelOptimisticUniqueName
2018-09-12 17:51:57 -07:00
Andy
2b888c30f9
Consistently pass indent to 'parseTagComments' ( #27055 )
...
* Consistently pass indent to 'parseTagComments'
* Update baselines
2018-09-12 17:44:06 -07:00
Wesley Wigham
d3463ce356
Avoid circularly resolving names when looking up type members using resolveName ( #26924 )
...
* Avoid circularly resolving names when looking up type members using resolveName
* Add comment
2018-09-12 17:16:34 -07:00
Nathan Shively-Sanders
614423b287
Fix this-type in prototype-assigned object literals ( #26925 )
...
* Fix this-type in prototype-assigned object literals
Some cases were missing from tryGetThisTypeAt.
Fixes #26831
* Lookup this in JS only for @constructor+prototype assignments
2018-09-12 16:21:17 -07:00
Benjamin Lichtman
95e5f7d55a
Add and update tests
2018-09-12 14:47:13 -07:00
Benjamin Lichtman
906fbae37b
Handle promise handler block bodies with no return and other cleanup
2018-09-12 14:47:06 -07:00
Nathan Shively-Sanders
2f8a646f8e
isExpandoFunctionDeclaration only checks values ( #27052 )
...
Previously it checked types too, which caused a crash because types
don't have valueDeclaration set. But expando functions can't export
types, only values.
2018-09-12 12:21:50 -07:00
Nathan Shively-Sanders
6bd1da20c9
Rename JS-specific concepts ( #26795 )
...
* Rename JS concepts
1. Assignment declaration -- an assignment that is treated like a
declaration. Previously called [JS] special (assignment|declaration),
among other things.
2. Expando -- a value that can be used as a target in assignment
declarations. Currently, a class, function or empty object literal.
Functions are allowed in Typescript, too. Previously called a JS
container, JS initializer or expando object.
3. JavaScript -> Javascript. This is annoying to type, and looks like
'Java Script' in a camelCase world.
Everything is a pure rename as far as I know. The only test change is
the API baselines, which reflect the rename from SymbolFlags.JSContainer
to SymbolFlags.Assignment.
* Remove TODO
* Rename Javascript->JS
Note that this introduces a variable name collision in a couple of
places, which I resolved like this:
```ts
const isInJavascript = isInJSFile(node);
```
2018-09-12 10:44:46 -07:00
TypeScript Bot
371ffffc6d
Update user baselines ( #27048 )
2018-09-12 10:17:26 -07:00
Ryan Cavanaugh
5a26747428
Merge pull request #27004 from RyanCavanaugh/noJsNewModuleCompletions
...
Don't offer module completions in non-module JS files
2018-09-12 08:32:14 -07:00
Ron Buckton
f2a1a428ea
Merge pull request #27035 from Microsoft/fixTypesVersionTests
...
Sanitize module resolution logs for typesVersions entries
2018-09-11 14:45:39 -07:00
Wesley Wigham
31374d21bf
Provide suggestions for common can-not-find-name errors ( #27034 )
2018-09-11 14:42:17 -07:00
Ron Buckton
5d79704931
Sanitize module resolution logs for typesVersions entries
2018-09-11 14:19:28 -07:00
Wesley Wigham
1c1379252e
Prefer elaborating on expressions which could be called to produce a correct type by suggesting such ( #27016 )
...
* Prefer elaborating on expressions which could be called to produce a correct type by suggesting such
* Pass relation through elaboration machinery
2018-09-11 14:11:31 -07:00
Daniel Rosenwasser
aa9230f313
Merge pull request #27020 from Kingwl/improve_accidentally_calling_type-assertion_expressions
...
improve Diagnostics for accidentally calling type-assertion expressions
2018-09-11 14:00:31 -07:00
Sheetal Nandi
e1daa470a3
Merge pull request #26983 from Tyriar/26850_invert_gutter
...
Invert gutter instead of setting colors
2018-09-11 11:33:37 -07:00
Sheetal Nandi
08c970a03d
Merge pull request #26865 from chrissantos1995/bugs/fix-empty-files-diagnostics
...
Fix empty files diagnostics reporting
2018-09-11 11:25:29 -07:00
Benjamin Lichtman
9079df1a4d
Update baselines
2018-09-11 11:12:11 -07:00
Benjamin Lichtman
92edc2db56
[WIP] Record original name of renamed variable
2018-09-11 11:12:11 -07:00
Benjamin Lichtman
a4c87df821
[WIP] Use original identifier name to count up from when renaming collisions
2018-09-11 11:12:11 -07:00
Benjamin Lichtman
7466ac1cd5
[WIP] add test
2018-09-11 11:12:10 -07:00
Benjamin Lichtman
8c9e8666ed
Miscellaneous cleanup
2018-09-11 11:12:10 -07:00
王文璐
2cf2bbd5f7
improve test case and add related diagnostic
2018-09-11 16:20:38 +08:00
Ron Buckton
ba8595be5f
Merge pull request #27021 from ajafff/fix-functiontype-emit
...
Fix FunctionType emit when only parameter has no type
2018-09-11 01:07:43 -07:00
Klaus Meinhardt
66a401ae64
Fix FunctionType emit when only parameter has no type
...
Fixes : #27018
2018-09-11 09:39:11 +02:00
王文璐
6b2ea463b2
improve Diagnostics for accidentally calling type-assertion expressions
2018-09-11 14:35:01 +08:00
Wesley Wigham
e9c6d967f6
Add related span pointing at missing arguments ( #27013 )
2018-09-10 16:40:33 -07:00
TypeScript Bot
78c8003504
Update user baselines ( #27000 )
2018-09-10 13:22:30 -07:00
Andy
24a5bdd1b1
Add 'fileToRename' property to RenameInfo ( #24702 )
...
* Add 'fileToRename' property to RenameInfo
* Update tests
* Support directory rename
2018-09-10 11:25:03 -07:00
Ryan Cavanaugh
95ba73e16b
Don't offer module completions in non-module JS files
2018-09-10 11:24:51 -07:00
Daniel Imms
745f5be2cb
Invert gutter instead of setting colors
...
Fixes #26850
2018-09-08 13:26:14 -07:00
christian
16477b6506
Take into account undefined nodeValue when recording diagnostic
2018-09-08 00:06:07 -04:00