microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix bug: Ignore @enum tag in TS (#27076)

Browse Source
This commit is contained in:
Andy
2018-09-13 15:24:49 -07:00
committed by GitHub
parent 64d0e0d448
commit ebfcc1b52d
6 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/binder.ts
View File

@@ -2666,7 +2666,7 @@ namespace ts {
}
if (!isBindingPattern(node.name)) {
const isEnum = !!getJSDocEnumTag(node);
const isEnum = isInJSFile(node) && !!getJSDocEnumTag(node);
const enumFlags = (isEnum ? SymbolFlags.RegularEnum : SymbolFlags.None);
const enumExcludes = (isEnum ? SymbolFlags.RegularEnumExcludes : SymbolFlags.None);
if (isBlockOrCatchScoped(node)) {

4
tests/baselines/reference/jsdocInTypeScript.errors.txt
View File

@@ -67,4 +67,8 @@ tests/cases/compiler/jsdocInTypeScript.ts(42,12): error TS2503: Cannot find name
* @type {{foo: (function(string, string): string)}}
*/
const obj = { foo: (a, b) => a + b };
/** @enum {string} */
var E = {};
E[""];

7
tests/baselines/reference/jsdocInTypeScript.js
View File

@@ -47,6 +47,10 @@ import M = N; // Error: @typedef does not create namespaces in TypeScript code.
* @type {{foo: (function(string, string): string)}}
*/
const obj = { foo: (a, b) => a + b };
/** @enum {string} */
var E = {};
E[""];
//// [jsdocInTypeScript.js]
@@ -79,3 +83,6 @@ var M = N; // Error: @typedef does not create namespaces in TypeScript code.
* @type {{foo: (function(string, string): string)}}
*/
var obj = { foo: function (a, b) { return a + b; } };
/** @enum {string} */
var E = {};
E[""];

7
tests/baselines/reference/jsdocInTypeScript.symbols
View File

@@ -83,3 +83,10 @@ const obj = { foo: (a, b) => a + b };
>a : Symbol(a, Decl(jsdocInTypeScript.ts, 47, 20))
>b : Symbol(b, Decl(jsdocInTypeScript.ts, 47, 22))
/** @enum {string} */
var E = {};
>E : Symbol(E, Decl(jsdocInTypeScript.ts, 50, 3))
E[""];
>E : Symbol(E, Decl(jsdocInTypeScript.ts, 50, 3))

10
tests/baselines/reference/jsdocInTypeScript.types
View File

@@ -93,3 +93,13 @@ const obj = { foo: (a, b) => a + b };
>a : any
>b : any
/** @enum {string} */
var E = {};
>E : {}
>{} : {}
E[""];
>E[""] : any
>E : {}
>"" : ""

4
tests/cases/compiler/jsdocInTypeScript.ts
View File

@@ -46,3 +46,7 @@ import M = N; // Error: @typedef does not create namespaces in TypeScript code.
* @type {{foo: (function(string, string): string)}}
*/
const obj = { foo: (a, b) => a + b };
/** @enum {string} */
var E = {};
E[""];