Daniel Rosenwasser
c5aa91391e
Placeholder intermediate work.
2020-05-14 11:35:09 -07:00
sergeir82
b346f5764e
prefix-unused-parameter-with-_ codefix now works in jsdoc @param ( #36152 )
...
* Fix prepending unused TypeScript variables with underscore doesn't rename JSDoc @param.
Fix test for quick fix "Prefix all unused declarations with '_' where possible".
Fixes #33021 .
* Replace FindAllReferences.Core.eachSymbolReferenceInFile function call to more ligher call of getJSDocParameterTags when searching for a parameter in jsdoc.
* Remove redundant constant declaration.
* Add test for prefix single unused parameter in jsdoc.
2020-04-17 13:18:05 -07:00
Wesley Wigham
deb5bac520
Use string representation for negative numeric property names ( #37936 )
2020-04-15 21:11:05 -07:00
TypeScript Bot
ca1f467233
Update user baselines ( #37946 )
...
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-04-15 13:55:30 -07:00
Wesley Wigham
cdc384006c
Fix crash on declaration emit for globalThis ( #37992 )
2020-04-15 13:37:51 -07:00
Alexander T
a16c44180a
fix(37940): add space after parameter decorator ( #37959 )
2020-04-15 11:42:29 -07:00
Nathan Shively-Sanders
6fbaeeb42f
Typo at Uint8Array[Symbol.toStringTag] ( #37989 )
...
* Update es2015.symbol.wellknown.d.ts
* Update baselines
Co-authored-by: sirian <sirianru@gmail.com>
2020-04-15 11:40:33 -07:00
Joe Previte
583e70b3d1
fix(refactor): keep comments after refactor ( #35937 )
...
* add two tests: Refactor: Remove braces from arrow function
* refactor: simplify test and add another test
* fix: copyTrailingAsLeadingComments in addOrRemoveBracesToArrowFunction
* test: add additional test
* fix: clean up changes
* fix: add check for newEdit
* fix: add function for semi colon modifier
* feat: grab all comments during refactor
* refactor: update addOrRemoveBraces logic
* fix: remove duplicate function call
* Update src/services/refactors/addOrRemoveBracesToArrowFunction.ts
* remove blank line
remove blank line
Co-authored-by: Jesse Trinity <42591254+jessetrinity@users.noreply.github.com>
2020-04-15 11:06:04 -07:00
okmttdhr
06e05f25e1
Improve error message for computed enums ( #37790 )
...
* Add error message for computed enums
* Add test case for computed enums
* Accept baselines
* Fix returned value when error
2020-04-15 13:50:33 -04:00
Anders Hejlsberg
92cd3ae299
No iteration type errors during CFA ( #37965 )
...
* No iteration type errors during CFA
* Add regression test
2020-04-15 10:34:07 -07:00
csigs
15c3e99cbd
LEGO: Merge pull request 37976
...
LEGO: Merge pull request 37976
2020-04-14 21:11:08 -07:00
csigs
e505c79091
LEGO: check in for master to temporary branch.
2020-04-15 04:10:28 +00:00
csigs
04069db846
LEGO: Merge pull request 37969
...
LEGO: Merge pull request 37969
2020-04-14 15:11:21 -07:00
csigs
49f5fbb2c7
LEGO: check in for master to temporary branch.
2020-04-14 22:10:38 +00:00
Ashley Claymore
4538640d8a
Added error when Enum member initaliser references itself ( #34655 )
...
Fixes #34606
2020-04-14 15:20:19 -04:00
Wesley Wigham
edd4e0a42b
Add fastpath to isRelatedTo for type references ( #37481 )
...
* Add fastpath to isRelatedTo for type references
* Do not check intersections or unions to ignore propegating reference flags, properly set comparing jsx flag
* Re-remove unneeded check
* Just check for TypeFlags.Object
* Remove else clause
2020-04-13 15:54:37 -07:00
Wesley Wigham
8dd6b3a389
Accept recent tests with updated baseline code ( #37945 )
2020-04-13 15:34:34 -07:00
TypeScript Bot
cede6ef30e
Update user baselines ( #37935 )
...
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-04-13 15:08:41 -07:00
Wesley Wigham
6a5508b343
Update __exportStar helper to skip default and __esModule members ( #37236 )
...
* Update __exportStar helper to skip default and __esModule
* Accept new baselines
* Remove esmodule check from helper
2020-04-13 13:10:24 -07:00
Pierre-Antoine Mills
eb569a5c74
chore(ts-toolbelt): remove deprecated test ( #37932 )
2020-04-13 12:32:01 -07:00
Wesley Wigham
141ee01c8c
Retain imports in declaration emit if they augment an export of the importing file ( #37820 )
...
* Retain imports in declaration emit if they augment an export of the importing file
* (sp)
* Check that a merge occurs, just because
2020-04-13 12:31:14 -07:00
Alexander T
a8e1ad4e62
fix(37781): import missing argument types for a new method ( #37857 )
2020-04-13 10:23:12 -07:00
Nathan Shively-Sanders
5f46d42ad1
Error on missing BigInt in es2020 ( #37899 )
...
* Error on missing BigInt in ES2020 too.
Previously it was only on ESNext, but bigint ships in ES 2020.
There are no tests for this; passing `false` doesn't cause any tests to
fail at least.
* add tests
2020-04-13 08:30:59 -07:00
Nathan Shively-Sanders
eb105efdcd
Avoid circular reference in this-property assignments ( #37827 )
...
* Avoid circular reference in this-property assignments
To do this, don't check this-property assigments that have the
this-property of the lhs appearing somewhere on the rhs:
```js
class C {
m() {
this.x = 12
this.x = this.x + this.y
}
}
```
I tried suppressing the circularity error, but because we cache the
first type discovered for a property, this still results in an implicit
any for `x` in the previous example. It just doesn't have an error.
Fixes #35099
* Add test case + rename function
* Use isMatchingReference
2020-04-10 16:41:31 -07:00
Alexander T
795a5c83fe
fix(37150): ignore private fields in string index type checking ( #37183 )
2020-04-10 12:53:53 -04:00
Alexander T
aa6be6ee6f
fix(37364): show completions for string literal index on mapped type ( #37367 )
2020-04-10 12:36:26 -04:00
Anders Hejlsberg
52dc9f2282
No recursive intersection property checks ( #37854 )
...
* No recursive intersection property checks
* Add comment
2020-04-09 19:23:36 -07:00
Anders Hejlsberg
6b1c102bd1
No excessive stack depth global errors ( #37873 )
...
* Report excessive stack depth on current node when no error node available
* Accept new baselines
2020-04-09 19:05:35 -07:00
Wesley Wigham
bc8a98ff00
Add node 13 to CI
2020-04-09 16:16:06 -07:00
Orta
23b6f6e469
Remove node 8 from the github actions ( #37870 )
2020-04-09 16:15:25 -07:00
Andrew Branch
95cc1c279e
Fix crash from missing valueDeclaration on intersection property ( #37696 )
...
* Add crashing test
* Fix missing valueDeclaration on intersection symbol property
* Remove assertion from serializeAsClass
2020-04-09 14:00:21 -07:00
Ron Buckton
4a646c9640
Fix parenthesization rules for yield ( #37849 )
2020-04-09 13:17:46 -07:00
Ravi van Rooijen
2a25901c54
Fix code block in jsdoc ( #37864 )
2020-04-09 13:31:41 -04:00
Andrew Branch
813efb49af
Lock playwright version ( #37869 )
2020-04-09 13:20:02 -04:00
Andrew Branch
24a17acf2c
Error on invalid uses of namespace export ( #37715 )
2020-04-09 09:42:16 -07:00
Andrew Branch
57f9076612
Remove extraneous string escape from convert to template string refactor ( #37743 )
...
* Add failing test
* Remove extraneous string escape
* Revert unnecessary change
2020-04-09 09:40:28 -07:00
Wesley Wigham
3d3854c93d
Set contextual type on elaborated error node rather than passing it, so its discriminated ( #37828 )
2020-04-09 02:55:39 -07:00
Nathan Shively-Sanders
f31b5a278f
fix build break by updating missed baseline
2020-04-08 15:38:40 -07:00
Ron Buckton
5db4e7add3
Fix async function block return expr error in js ( #37845 )
2020-04-08 15:26:56 -07:00
csigs
fd6f92255b
LEGO: Merge pull request 37848
...
LEGO: Merge pull request 37848
2020-04-08 15:11:25 -07:00
csigs
f5de3138de
LEGO: check in for master to temporary branch.
2020-04-08 22:10:41 +00:00
Wesley Wigham
b4838c8b62
Use comments from host variable declaration when exporting a signature in js declarations ( #37594 )
2020-04-08 13:32:17 -07:00
Ron Buckton
5a7916962d
Fix metadata serialization for invalid jsdoc types ( #37836 )
2020-04-08 12:06:40 -07:00
zhangciwu
126c6ab80d
Fix easy misunderstanding "! ===" ( #37838 )
...
* Remove unnecessary Non-null assertion operator
* Wrap Non-null assertion operator inside parentheses
2020-04-08 08:17:22 -07:00
Alexander T
e897eb1b2a
fix(37817): omit comments in name accessor ( #37822 )
2020-04-07 16:59:54 -07:00
Eli Barzilay
e4babd40e0
Skip isBlockScopedNameDeclaredBeforeUse error in interface or type declarations
...
Fixes #35947 .
2020-04-07 16:12:18 -04:00
Eli Barzilay
dcc6c9461e
Minor improvement
...
Get the `declaration` container just once instead of in three places.
(Minor change: one place used to start looking from
`declaration.parent`, but that shouldn't make any difference.) Also,
don't pass it to the helper functions since they're local anyway.
2020-04-07 16:12:18 -04:00
Orta
3398c9bfe1
Make skipLibCheck: true the default in --init ( #37808 )
2020-04-07 15:00:44 -04:00
Andrew Branch
3e86f15f51
Disambiguate types with same name from different namespaces in mapToTypeNodes ( #37543 )
...
* Disambiguate types with same name from different namespaces in mapToTypeNodes
* Update baseline with additional example
* Fix typo
2020-04-07 10:55:56 -07:00
Bannerets
c47aca0da3
Accurate Array.prototype.flat definition ( #32131 )
...
* Better Array.prototype.flat definition
* Use more meaningful names
* Rename 'Flat' to 'FlatArray'
2020-04-07 09:16:20 -07:00