microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(37364): show completions for string literal index on mapped type (#37367)

Browse Source
This commit is contained in:
Alexander T 2020-04-10 19:36:26 +03:00 committed by GitHub
parent 52dc9f2282
commit aa6be6ee6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/stringCompletions.ts
View File

@ -223,7 +223,9 @@ namespace ts.Completions.StringCompletions {
function stringLiteralCompletionsFromProperties(type: Type | undefined): StringLiteralCompletionsFromProperties | undefined {
return type && {
kind: StringLiteralCompletionKind.Properties,
symbols: type.getApparentProperties().filter(prop => !isPrivateIdentifierPropertyDeclaration(prop.valueDeclaration)),
symbols: type.getApparentProperties().filter(prop =>
!isPrivateIdentifierPropertyDeclaration(
isTransientSymbol(prop) && prop.syntheticOrigin ? prop.syntheticOrigin.valueDeclaration : prop.valueDeclaration)),
hasIndexSignature: hasIndexSignature(type)
};
}

18
tests/cases/fourslash/completionForStringLiteral_mappedTypeMembers.ts Normal file
View File

@ -0,0 +1,18 @@
/// <reference path='fourslash.ts'/>
////type Foo = {
//// a: string;
//// b: string;
////};
////
////type A = Readonly<Foo>;
////type B = A["[|/**/|]"]
const replacementSpan = test.ranges()[0];
verify.completions({
marker: "",
exact: [
{ name: "a", replacementSpan },
{ name: "b", replacementSpan }
]
});