mirror of
https://github.com/microsoft/TypeScript.git
synced 2026-02-06 02:33:53 -06:00
addressed PR feedback: added comment
This commit is contained in:
parent
dde7545d34
commit
dc2c968b08
@ -1026,6 +1026,10 @@ module Harness {
|
||||
} else if (setting.value.toLowerCase() === "commonjs") {
|
||||
options.module = ts.ModuleKind.CommonJS;
|
||||
if (options.moduleResolution === undefined) {
|
||||
// TODO: currently we have relative module names pretty much in all tests that use CommonJS module target.
|
||||
// Such names could never be resolved in Node however classic resolution strategy still can handle them.
|
||||
// Changing all module names to relative will be a major overhaul in code (but we'll do this anyway) so as a temporary measure
|
||||
// we'll use ts.ModuleResolutionKind.Classic for CommonJS modules.
|
||||
options.moduleResolution = ts.ModuleResolutionKind.Classic;
|
||||
}
|
||||
} else if (setting.value.toLowerCase() === "system") {
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user