From dc2c968b089bec6ca62a684f892672ef3b94b81d Mon Sep 17 00:00:00 2001 From: Vladimir Matveev Date: Fri, 21 Aug 2015 10:37:13 -0700 Subject: [PATCH] addressed PR feedback: added comment --- src/harness/harness.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/harness/harness.ts b/src/harness/harness.ts index fc2042c8272..49be582606e 100644 --- a/src/harness/harness.ts +++ b/src/harness/harness.ts @@ -1026,6 +1026,10 @@ module Harness { } else if (setting.value.toLowerCase() === "commonjs") { options.module = ts.ModuleKind.CommonJS; if (options.moduleResolution === undefined) { + // TODO: currently we have relative module names pretty much in all tests that use CommonJS module target. + // Such names could never be resolved in Node however classic resolution strategy still can handle them. + // Changing all module names to relative will be a major overhaul in code (but we'll do this anyway) so as a temporary measure + // we'll use ts.ModuleResolutionKind.Classic for CommonJS modules. options.moduleResolution = ts.ModuleResolutionKind.Classic; } } else if (setting.value.toLowerCase() === "system") {