microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-16 05:58:32 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix linting errors

Browse Source
This commit is contained in:
Arthur Ozga 2016-11-01 15:39:01 -07:00
parent 99ae5d9a99
commit aa6ecd4154
5 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts
View File

@ -11,11 +11,10 @@ namespace ts.codefix {
if (token.kind === SyntaxKind.Identifier && isClassLike(token.parent)) {
const classDeclaration = <ClassDeclaration>token.parent;
const startPos = classDeclaration.members.pos;
// TODO: (arozga) actually get abstract members
const abstractClassMembers = ts.map(getNamedAbstractClassMembers(classDeclaration), member => member.name.getText());
const trackingAddedMembers: string[] = [];
const extendsClause = ts.getClassExtendsHeritageClauseElement(classDeclaration);
let textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
const textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
if (textChanges.length > 0) {
return [{

2
src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts
View File

@ -18,7 +18,7 @@ namespace ts.codefix {
let textChanges: TextChange[] = undefined;
for (let i = 0; interfaceClauses && i < interfaceClauses.length; i++) {
let newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
const newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
textChanges = textChanges ? textChanges.concat(newChanges) : newChanges;
}

2
src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
View File

@ -13,7 +13,7 @@ namespace ts.codefix {
const extendsNode = (token.parent.parent as HeritageClause).getChildren()[0];
let result = [{
const result = [{
description: getLocaleSpecificMessage(Diagnostics.Change_extends_to_implements),
changes: [{
fileName: sourceFile.fileName,

6
src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts
View File

@ -13,13 +13,13 @@ namespace ts.codefix {
const classDeclaration = <ClassDeclaration>propertyDeclaration.parent;
const classKeywordStart = classDeclaration.getChildren()[0].getStart();
let codeFix: CodeAction[] = [
return [
{
description: `Remove abstract modifier from ${propertyDeclaration.name.getText()}.`,
changes: [{
fileName: sourceFile.fileName,
textChanges: [{
span: {start: start, length: context.span.length + /*space*/ 1},
span: { start: start, length: context.span.length + /*space*/ 1 },
newText: ""
}]
}]
@ -35,8 +35,6 @@ namespace ts.codefix {
}]
}
];
return codeFix;
}
});
}

6
src/services/utilities.ts
View File

@ -1368,8 +1368,8 @@ namespace ts {
}
const missingMembers = getMissingInterfaceMembers(<InterfaceDeclaration>type.symbol.declarations[0], existingMembers, checker);
for (let member of missingMembers) {
for (const member of missingMembers) {
if (member.kind === SyntaxKind.PropertySignature) {
const interfaceProperty = <PropertySignature>member;
if (trackingAddedMembers.indexOf(interfaceProperty.name.getText()) === -1) {
@ -1422,7 +1422,7 @@ namespace ts {
}
function getMissingInterfaceMembers(declaration: InterfaceDeclaration, existingMembers: string[], checker: TypeChecker): TypeElement[] {
let interfaceMembers = getInterfaceMembers(declaration, checker);
const interfaceMembers = getInterfaceMembers(declaration, checker);
return ts.filter(interfaceMembers, member => !member.name || existingMembers.indexOf(member.name.getText()) === -1);