From aa6ecd4154fbb7e1e74804b46e035d6a1a0eae7d Mon Sep 17 00:00:00 2001
From: Arthur Ozga <arozga@microsoft.com>
Date: Tue, 1 Nov 2016 15:39:01 -0700
Subject: [PATCH] Fix linting errors

---
 .../fixClassDoesntImplementInheritedAbstractMember.ts       | 3 +--
 .../codefixes/fixClassIncorrectlyImplementsInterface.ts     | 2 +-
 .../codefixes/fixExtendsInterfaceBecomesImplements.ts       | 2 +-
 .../fixRemoveAbstractModifierInNonAbstractClass.ts          | 6 ++----
 src/services/utilities.ts                                   | 6 +++---
 5 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts b/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts
index ce7eb04d2cd..3a209fbc27d 100644
--- a/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts
+++ b/src/services/codefixes/fixClassDoesntImplementInheritedAbstractMember.ts
@@ -11,11 +11,10 @@ namespace ts.codefix {
             if (token.kind === SyntaxKind.Identifier &&  isClassLike(token.parent)) {
                 const classDeclaration = <ClassDeclaration>token.parent;
                 const startPos = classDeclaration.members.pos;
-                // TODO: (arozga) actually get abstract members
                 const abstractClassMembers = ts.map(getNamedAbstractClassMembers(classDeclaration), member => member.name.getText());
                 const trackingAddedMembers: string[] = [];
                 const extendsClause = ts.getClassExtendsHeritageClauseElement(classDeclaration);
-                let textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
+                const textChanges = getCodeFixChanges(extendsClause, abstractClassMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
 
                 if (textChanges.length > 0) {
                     return [{
diff --git a/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts b/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts
index 9ff3a554c23..c8c84715a3d 100644
--- a/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts
+++ b/src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts
@@ -18,7 +18,7 @@ namespace ts.codefix {
                 let textChanges: TextChange[] = undefined;
 
                 for (let i = 0; interfaceClauses && i < interfaceClauses.length; i++) {
-                    let newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
+                    const newChanges = getCodeFixChanges(interfaceClauses[i], classMembers, startPos, checker, /*reference*/ false, trackingAddedMembers, context.newLineCharacter);
                     textChanges = textChanges ? textChanges.concat(newChanges) : newChanges;
                 }
 
diff --git a/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts b/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
index 4841bc43db4..e462d7416f7 100644
--- a/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
+++ b/src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
@@ -13,7 +13,7 @@ namespace ts.codefix {
 
             const extendsNode = (token.parent.parent as HeritageClause).getChildren()[0];
 
-            let result = [{
+            const result = [{
                 description: getLocaleSpecificMessage(Diagnostics.Change_extends_to_implements),
                 changes: [{
                     fileName: sourceFile.fileName,
diff --git a/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts b/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts
index 4fdd58c31a5..93b1513b149 100644
--- a/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts
+++ b/src/services/codefixes/fixRemoveAbstractModifierInNonAbstractClass.ts
@@ -13,13 +13,13 @@ namespace ts.codefix {
             const classDeclaration = <ClassDeclaration>propertyDeclaration.parent;
             const classKeywordStart = classDeclaration.getChildren()[0].getStart();
 
-            let codeFix: CodeAction[] = [
+            return [
                 {
                     description: `Remove abstract modifier from ${propertyDeclaration.name.getText()}.`,
                     changes: [{
                         fileName: sourceFile.fileName,
                         textChanges: [{
-                            span: {start: start, length: context.span.length + /*space*/ 1},
+                            span: { start: start, length: context.span.length + /*space*/ 1 },
                             newText: ""
                         }]
                     }]
@@ -35,8 +35,6 @@ namespace ts.codefix {
                     }]
                 }
             ];
-
-            return codeFix;
         }
     });
 }
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
index 57370cd45d1..5f4465f490e 100644
--- a/src/services/utilities.ts
+++ b/src/services/utilities.ts
@@ -1368,8 +1368,8 @@ namespace ts {
         }
 
         const missingMembers = getMissingInterfaceMembers(<InterfaceDeclaration>type.symbol.declarations[0], existingMembers, checker);
-        
-        for (let member of missingMembers) {
+
+        for (const member of missingMembers) {
             if (member.kind === SyntaxKind.PropertySignature) {
                 const interfaceProperty = <PropertySignature>member;
                 if (trackingAddedMembers.indexOf(interfaceProperty.name.getText()) === -1) {
@@ -1422,7 +1422,7 @@ namespace ts {
     }
 
     function getMissingInterfaceMembers(declaration: InterfaceDeclaration, existingMembers: string[], checker: TypeChecker): TypeElement[] {
-        let interfaceMembers = getInterfaceMembers(declaration, checker);
+        const interfaceMembers = getInterfaceMembers(declaration, checker);
 
         return ts.filter(interfaceMembers, member => !member.name || existingMembers.indexOf(member.name.getText()) === -1);