microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-17 10:31:20 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Revert "Return empty doc comment instead of undefined"

Browse Source 
This reverts commit 22eb519b0f6c4c06c71a7c2dd351bbec530f5dd9.
This commit is contained in:
uniqueiniquity 2017-11-02 10:59:58 -07:00
parent 509b9ad087
commit 12baae6c84
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/services/jsDoc.ts
View File

@ -190,26 +190,24 @@ namespace ts.JsDoc {
* be performed.
*/
export function getDocCommentTemplateAtPosition(newLine: string, sourceFile: SourceFile, position: number): TextInsertion {
const emptyDocComment = { newText: "", caretOffset: 0 };
// Check if in a context where we don't want to perform any insertion
if (isInString(sourceFile, position) || isInComment(sourceFile, position) || hasDocComment(sourceFile, position)) {
return emptyDocComment;
return undefined;
}
const tokenAtPos = getTokenAtPosition(sourceFile, position, /*includeJsDocComment*/ false);
const tokenStart = tokenAtPos.getStart();
if (!tokenAtPos || tokenStart < position) {
return emptyDocComment;
return undefined;
}
const commentOwnerInfo = getCommentOwnerInfo(tokenAtPos);
if (!commentOwnerInfo) {
return emptyDocComment;
return undefined;
}
const { commentOwner, parameters } = commentOwnerInfo;
if (commentOwner.getStart() < position) {
return emptyDocComment;
return undefined;
}
if (!parameters || parameters.length === 0) {