From 12baae6c843044dd03478d04ea862d62368500c2 Mon Sep 17 00:00:00 2001 From: uniqueiniquity Date: Thu, 2 Nov 2017 10:59:58 -0700 Subject: [PATCH] Revert "Return empty doc comment instead of undefined" This reverts commit 22eb519b0f6c4c06c71a7c2dd351bbec530f5dd9. --- src/services/jsDoc.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/services/jsDoc.ts b/src/services/jsDoc.ts index f1e06a0ffe4..c88fe261613 100644 --- a/src/services/jsDoc.ts +++ b/src/services/jsDoc.ts @@ -190,26 +190,24 @@ namespace ts.JsDoc { * be performed. */ export function getDocCommentTemplateAtPosition(newLine: string, sourceFile: SourceFile, position: number): TextInsertion { - const emptyDocComment = { newText: "", caretOffset: 0 }; - // Check if in a context where we don't want to perform any insertion if (isInString(sourceFile, position) || isInComment(sourceFile, position) || hasDocComment(sourceFile, position)) { - return emptyDocComment; + return undefined; } const tokenAtPos = getTokenAtPosition(sourceFile, position, /*includeJsDocComment*/ false); const tokenStart = tokenAtPos.getStart(); if (!tokenAtPos || tokenStart < position) { - return emptyDocComment; + return undefined; } const commentOwnerInfo = getCommentOwnerInfo(tokenAtPos); if (!commentOwnerInfo) { - return emptyDocComment; + return undefined; } const { commentOwner, parameters } = commentOwnerInfo; if (commentOwner.getStart() < position) { - return emptyDocComment; + return undefined; } if (!parameters || parameters.length === 0) {