microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-06 06:49:29 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Make it a parse error for an @augments jsdoc tag to not include a type (#18745)

Browse Source
This commit is contained in:
Andy
2017-09-25 09:26:59 -07:00
committed by GitHub
parent 0abfd6a165
commit 024b1fd913
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/parser.ts
View File

@@ -6599,12 +6599,12 @@ namespace ts {
const result = <JSDocTypeTag>createNode(SyntaxKind.JSDocTypeTag, atToken.pos);
result.atToken = atToken;
result.tagName = tagName;
result.typeExpression = parseJSDocTypeExpression(/*mayBail*/ true);
result.typeExpression = parseJSDocTypeExpression(/*requireBraces*/ true);
return finishNode(result);
}
function parseAugmentsTag(atToken: AtToken, tagName: Identifier): JSDocAugmentsTag {
const typeExpression = tryParseTypeExpression();
const typeExpression = parseJSDocTypeExpression(/*requireBraces*/ true);
const result = <JSDocAugmentsTag>createNode(SyntaxKind.JSDocAugmentsTag, atToken.pos);
result.atToken = atToken;

5
src/harness/unittests/jsDocParsing.ts
View File

@@ -144,6 +144,11 @@ namespace ts {
`/**
* @type
*/`);
parsesIncorrectly("@augments with no type",
`/**
* @augments
*/`);
});
describe("parsesCorrectly", () => {