From 024b1fd9137173837de88904529557760373f415 Mon Sep 17 00:00:00 2001 From: Andy Date: Mon, 25 Sep 2017 09:26:59 -0700 Subject: [PATCH] Make it a parse error for an `@augments` jsdoc tag to not include a type (#18745) --- src/compiler/parser.ts | 4 ++-- src/harness/unittests/jsDocParsing.ts | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts index 3809a071421..e2eb3efc012 100644 --- a/src/compiler/parser.ts +++ b/src/compiler/parser.ts @@ -6599,12 +6599,12 @@ namespace ts { const result = createNode(SyntaxKind.JSDocTypeTag, atToken.pos); result.atToken = atToken; result.tagName = tagName; - result.typeExpression = parseJSDocTypeExpression(/*mayBail*/ true); + result.typeExpression = parseJSDocTypeExpression(/*requireBraces*/ true); return finishNode(result); } function parseAugmentsTag(atToken: AtToken, tagName: Identifier): JSDocAugmentsTag { - const typeExpression = tryParseTypeExpression(); + const typeExpression = parseJSDocTypeExpression(/*requireBraces*/ true); const result = createNode(SyntaxKind.JSDocAugmentsTag, atToken.pos); result.atToken = atToken; diff --git a/src/harness/unittests/jsDocParsing.ts b/src/harness/unittests/jsDocParsing.ts index 209aaa48c19..2116d87dc6f 100644 --- a/src/harness/unittests/jsDocParsing.ts +++ b/src/harness/unittests/jsDocParsing.ts @@ -144,6 +144,11 @@ namespace ts { `/** * @type */`); + + parsesIncorrectly("@augments with no type", +`/** + * @augments + */`); }); describe("parsesCorrectly", () => {