git-for-windows/git
1
0
Fork 0
mirror of https://github.com/git-for-windows/git.git synced 2026-06-15 18:49:48 -05:00
Code Issues Packages Projects Releases 335 Wiki Activity

SubmittingPatches: note that trailer order matters

Browse Source 
It matters where you put the s-o-b; it should be last. You are signing
off on the patch as well as the whole message up to that point.

This also makes it clear who added what:

    Acked-by: The Reviewer <r@example.org>
    Signed-off-by: The Contributor <c@example.org>
    Acked-by: The (Late) Reviewer <late@example.org>
    Signed-off-by: The Maintainer <m@example.org>

The the first ack was added by the contributor and the second one was
added by the maintainer.

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Kristoffer Haugsbakk
2026-06-11 00:22:49 +02:00
committed by Junio C Hamano
parent 6fb8c8e01d
commit 231608ec21
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/SubmittingPatches
View File

@@ -490,6 +490,11 @@ particular are not used in this project.
Only capitalize the very first letter of the trailer, i.e. favor
`Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`.
Note that these trailers should come before your `Signed-off-by:`
trailer. You are signing off to the patch as well as the message. This
also makes it clear who added trailers when multiple people have signed
off on a patch.
[[ai]]
=== Use of Artificial Intelligence (AI)