From 231608ec21965569fc75780d42d2dea74b710d9a Mon Sep 17 00:00:00 2001 From: Kristoffer Haugsbakk Date: Thu, 11 Jun 2026 00:22:49 +0200 Subject: [PATCH] SubmittingPatches: note that trailer order matters It matters where you put the s-o-b; it should be last. You are signing off on the patch as well as the whole message up to that point. This also makes it clear who added what: Acked-by: The Reviewer Signed-off-by: The Contributor Acked-by: The (Late) Reviewer Signed-off-by: The Maintainer The the first ack was added by the contributor and the second one was added by the maintainer. Signed-off-by: Kristoffer Haugsbakk Signed-off-by: Junio C Hamano --- Documentation/SubmittingPatches | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 3d2e9ecfbb..2045708bdf 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -490,6 +490,11 @@ particular are not used in this project. Only capitalize the very first letter of the trailer, i.e. favor `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`. +Note that these trailers should come before your `Signed-off-by:` +trailer. You are signing off to the patch as well as the message. This +also makes it clear who added trailers when multiple people have signed +off on a patch. + [[ai]] === Use of Artificial Intelligence (AI)