sysadminsmedia/homebox
1
0
Fork 0
mirror of https://github.com/sysadminsmedia/homebox.git synced 2025-12-11 05:44:25 -06:00
Code Issues Packages Projects Releases 21 Wiki Activity

Remove shamefully hoist (#660)

Browse Source 
* feat: remove shamefully hoist

* chore: remove .npmrc
This commit is contained in:
Tonya 2025-05-04 17:11:00 +00:00 committed by GitHub
parent b89364d8c5
commit 16bcffac45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/binaries-publish.yaml vendored
View File

@ -32,7 +32,7 @@ jobs:
- name: Build Frontend and Copy to Backend - name: Build Frontend and Copy to Backend
working-directory: frontend working-directory: frontend
run: | run: |
pnpm install --shamefully-hoist pnpm install
pnpm run build pnpm run build
cp -r ./.output/public ../backend/app/api/static/ cp -r ./.output/public ../backend/app/api/static/

2
.github/workflows/partial-frontend.yaml vendored
View File

@ -18,7 +18,7 @@ jobs:
version: 9.12.2 version: 9.12.2
- name: Install dependencies - name: Install dependencies
run: pnpm install --shamefully-hoist run: pnpm install
working-directory: frontend working-directory: frontend
- name: Run Lint - name: Run Lint

2
CONTRIBUTING.md
View File

@ -33,8 +33,6 @@ If you're using `taskfile` you can run `task --list-all` for a list of all comma
If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file. If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file.
Note that when installing dependencies with pnpm you must use the `--shamefully-hoist` flag. If you don't use this flag, you will get an error when running the frontend server.
### API Development Notes ### API Development Notes
start command `task go:run` start command `task go:run`

2
Dockerfile
View File

@ -7,7 +7,7 @@ RUN npm install -g pnpm
# Copy package.json and lockfile to leverage caching # Copy package.json and lockfile to leverage caching
COPY frontend/package.json frontend/pnpm-lock.yaml ./ COPY frontend/package.json frontend/pnpm-lock.yaml ./
RUN pnpm install --frozen-lockfile --shamefully-hoist RUN pnpm install --frozen-lockfile
# Build Nuxt (frontend) stage # Build Nuxt (frontend) stage
FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder

2
Dockerfile.rootless
View File

@ -7,7 +7,7 @@ RUN npm install -g pnpm
# Copy package.json and lockfile to leverage caching # Copy package.json and lockfile to leverage caching
COPY frontend/package.json frontend/pnpm-lock.yaml ./ COPY frontend/package.json frontend/pnpm-lock.yaml ./
RUN pnpm install --frozen-lockfile --shamefully-hoist RUN pnpm install --frozen-lockfile
# Build Nuxt (frontend) stage # Build Nuxt (frontend) stage
FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder

2
Taskfile.yml
View File

@ -13,7 +13,7 @@ tasks:
- go install github.com/swaggo/swag/cmd/swag@latest - go install github.com/swaggo/swag/cmd/swag@latest
- go install github.com/pressly/goose/v3/cmd/goose@v3.8.0 - go install github.com/pressly/goose/v3/cmd/goose@v3.8.0
- cd backend && go mod tidy - cd backend && go mod tidy
- cd frontend && pnpm install --shamefully-hoist - cd frontend && pnpm install
swag: swag:
desc: Generate swagger docs desc: Generate swagger docs

2
docs/en/contribute/get-started.md
View File

@ -19,8 +19,6 @@ If you're using `taskfile` you can run `task --list-all` for a list of all comma
If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file. If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file.
Note that when installing dependencies with pnpm, you must use the `--shamefully-hoist` flag. If you don't use this flag, you will get an error when running the frontend server.
### API Development Notes ### API Development Notes
start command `task go:run` start command `task go:run`

1
frontend/.npmrc
View File

@ -1 +0,0 @@
shamefully-hoist=true