diff --git a/.github/workflows/binaries-publish.yaml b/.github/workflows/binaries-publish.yaml index 5184cc05..b76298e1 100644 --- a/.github/workflows/binaries-publish.yaml +++ b/.github/workflows/binaries-publish.yaml @@ -32,7 +32,7 @@ jobs: - name: Build Frontend and Copy to Backend working-directory: frontend run: | - pnpm install --shamefully-hoist + pnpm install pnpm run build cp -r ./.output/public ../backend/app/api/static/ diff --git a/.github/workflows/partial-frontend.yaml b/.github/workflows/partial-frontend.yaml index 422faee1..baca779a 100644 --- a/.github/workflows/partial-frontend.yaml +++ b/.github/workflows/partial-frontend.yaml @@ -18,7 +18,7 @@ jobs: version: 9.12.2 - name: Install dependencies - run: pnpm install --shamefully-hoist + run: pnpm install working-directory: frontend - name: Run Lint diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6a0a3f68..2a4a2552 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,8 +33,6 @@ If you're using `taskfile` you can run `task --list-all` for a list of all comma If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file. -Note that when installing dependencies with pnpm you must use the `--shamefully-hoist` flag. If you don't use this flag, you will get an error when running the frontend server. - ### API Development Notes start command `task go:run` diff --git a/Dockerfile b/Dockerfile index d8247d32..cec76307 100644 --- a/Dockerfile +++ b/Dockerfile @@ -7,7 +7,7 @@ RUN npm install -g pnpm # Copy package.json and lockfile to leverage caching COPY frontend/package.json frontend/pnpm-lock.yaml ./ -RUN pnpm install --frozen-lockfile --shamefully-hoist +RUN pnpm install --frozen-lockfile # Build Nuxt (frontend) stage FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder diff --git a/Dockerfile.rootless b/Dockerfile.rootless index 82f46364..684e2cfd 100644 --- a/Dockerfile.rootless +++ b/Dockerfile.rootless @@ -7,7 +7,7 @@ RUN npm install -g pnpm # Copy package.json and lockfile to leverage caching COPY frontend/package.json frontend/pnpm-lock.yaml ./ -RUN pnpm install --frozen-lockfile --shamefully-hoist +RUN pnpm install --frozen-lockfile # Build Nuxt (frontend) stage FROM public.ecr.aws/docker/library/node:lts-alpine AS frontend-builder diff --git a/Taskfile.yml b/Taskfile.yml index c3a043c2..13ec614c 100644 --- a/Taskfile.yml +++ b/Taskfile.yml @@ -13,7 +13,7 @@ tasks: - go install github.com/swaggo/swag/cmd/swag@latest - go install github.com/pressly/goose/v3/cmd/goose@v3.8.0 - cd backend && go mod tidy - - cd frontend && pnpm install --shamefully-hoist + - cd frontend && pnpm install swag: desc: Generate swagger docs diff --git a/docs/en/contribute/get-started.md b/docs/en/contribute/get-started.md index 2e309ca3..6fe63526 100644 --- a/docs/en/contribute/get-started.md +++ b/docs/en/contribute/get-started.md @@ -19,8 +19,6 @@ If you're using `taskfile` you can run `task --list-all` for a list of all comma If you're using the taskfile, you can use the `task setup` command to run the required setup commands. Otherwise, you can review the commands required in the `Taskfile.yml` file. -Note that when installing dependencies with pnpm, you must use the `--shamefully-hoist` flag. If you don't use this flag, you will get an error when running the frontend server. - ### API Development Notes start command `task go:run` diff --git a/frontend/.npmrc b/frontend/.npmrc deleted file mode 100644 index bf2e7648..00000000 --- a/frontend/.npmrc +++ /dev/null @@ -1 +0,0 @@ -shamefully-hoist=true