Compare commits

..

7 Commits

Author SHA1 Message Date
dependabot[bot]
0980c35f59 build(deps): bump github/codeql-action from 4.31.2 to 4.32.4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.2 to 4.32.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](0499de31b9...89a39a4e59)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.32.4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-03-01 11:26:32 +00:00
Anthony
3b968bbae1 Add volume mapping for /run/wings 2026-01-14 13:22:28 -06:00
Anthony
c1cc803d46 changelog 2026-01-13 14:19:18 -06:00
Anthony
fbfe5b9b54 Merge pull request #292 from pterodactyl/server-machine-id-mount
feat: add mount for /etc/machine-id for servers
2026-01-13 13:11:55 -06:00
Matthew Penner
13029244e3 feat: add mount for /etc/machine-id for servers
Signed-off-by: Matthew Penner <me@matthewp.io>
2026-01-13 11:49:43 -07:00
Matthew Penner
70f02a2585 nix: update flake.lock
Flake lock file updates:

• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/f4330d2' (2025-03-07)
  → 'github:hercules-ci/flake-parts/80daad0' (2026-01-11)
• Updated input 'flake-parts/nixpkgs-lib':
    'github:nix-community/nixpkgs.lib/147dee3' (2025-03-02)
  → 'github:nix-community/nixpkgs.lib/2075416' (2025-12-14)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/36fd87b' (2025-03-07)
  → 'github:NixOS/nixpkgs/ffbc9f8' (2026-01-11)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/3d0579f' (2025-02-17)
  → 'github:numtide/treefmt-nix/e96d59d' (2026-01-11)
2026-01-13 11:07:16 -07:00
Anthony
d3a416f0be Merge pull request #293 from pterodactyl/matthewpi/update-ci
chore: update ci pipelines and Go version to 1.24.11
2026-01-13 12:06:46 -06:00
8 changed files with 88 additions and 24 deletions

View File

@@ -29,10 +29,10 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- name: Initialize CodeQL
uses: github/codeql-action/init@0499de31b99561a6d14a36a5f662c2a54f91beee # v3.29.5
uses: github/codeql-action/init@89a39a4e59826350b863aa6b6252a07ad50cf83e # v3.29.5
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@0499de31b99561a6d14a36a5f662c2a54f91beee # v3.29.5
uses: github/codeql-action/analyze@89a39a4e59826350b863aa6b6252a07ad50cf83e # v3.29.5

View File

@@ -1,5 +1,9 @@
# Changelog
## v1.12.1
### Added
* Add mount for /etc/machine-id for servers for Hytale ([#292](https://github.com/pterodactyl/wings/pull/292))
## v1.12.0
### Fixed
* [CVE-2025-68954](https://github.com/pterodactyl/panel/security/advisories/GHSA-8c39-xppg-479c)

View File

@@ -197,9 +197,9 @@ func rootCmdRun(cmd *cobra.Command, _ []string) {
for _, serv := range manager.All() {
s := serv
// For each server we encounter make sure the root data directory exists.
if err := s.EnsureDataDirectoryExists(); err != nil {
s.Log().Error("could not create root data directory for server: not loading server...")
// For each server ensure the minimal environment is configured for the server.
if err := s.CreateEnvironment(); err != nil {
s.Log().Error("could create base environment for server...")
continue
}

View File

@@ -177,11 +177,11 @@ type SystemConfiguration struct {
Passwd struct {
// Enable controls whether generated passwd files should be mounted into containers.
//
// By default this option is disabled and Wings will not mount any additional passwd
// files into containers.
// By default this option is disabled and Wings will not mount any
// additional passwd files into containers.
Enable bool `yaml:"enabled" default:"false"`
// Directory is the directory on disk where the generated files will be stored.
// Directory is the directory on disk where the generated passwd files will be stored.
// This directory may be temporary as it will be re-created whenever Wings is started.
//
// This path **WILL** be both written to by Wings and mounted into containers created by
@@ -192,6 +192,26 @@ type SystemConfiguration struct {
Directory string `yaml:"directory" default:"/run/wings/etc"`
} `yaml:"passwd"`
// MachineID controls the mounting of a generated `/etc/machine-id` file into containers started by Wings.
MachineID struct {
// Enable controls whether a generated machine-id file should be mounted
// into containers.
//
// By default this option is enabled and Wings will mount an additional
// machine-id file into containers.
Enable bool `yaml:"enabled" default:"true"`
// Directory is the directory on disk where the generated machine-id files will be stored.
// This directory may be temporary as it will be re-created whenever Wings is started.
//
// This path **WILL** be both written to by Wings and mounted into containers created by
// Wings. If you are running Wings itself in a container, this path will need to be mounted
// into the Wings container as the exact path on the host, which should match the value
// specified here. If you are using SELinux, you will need to make sure this file has the
// correct SELinux context in order for containers to use it.
Directory string `yaml:"directory" default:"/run/wings/machine-id"`
} `yaml:"machine_id"`
// The amount of time in seconds that can elapse before a server's disk space calculation is
// considered stale and a re-check should occur. DANGER: setting this value too low can seriously
// impact system performance and cause massive I/O bottlenecks and high CPU usage for the Wings
@@ -634,6 +654,11 @@ func ConfigureDirectories() error {
return err
}
log.WithField("path", _config.System.TmpDirectory).Debug("ensuring temporary data directory exists")
if err := os.MkdirAll(_config.System.TmpDirectory, 0o700); err != nil {
return err
}
log.WithField("path", _config.System.ArchiveDirectory).Debug("ensuring archive data directory exists")
if err := os.MkdirAll(_config.System.ArchiveDirectory, 0o700); err != nil {
return err
@@ -651,6 +676,13 @@ func ConfigureDirectories() error {
}
}
if _config.System.MachineID.Enable {
log.WithField("path", _config.System.MachineID.Directory).Debug("ensuring machine-id directory exists")
if err := os.MkdirAll(_config.System.MachineID.Directory, 0o755); err != nil {
return err
}
}
return nil
}

View File

@@ -23,6 +23,7 @@ services:
- "/var/log/pterodactyl/:/var/log/pterodactyl/"
- "/tmp/pterodactyl/:/tmp/pterodactyl/"
- "/etc/ssl/certs:/etc/ssl/certs:ro"
- "/run/wings:/run/wings"
# you may need /srv/daemon-data if you are upgrading from an old daemon
#- "/srv/daemon-data/:/srv/daemon-data/"
# Required for ssl if you use let's encrypt. uncomment to use.

24
flake.lock generated
View File

@@ -5,11 +5,11 @@
"nixpkgs-lib": "nixpkgs-lib"
},
"locked": {
"lastModified": 1741352980,
"narHash": "sha256-+u2UunDA4Cl5Fci3m7S643HzKmIDAe+fiXrLqYsR2fs=",
"lastModified": 1768135262,
"narHash": "sha256-PVvu7OqHBGWN16zSi6tEmPwwHQ4rLPU9Plvs8/1TUBY=",
"owner": "hercules-ci",
"repo": "flake-parts",
"rev": "f4330d22f1c5d2ba72d3d22df5597d123fdb60a9",
"rev": "80daad04eddbbf5a4d883996a73f3f542fa437ac",
"type": "github"
},
"original": {
@@ -20,11 +20,11 @@
},
"nixpkgs": {
"locked": {
"lastModified": 1741379970,
"narHash": "sha256-Wh7esNh7G24qYleLvgOSY/7HlDUzWaL/n4qzlBePpiw=",
"lastModified": 1768127708,
"narHash": "sha256-1Sm77VfZh3mU0F5OqKABNLWxOuDeHIlcFjsXeeiPazs=",
"owner": "NixOS",
"repo": "nixpkgs",
"rev": "36fd87baa9083f34f7f5027900b62ee6d09b1f2f",
"rev": "ffbc9f8cbaacfb331b6017d5a5abb21a492c9a38",
"type": "github"
},
"original": {
@@ -36,11 +36,11 @@
},
"nixpkgs-lib": {
"locked": {
"lastModified": 1740877520,
"narHash": "sha256-oiwv/ZK/2FhGxrCkQkB83i7GnWXPPLzoqFHpDD3uYpk=",
"lastModified": 1765674936,
"narHash": "sha256-k00uTP4JNfmejrCLJOwdObYC9jHRrr/5M/a/8L2EIdo=",
"owner": "nix-community",
"repo": "nixpkgs.lib",
"rev": "147dee35aab2193b174e4c0868bd80ead5ce755c",
"rev": "2075416fcb47225d9b68ac469a5c4801a9c4dd85",
"type": "github"
},
"original": {
@@ -63,11 +63,11 @@
]
},
"locked": {
"lastModified": 1739829690,
"narHash": "sha256-mL1szCeIsjh6Khn3nH2cYtwO5YXG6gBiTw1A30iGeDU=",
"lastModified": 1768158989,
"narHash": "sha256-67vyT1+xClLldnumAzCTBvU0jLZ1YBcf4vANRWP3+Ak=",
"owner": "numtide",
"repo": "treefmt-nix",
"rev": "3d0579f5cc93436052d94b73925b48973a104204",
"rev": "e96d59dff5c0d7fddb9d113ba108f03c3ef99eca",
"type": "github"
},
"original": {

View File

@@ -29,21 +29,34 @@ func (s *Server) Mounts() []environment.Mount {
},
}
cfg := config.Get()
// Handle mounting a generated `/etc/passwd` if the feature is enabled.
if passwd := config.Get().System.Passwd; passwd.Enable {
s.Log().WithFields(log.Fields{"source_path": passwd.Directory}).Info("mouting generated /etc/{group,passwd} to workaround UID/GID issues")
if cfg.System.Passwd.Enable {
s.Log().WithFields(log.Fields{"source_path": cfg.System.Passwd.Directory}).Info("mouting generated /etc/{group,passwd} to workaround UID/GID issues")
m = append(m, environment.Mount{
Source: filepath.Join(passwd.Directory, "group"),
Source: filepath.Join(cfg.System.Passwd.Directory, "group"),
Target: "/etc/group",
ReadOnly: true,
})
m = append(m, environment.Mount{
Source: filepath.Join(passwd.Directory, "passwd"),
Source: filepath.Join(cfg.System.Passwd.Directory, "passwd"),
Target: "/etc/passwd",
ReadOnly: true,
})
}
if cfg.System.MachineID.Enable {
// Hytale wants a machine-id in order to encrypt tokens for the server.
// So add a mount to `/etc/machine-id` to a source that contains the
// server's UUID without any dashes.
m = append(m, environment.Mount{
Source: filepath.Join(cfg.System.MachineID.Directory, s.ID()),
Target: "/etc/machine-id",
ReadOnly: true,
})
}
// Also include any of this server's custom mounts when returning them.
return append(m, s.customMounts()...)
}

View File

@@ -1,11 +1,13 @@
package server
import (
"bytes"
"context"
"encoding/json"
"fmt"
"net/http"
"os"
"path/filepath"
"strings"
"sync"
@@ -259,6 +261,18 @@ func (s *Server) CreateEnvironment() error {
return err
}
cfg := config.Get()
if cfg.System.MachineID.Enable {
// Hytale wants a machine-id in order to encrypt tokens for the server. So
// write a machine-id file for the server that contains the server's UUID
// without any dashes.
p := filepath.Join(cfg.System.MachineID.Directory, s.ID())
machineID := append(bytes.ReplaceAll([]byte(s.ID()), []byte{'-'}, []byte{}), '\n')
if err := os.WriteFile(p, machineID, 0o644); err != nil {
return fmt.Errorf("failed to write machine-id (at '%s') for server '%s': %w", p, s.ID(), err)
}
}
return s.Environment.Create()
}