Commit Graph

67428 Commits

Author SHA1 Message Date
Milo Moisson
fc8b56a966 Update logging
Remove enter after console.log/warn/error.
Really ennoying...
2020-06-20 18:26:14 +02:00
Benjamin Pasero
9c142ea383 🆙 distro 2020-06-20 10:55:06 +02:00
Fedor Nezhivoi
24e0a82229 Move encoding to common for #79275 (#100539)
* move encoding.ts to common for #79275

* load iconv-lite-umd and jschardet in web version for #79275

* move EncodingOracle to the AbstractTextFileService for #79275

* review

* update to new iconv-lite-umd

* add workaround for jschardet types

* fix indentation

* add iconv-lite-umd and jschardet to workbench.html

* fix paths for modules

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-06-20 10:47:29 +02:00
Benjamin Pasero
aa06a3d3b9 editors - add label property to file inputs 2020-06-20 09:55:02 +02:00
Benjamin Pasero
59aad0d061 Changing character casing in file name doesn't take effect in editor (fix #100436) 2020-06-20 09:51:37 +02:00
Benjamin Pasero
f17030d3eb editors - adopt more extUri 2020-06-20 09:46:33 +02:00
Benjamin Pasero
49fc0feffb "You cannot save this document with extension..." Is this new? (fix #100241) 2020-06-20 09:43:43 +02:00
Matt Bierner
97650fb8f3 Let core command such as undo/redo be overridden by webviews and notebooks (#98288)
* Add CoreCommandService

For #90110

This change introduce a new service (`ICoreCommandService`) that lets high levels parts of the editor (such as webviews) hook into core commands such as undo and redo that are fired from the editor menus.

## Why is this needed?
To implement undo/redo in custom editors / webviews, we currently register special commands (`editor.action.customEditor.undo` and `editor.action.customEditor.redo`). This is not ideal since it means that users have to update multiple commands if they wish to rebind undo/redo

These custom command also are not invoked when the user goes to the `edit` menu and select `undo` or `redo`. Instead, the edit menu always calls the core `UndoCommand`

We cannot make `UndoCommand` know about custom editors because it lives in `base`

## What this change does?
This change adds a new `ICoreCommandService` that lets higher level parts of the editor override core commands such as undo and redo. We use a similar approach in the `IOpenerService`.

Right now only `undo` and `redo` are overridable. If this approach looks ok, we could also extend it to `copy`, `paste`, `cut`, and `select all`

* Add docs and clean up types

* Rework implementation

Switch from using a command service to having each command state if is overrideable or not.

This hooks up overrides for:

- Undo/redo
- cut/copy/paste

for webviews, custom editors, and notebooks

* Add ProxyCommand so that multiple registered commands can share a single implementation

* Fix compilation & missing file being referenced

* Introduce and adopt MultiCommand for Undo

* Adopt MultiCommand for Redo and SelectAll

* Adopt MultiCommand for Cut, Copy and Paste

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2020-06-19 16:54:22 -07:00
Sandeep Somavarapu
2c73c38a11 dispose always 2020-06-20 01:31:17 +02:00
Sandeep Somavarapu
200df81691 Fix #100314 2020-06-20 01:25:55 +02:00
Sandeep Somavarapu
2f6ef86931 Fix #100411 2020-06-20 01:25:55 +02:00
Martin Aeschlimann
c93c29c357 code.sh: loosen check for WSL2 2020-06-19 23:42:58 +02:00
Eric Amodio
98b5bec6bc Fixes issue w/ the firstOpen setting on the web
Adds a safety-net check for Codespaces until the fix can be verified
2020-06-19 16:12:22 -04:00
Martin Aeschlimann
c23285f8c8 [json] server path fix (for json-server npm) 2020-06-19 21:58:54 +02:00
Martin Aeschlimann
3acea34ca5 [css] custom data polishes 2020-06-19 21:58:54 +02:00
Martin Aeschlimann
e32da59d30 [npm] support serverless & cleanup 2020-06-19 21:58:54 +02:00
deepak1556
d2f06fbcec chore: bump electron@8.3.3 2020-06-19 11:12:28 -07:00
Jackson Kearl
9206176f45 close #100588 2020-06-19 10:31:48 -07:00
Jackson Kearl
d6620fa042 Add extCpp as alias for extC++ command. 2020-06-19 09:47:21 -07:00
Benjamin Pasero
102f0d06c7 Quick open: configuring a prefix selects it all (fix #100584) 2020-06-19 17:21:22 +02:00
Sandeep Somavarapu
ba27193e45 Web extensions support
- Add package nls url to scanned extension
- Introduce scanner service for builtin extensions
- Introduce scanner service for web extensions
- Use web extensions scanner service in management and runtime
- Apply default translation inside management service
2020-06-19 15:14:01 +02:00
Daniel Imms
8a7c490b26 Add IHoverService.hideOnHover 2020-06-19 06:12:00 -07:00
Benjamin Pasero
b385fa7ceb editors - improve language 2020-06-19 14:53:55 +02:00
Benjamin Pasero
6de6876177 improve language in a few places 2020-06-19 14:53:55 +02:00
Daniel Imms
c69da43f9f Improve language in terminal 2020-06-19 05:22:36 -07:00
Daniel Imms
10a7e8cc48 Fix hover anchor position when below 2020-06-19 05:19:58 -07:00
Benjamin Pasero
801ab0e2da editors - move open with to editor (fix #100057) (#100466) 2020-06-19 14:05:48 +02:00
Benjamin Pasero
60d2192e32 editors - have a editor drop service (fix #99739) (#100464) 2020-06-19 14:05:35 +02:00
Benjamin Pasero
fc4b55ee87 Clipboard: sync access is deprecated (fix #98556) (#100467) 2020-06-19 14:03:51 +02:00
Sandeep Somavarapu
b015e717a4 upgrade semver 2020-06-19 09:48:40 +02:00
Jackson Kearl
8cd3fe080b Allow assigning "new release" issues 2020-06-18 15:07:19 -07:00
Jackson Kearl
09083d4be6 Allow assigning "needs more info" issues. 2020-06-18 15:06:31 -07:00
Matt Bierner
35c3393828 Restore old remote uri normalization for remote uris
For #100442

When we moved the webview resource protocol to the main process, I updated the uri normalization logic so that it could load remote resources properly. This however broke VSO since their resources are still loaded from the renderer process.

This change restores the old normalization for the renderer side resource loader.
2020-06-18 13:59:22 -07:00
Matt Bierner
d34c4fccdb Remove duplicate implementation of loading resources
For #100442

Also make sure we use the correct scheme for the making requests
2020-06-18 12:23:24 -07:00
Sandeep Somavarapu
80d8aff458 fix layering issues 2020-06-18 20:36:40 +02:00
Jackson Kearl
2cda7ae17a Update name 2020-06-18 11:34:41 -07:00
Matt Bierner
a20f2e6ba5 Fix csp rewriting for iframe based webviews
For #100442

The csp field is a string, not the csp element itself

Also adds proper typings for it
2020-06-18 10:53:00 -07:00
Sandeep Somavarapu
d04df068bd Show web builtin extensions in server less 2020-06-18 19:44:29 +02:00
rebornix
9b38a98bc4 skip undo/redo test. 2020-06-18 10:38:30 -07:00
Andre Weinand
ab8267f7f4 revert fix for #95423; fixes #100508 2020-06-18 18:41:00 +02:00
rebornix
6230673810 re #100461. 2020-06-18 09:38:03 -07:00
Keshav Bohra
546a4488b4 Word fixes (#100301)
* fixed #99980

* reverting the change #99980, already fixed

* Fixed some commented words
2020-06-18 18:23:20 +02:00
Johannes Rieken
412e3fb8ec open overwrite should re-use existing editor even when the editor is optional, https://github.com/microsoft/vscode/issues/99496 2020-06-18 18:10:37 +02:00
Sandeep Somavarapu
eabfdafba2 fix tests 2020-06-18 17:57:18 +02:00
Alex Ross
ca74bac4b0 Update grammars 2020-06-18 17:35:13 +02:00
isidor
994e64fac1 explorer: properly set aria attributes on compact folders
fixes #86414
2020-06-18 16:56:36 +02:00
isidor
01630824e8 use label service for breakpoint path in breakpoints view
#100475
2020-06-18 16:21:29 +02:00
Benjamin Pasero
694abe219e 💄 stdin polish 2020-06-18 16:09:18 +02:00
Fedor Nezhivoi
314b58c8e1 switch to use iconv-lite-umd for #79275 (#100472)
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-06-18 16:08:17 +02:00
Sandeep Somavarapu
59bbd934ed introduce web extension management server 2020-06-18 16:02:35 +02:00