Commit Graph

156410 Commits

Author SHA1 Message Date
Henning Dieterichs
b4399bee94 Fixes 2026-05-04 19:15:19 +02:00
Henning Dieterichs
3a271147c5 Fixes screenshot diff report 2026-05-04 19:15:19 +02:00
Henning Dieterichs
bb81c9c9bb Improves screenshot experience for forks 2026-05-04 19:15:19 +02:00
Paul
1bb9a48221 Disable flaky hover test (#314129) 2026-05-04 16:57:37 +00:00
Paul
4e0822feb0 Model picker styling updates (#314150) 2026-05-04 09:54:12 -07:00
Kyle Cutler
64bb6714fb Browser: create Playwright per agent session (#313779)
* Browser: create Playwright per agent session

* feedback
2026-05-04 09:36:25 -07:00
Megan Rogge
b320e7ebbe Skip redundant steering message when kill_terminal disposes terminal (#314130) 2026-05-04 16:32:38 +00:00
Henning Dieterichs
656fbbce25 Uses full dark modern theme for component fixtures & implements improved time travel scheduler 2026-05-04 17:50:54 +02:00
ruryu
a832f4adb9 fix(agentHost): await dbClose to resolve flaky session database tests (#313810)
* fix(agentHost): properly await dbClose to fix flaky tests

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-05-04 15:40:42 +00:00
Benjamin Christopher Simmonds
92d1d8d1f4 Merge pull request #314111 from microsoft/benibenj/magnificent-lynx
Only unmaximize auxiliary side bar on explicit user action
2026-05-04 17:32:20 +02:00
Benjamin Christopher Simmonds
80a208ed14 Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-05-04 16:49:03 +02:00
Benjamin Christopher Simmonds
386a2b9104 Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-05-04 16:48:51 +02:00
BeniBenj
1213eeb599 Only unmaximize auxiliary side bar when editor visibility changes due to an explicit user action 2026-05-04 16:40:27 +02:00
Ladislau Szomoru
ebfbb71de2 Agents - scaffold Changesets model (#313577)
* Agents - scaffold Changesets model

* Pull request feedback
2026-05-04 15:26:58 +02:00
Henning Dieterichs
a0afc4cbe9 fixes component explorer lock file 2026-05-04 14:57:33 +02:00
Christof Marti
32fa0ef21b Fix icon to text alignment (#314043) 2026-05-04 14:00:59 +02:00
Sandeep Somavarapu
b12cd99ce6 Fix Agents welcome theme import cleanup (#314070)
Ensure committing the parent VS Code theme preview prevents later walkthrough teardown from uninstalling the imported theme extension.

Fixes #314052

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 14:00:04 +02:00
Benjamin Christopher Simmonds
13a0ebbddc Merge pull request #314068 from microsoft/benibenj/strong-walrus
Fix TreeError in AgentSessionsControl focus method
2026-05-04 13:59:22 +02:00
Benjamin Christopher Simmonds
b759e192c5 Merge pull request #314067 from microsoft/benibenj/unemployed-shark
Fix TreeError in AgentSessionsView
2026-05-04 13:58:55 +02:00
Henning Dieterichs
08452f3d3a updates component explorer 2026-05-04 13:58:23 +02:00
Sandeep Somavarapu
78a468f131 Agents welcome: introduce isEmbeddedApp and parentAppName environment properties (#314061)
agents: introduce isEmbeddedApp and parentAppName environment properties

- Add isEmbeddedApp property to IEnvironmentService (optional, defaults false)
- Add memoized parentAppNameShort and parentAppNameLong to IEnvironmentService
- Compute parent app display names from isEmbeddedApp flag and product quality
- Set isEmbeddedApp in NativeEnvironmentService from process.isEmbeddedApp
- Thread isEmbeddedApp through INativeWindowConfiguration to renderer
- Use environmentService.parentAppNameShort in welcome theme step button label

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 10:24:29 +00:00
BeniBenj
150dcd72ba fixes https://github.com/microsoft/vscode/issues/313042 2026-05-04 12:19:15 +02:00
BeniBenj
723b71faf3 fixes https://github.com/microsoft/vscode/issues/309891 2026-05-04 12:13:00 +02:00
David Wengier
1ad29ef635 Update repository and path for Razor repo (#313011)
* Update repository and path for Razor

* Update in more places

---------

Co-authored-by: Dmitriy Vasyura <dmitriv@microsoft.com>
Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
2026-05-04 09:28:21 +00:00
Aashna Garg
0e571a81e1 Merge pull request #313583 from microsoft/aashnagarg/send-copilot-plan-to-router
Send copilot_plan to auto-intent-service for per-SKU routing
2026-05-04 02:27:50 -07:00
Don Jayamanne
ca5a6a94ac Remove unnecessary logging statements from Copilot CLI session and related handlers (#314021)
* Remove unnecessary logging statements from Copilot CLI session and related handlers

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Remove unused ILogService import from askUserQuestionHandler.ts

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/c7defd7a-5411-4180-beda-322380000284

Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
2026-05-04 11:15:08 +02:00
Rob Lourens
44ffe22e11 Use DI-aware PromptRenderer in sendInvokedToolTelemetry (#314023)
* Fix #312813: Use DI-aware PromptRenderer in sendInvokedToolTelemetry

Use PromptRenderer.create() instead of raw BasePromptRenderer so that
@IPromptEndpoint is properly injected when rendering images.

Regression: sendInvokedToolTelemetry was the only code path constructing
PrimitiveToolResult via raw BasePromptRenderer, causing this.endpoint to be
undefined when onImage() reads this.endpoint.supportsVision.

Changes:
- Updated sendInvokedToolTelemetry to take (instantiationService, endpoint, ...)
- Updated both callers to pass instantiationService and endpoint
- Added unit test for image content rendering without crash

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review feedback: preserve Infinity token budget and fix test

- Override endpoint.modelMaxPromptTokens to Infinity in sendInvokedToolTelemetry
  to match prior behavior and avoid truncation of tool results when counting tokens
- Fix unit test: sendInvokedToolTelemetry is fire-and-forget (returns undefined),
  so test should verify it doesn't throw rather than expecting a resolved promise

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix test failure: disable image uploads in sendInvokedToolTelemetry test

The test was triggering image upload auth requirements in onImage().
Disable EnableChatImageUpload in test config to avoid auth errors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 05:19:14 +00:00
Vritant Bhardwaj
db9c113029 Merge pull request #313911 from microsoft/dev/vritant24/bg-todo-watcher 2026-05-03 21:43:10 -07:00
Rob Lourens
fd6d37812b agentHost: use URI helpers for subagent sessions (#313924)
* agents: show per-turn model in agent-host session history

Surface the model used for each response in agent-host chat sessions, like
extension-host Copilot CLI sessions do.

AHP already reports the model on each turn via Turn.usage?.model. The
workbench-side adapter (turnsToHistory) was ignoring this and stamping a
single session-level modelId on every request, with no per-response model
detail.

Refactor turnsToHistory to take a TurnModelLookup (id + display name
resolution) instead of a single modelId. AgentHostSessionHandler builds
the lookup using ILanguageModelsService and the session-type prefix, with
fallback to the session-level summary model when a turn has no usage.

Response history items now carry the display name in 'details', which
flows through to the per-response footer in the chat UI.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add integrated history-loading test for per-turn model display

Covers the active-turn restoration path through provideChatSessionContent
with a mix of completed turns (with/without usage.model) and an in-flight
activeTurn falling back to the session-level model.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* agentHost: use URI helpers for subagent sessions

Refactor subagent URI handling to preserve URI objects through parsing and eviction checks instead of repeatedly stringifying and reparsing session resources. Keep state-manager lookups at string boundaries while using URI ancestry checks for subagent subscriber eviction.\n\nAdd regression coverage for path-shape preservation and nested subagent subscribers pinning ancestor sessions.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* agentHost: fix live sync-subagent streaming routing

Subagent text, reasoning, and tool events were routing to the parent
session during live streaming because the session used single global
part IDs and relied on deprecated data.parentToolCallId.

- Track per-subagent markdown/reasoning part IDs in Maps keyed by
  parentToolCallId so parent and subagent text never share a part.
- Populate agentId -> toolCallId map from subagent.started events;
  use event-level agentId for routing instead of deprecated field.
- Drop events with an unmapped agentId with a warning log rather than
  silently routing them to the parent session.
- Add regression tests for markdown delta, reasoning delta, and tool
  completion routing in subagent sessions.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* agentHost: fix nested subagent routing for depth > 1

Both `onClientToolCallComplete` and `getSessionMessages` in copilotAgent.ts resolved the backing SDK session entry with a single `parseSubagentSessionUri` call, producing an intermediate subagent URI (e.g. `copilot:/root/subagent/tc1`) that is never a key in `_sessions`. This caused client-tool completions and message restores for depth-2+ subagents to be silently dropped.

Similarly, `_maybeEvictIdleSession` in agentService.ts targeted only the immediate parent when a nested subagent URI unsubscribed, leaving the root session's state cached in the state manager indefinitely (no one ever called eviction on it).

Fix both by walking the full subagent ancestry to the root before resolving the session entry or eviction target. Covered by new regression tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 14:28:14 +10:00
vritant24
dee0fb394f fix: ensure background todo processor completes before final review 2026-05-03 21:06:28 -07:00
vritant24
531228ac25 improve history
Co-authored-by: Copilot <copilot@github.com>
2026-05-03 20:53:09 -07:00
Rob Lourens
85f836e234 sessions: skip slash command expansion in agent host sessions (#314015)
* sessions: skip slash command expansion in agent host sessions

Agent host sessions support prompt/skill slash commands natively, so
the CLI-friendly markdown reference ("Use the skill located at ...")
should not be appended. Wire a `shouldExpandPromptSlashCommand`
callback through `NewChatInputWidget` and have both the new-session
and new-chat-in-session panes opt out when the target provider matches
`ANY_AGENT_HOST_PROVIDER_RE`. Copilot CLI and other providers are
unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: base slash expansion on active session, not picker

_send() targets the current active session, which can lag behind the
workspace picker selection while trust approval or session-type
discovery is in flight. Read providerId from the active session so the
expansion decision matches the session that actually receives the
request.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 03:49:22 +00:00
Vritant Bhardwaj
bd8f54093c Merge branch 'main' into dev/vritant24/bg-todo-watcher 2026-05-03 20:47:39 -07:00
vritant24
1c709bb1d7 fix PR nits 2026-05-03 20:47:00 -07:00
Rob Lourens
43c1c17c1d chat: remove untitled session resource warning (#314016)
Remove the diagnostic warning for untitled-style chat session resources now that it is no longer needed. (Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 12:33:29 +09:00
vritant24
cf03722afa improve titles
Co-authored-by: Copilot <copilot@github.com>
2026-05-03 20:21:57 -07:00
vritant24
7695fc7126 run finalize on cancel as well
Co-authored-by: Copilot <copilot@github.com>
2026-05-03 20:20:10 -07:00
Vritant Bhardwaj
b0664a92e3 Merge branch 'main' into dev/vritant24/bg-todo-watcher 2026-05-03 20:14:46 -07:00
vs-code-engineering[bot]
a416899edf Update endgame notebook milestones to 1.120.0 (#314013)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-04 03:14:32 +00:00
Ulugbek Abdullaev
25a3c5d05d NES cursor jump: respect first model with tag CursorJump from /models (#313988)
* NES cursor jump: respect first model with tag CursorJump from /models

* extract cursor-jump model name selection into a method with hardcoded default

* comment cursor-jump model name selection priority
2026-05-04 03:07:00 +00:00
vritant24
7148492318 fix(copilot): harden background todo processing 2026-05-03 17:45:35 -07:00
vritant24
971661d2dd fix(copilot): simplify background todo prompt gating 2026-05-03 17:45:09 -07:00
vritant24
f576895142 move desc to package.nls.json 2026-05-03 17:20:40 -07:00
Christof Marti
530cb5de71 Terminal command risk assessment (#313991) 2026-05-03 14:51:49 -07:00
Justin Chen
8419cd4700 past tense for optimizing tool selection (#313989) 2026-05-03 23:50:02 +02:00
Copilot
bedd833d89 Add Space key to toggle breakpoint checkboxes in breakpoints view (#313972)
* Initial plan

* Add Space key toggle for breakpoint checkboxes in breakpoints view

Registers a ViewAction with a Space keybinding in the breakpoints view
that toggles the enabled/disabled state of the focused breakpoint item,
including exception breakpoints, function breakpoints, data breakpoints,
and instruction breakpoints.

Fixes #248755

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/017a281d-da6c-486e-9a18-238acff2ab20

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

* Handle Space key on tree onKeyDown instead of action registration

Instead of registering a ViewAction for the Space keybinding,
handle the keyboard event directly on the tree's onKeyDown event
to toggle the enable/disable state of the focused breakpoint.

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/28a72182-dfb3-4327-8349-d1cc38cbbf71

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

* Guard Space toggle against editable elements and modifier keys

Use event.equals(KeyCode.Space) instead of checking keyCode directly
so modified-Space combinations (Ctrl+Space, etc.) don't trigger toggle.
Add dom.isEditableElement guard so Space still inserts a space character
when editing breakpoint conditions/names in the inline InputBox.

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/ba70e0fd-63e2-40bf-8883-9ddddc9a9438

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
2026-05-03 12:53:16 -07:00
Justin Chen
cc64b1874e skip sandbox approvals for autopilot/bypass (#313940)
* skip sandbox approvals for autopilot/bypass

* fix testw
2026-05-03 19:43:04 +00:00
Justin Chen
341631bd0b make border progress default true (#313980) 2026-05-03 19:40:46 +00:00
Yogeshwaran C
bb8e710191 Add 'pane' search keyword to editor group settings (#313490) 2026-05-03 19:27:41 +00:00
Yogeshwaran C
f911e9c9df Add 'hint' and 'info' search keywords to editor.hover.enabled (#313491)
Add 'hint' and 'info' search keywords to hover settings
2026-05-03 18:16:37 +00:00