Commit Graph

128481 Commits

Author SHA1 Message Date
Ladislau Szomoru
9bb633aaf7 GitHub - add "Open on GitHub" action to the SCM graph (#237635) 2025-01-10 13:52:01 +01:00
Sandeep Somavarapu
eba8049c80 improve error handling from unpkg service (#237638) 2025-01-10 13:41:55 +01:00
Benjamin Christopher Simmonds
3073dc1fb4 padding between statusbar and inline edit (#237632)
fixes #11597
2025-01-10 12:00:33 +01:00
Johannes Rieken
7faf268c1b fix https://github.com/microsoft/vscode/issues/235322 (#237630) 2025-01-10 11:07:59 +01:00
Johannes Rieken
e1e2944acf fixes https://github.com/microsoft/vscode/issues/237171 (#237628) 2025-01-10 11:03:18 +01:00
Johannes Rieken
f80816ab8e fix leaking disposables (#237586)
* chore - mark disposables from registry#register functions as disposables so that they don't appear as leaking

* fix various leaking disposables
2025-01-10 08:41:08 +01:00
Benjamin Pasero
8e81ea645d watcher - defer realpath to only when needed (#237600) 2025-01-10 06:43:21 +01:00
Rob Lourens
91990b4e69 Fix occasional streaming pauses (#237615) 2025-01-10 06:37:35 +01:00
Megan Rogge
4dd6e8e17f add delete as default keybinding for removing file from working set, ctx key (#237513)
* fix #10338

* add ctx key for working set, use it for the when clause
2025-01-09 17:58:39 -06:00
Ladislau Szomoru
a26fe3e466 Git - do not show "Open on GitHub" action for commits that have not been pushed to the remote (#237605) 2025-01-09 15:20:57 -08:00
Benjamin Christopher Simmonds
ddf3841046 Inline edits UI enhancements (#237611)
inline edits UI changes
2025-01-09 15:19:31 -08:00
Anthony Kim
f74e6beed9 Expose shell's environment - pwsh (#237415)
* start terminal shell env proposed

* fix typo

* progress on shellEnvDetectionCapability, mainThreadTerminalSI

* update IShellEnvDetectionCapability interface

* touch up on $shellEnvChange

* adjust IShellEnvDetectionCapability

* properly listen to envChangeEvent
Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

* Serialize env map, expose on exthost

* start adding to zsh script

* receive environment variable in extension host, properly escape "
Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

* clean up

* Add TODO: properly escape double quotes, figure out why JSON parse fails for bash

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

* Fix nonce check, ignore PS1 for now in bash

* Add some simple PS1 string tests to deserializeMessage

* New approach of sending env entries separately

* be able to get EnvSingleVar

* few comments

* add function signature for start, set, end environment var

* implement EnvStart, EnvEntry, EnvEnd for single env entry

* deserialize env value for EnvEntry

* Remove unncessary comments

* only leave pwsh in this PR and exclude other shells

* keep exlcuding other shell env - only pwsh should remain

* Update src/vs/workbench/api/common/extHostTerminalShellIntegration.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vscode-dts/vscode.proposed.terminalShellEnv.d.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/contrib/terminal/common/scripts/shellIntegration.ps1

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/api/common/extHostTerminalShellIntegration.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/capabilities/shellEnvDetectionCapability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/api/common/extHost.protocol.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/api/browser/mainThreadTerminalShellIntegration.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/capabilities/shellEnvDetectionCapability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/capabilities/shellEnvDetectionCapability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/capabilities/shellEnvDetectionCapability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/capabilities/capabilities.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/workbench/api/browser/mainThreadTerminalShellIntegration.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* add comment for ShellEnvDetection

* change envs in shellEnvDetectionCapability to env

* Mention escaping character for EnvJSON similar to commandLine

* Do not fire env event if env has not changed

* add link to CommandLine

* follow main branch format so I avoid merge conflict

* remove resolved TODO

* Update src/vs/workbench/api/browser/mainThreadTerminalShellIntegration.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* use vscode object equals

---------

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2025-01-09 22:39:37 +00:00
Megan Rogge
4a8978f7de clean up terminal suggest code, fix bugs (#237599) 2025-01-09 21:31:20 +00:00
Sandeep Somavarapu
e8184ed571 real fix for #236429 (#237479) 2025-01-09 17:58:03 +01:00
Christof Marti
da4fcc54ac @vscode/proxy-agent 0.29.0 2025-01-09 17:12:10 +01:00
Sandeep Somavarapu
77027e72e5 Support filtering in output view (#237581)
* implement log filtering as a editor contrib

* show all log levels by default
2025-01-09 16:28:50 +01:00
Martin Aeschlimann
e85a6668b9 Merge pull request #237509 from microsoft/aeschli/xenacious-lemming-702
Use ICodeMapperService for 'Apply In Editor'
2025-01-09 16:07:02 +01:00
Sandeep Somavarapu
6eef1e20d7 simpler recovery fix for #237551 (#237578) 2025-01-09 16:04:27 +01:00
Johannes Rieken
5a932a6ac3 suggest - show previous item when reveal an in-the-middle item to indicate there are higher ranked suggestions (#237577) 2025-01-09 15:56:33 +01:00
Benjamin Pasero
067f61b472 linux - also change window.customTitleBarVisibility based on experiment (#237576) 2025-01-09 15:56:04 +01:00
Martin Aeschlimann
4c0e9312a1 Merge branch 'main' into aeschli/xenacious-lemming-702 2025-01-09 15:44:18 +01:00
Martin Aeschlimann
051d2dcfa2 apply edits: show progress while computing edits 2025-01-09 15:42:35 +01:00
Daniel Imms
a069d6f1f0 Merge pull request #237575 from microsoft/tyriar/237572_run_recent_scroll
Scroll to bottom instead of restoring state on run recent
2025-01-09 06:39:51 -08:00
Daniel Imms
af929ee6b3 Scroll to bottom instead of restoring state on run recent
Fixes #237572
2025-01-09 06:21:35 -08:00
Ladislau Szomoru
b7b6f26c62 Engineering - disable binskim (#237562) 2025-01-09 14:09:30 +01:00
Benjamin Christopher Simmonds
cdfd702e2f api 💄 (#237559) 2025-01-09 13:04:34 +01:00
Ladislau Szomoru
744eec9595 Git - update base branch revision when it changes (#237558) 2025-01-09 12:47:34 +01:00
Johannes Rieken
c65a0aba76 Remove some chat widget debt (#237556)
* chore - fix leaks editing service/session

* more appropriate name for `isHidden`, move remove-on-send logic into chatService
2025-01-09 12:29:01 +01:00
Martin Aeschlimann
7acfc76250 Merge remote-tracking branch 'origin/main' into aeschli/xenacious-lemming-702 2025-01-09 11:32:06 +01:00
Parasaran
0c176cf4cf fix 227150: Added a recursive git clone button (#232497)
* fix 227150: Added a recursive git clone button

* Git - update command for "Clone Repository" action

---------

Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
2025-01-09 11:24:05 +01:00
Sandeep Somavarapu
da8001297a fix #237551 (#237552) 2025-01-09 11:20:20 +01:00
Benjamin Christopher Simmonds
9cd58e41a4 Add requestUuid for inline edits (#237549) 2025-01-09 09:49:43 +01:00
Tyler James Leonhardt
232768306a Allow the QuickInput widget to be dragged (#237534)
* Allow the QuickInput widget to be dragged

Thanks to @lszomoru for the initial prototype! That also had resizing but there were a couple edge cases that made it not quite ready.

However, the drag-n-drop is really quite polished so I wanted to get this out for folks to try and I don't think it needs a setting.

Next steps:
* Add a snap to the top (aka the original location)
* Resize...

Fixes https://github.com/microsoft/vscode/issues/17268

* Add top snap

* don't allow it to go off screen
2025-01-09 04:42:13 +00:00
Benjamin Christopher Simmonds
a016c0be11 Support show range for inline edits (#237532)
Support a show range around the edit
2025-01-08 23:37:44 +00:00
Tyler James Leonhardt
e6cba379a4 Try asking for different claims in another request (#237531)
I'm hoping that this solution will be good enough until we stop depending on the id token for certain things.

Fixes https://github.com/microsoft/vscode/issues/237370
2025-01-08 23:55:18 +01:00
Daniel Imms
1a6e85d420 Merge pull request #237526 from microsoft/tyriar/10440_copilot
Fix terminal chat placeholder
2025-01-08 14:10:19 -08:00
Daniel Imms
e55bac8552 Merge pull request #237524 from microsoft/tyriar/234672
Initialize shellIntegration and shellIntegration.cwd of existing terminals on startup
2025-01-08 13:19:58 -08:00
Daniel Imms
1b8c516949 Fix terminal chat placeholder
Fixes microsoft/vscode-copilot#10440
2025-01-08 13:08:23 -08:00
Ladislau Szomoru
e03d4a0ea2 Git - Add "Open on GitHub" command to timeline hover (#237523) 2025-01-08 22:05:04 +01:00
Daniel Imms
2e1cc3848f Initialize shellIntegration.cwd
Fixes #234672
2025-01-08 12:59:02 -08:00
Megan Rogge
47b27ab160 wip #234672, force shell integration change for reconnected 2025-01-08 12:53:40 -08:00
Daniel Imms
bc561b5fbc Merge pull request #237521 from microsoft/tyriar/experimental_tag_conpty
Add missing experimental tab to conptydll setting
2025-01-08 12:12:13 -08:00
Benjamin Pasero
42ae0610a0 Copilot plan/settings links should be Proxima-aware (fix microsoft/vscode-copilot#11427) (#237520) 2025-01-08 21:00:44 +01:00
Matt Bierner
1ce23ea1f2 Merge pull request #237519 from mjbvz/sour-ptarmigan
Require `export` on all vscode public api types
2025-01-08 11:58:54 -08:00
Daniel Imms
5e45dbc944 Add missing experimental tab to conptydll setting 2025-01-08 11:54:01 -08:00
Benjamin Pasero
4fca8e5557 chat setup - log when workspace trust is not given (#237518) 2025-01-08 20:48:17 +01:00
Matt Bierner
68ec60529e Require export on all vscode public api types
Adds new eslint rule which requires `export` be used for public api types

The `export` is not actually needed, but our existing typing files largely use it. This makes it consistent
2025-01-08 11:40:36 -08:00
Ladislau Szomoru
dca80ea667 GitHub - add "Open on GitHub" to blame hover (#237514)
* WIP - saving my work

* Refactor hover rendering code
2025-01-08 11:34:54 -08:00
Matt Bierner
1329d03879 Merge pull request #236742 from mjbvz/jolly-dog
Add more logging around `filePatternsToUse`
2025-01-08 10:41:52 -08:00
Tyler James Leonhardt
691eaea3bd Remove old code, simplify properties (#237512) 2025-01-08 19:11:01 +01:00