Commit Graph

150196 Commits

Author SHA1 Message Date
Henning Dieterichs
52feef4e26 disables zip progress logging 2026-04-07 12:56:06 +02:00
Henning Dieterichs
1a6b425b58 removes checked in baseline images, as they are now tracked by the screenshot service 2026-04-07 12:56:06 +02:00
Henning Dieterichs
0c6eaf226b Revert AI stats status bar chartViewMode changes 2026-04-07 12:56:06 +02:00
Henning Dieterichs
9f457435f7 uses direct ingestion 2026-04-07 12:17:37 +02:00
Henning Dieterichs
8af61a608e Only show screenshot fixtures 2026-04-07 12:17:37 +02:00
Henning Dieterichs
de23b01119 sets up oidc authentication 2026-04-07 12:17:37 +02:00
Henning Dieterichs
f0cbaeb3b3 gitignores .tmp 2026-04-07 12:17:37 +02:00
Henning Dieterichs
dddae5db67 Changes ai stats fixture to trigger screenshot change 2026-04-07 12:17:37 +02:00
Henning Dieterichs
0673ca86f7 Post Screenshot Changes to PR 2026-04-07 12:17:37 +02:00
Sandeep Somavarapu
eb8138331c fix #306975 (#308177) 2026-04-07 09:43:57 +00:00
Alex Ross
c72ee2b976 Update distro (#308176) 2026-04-07 09:40:45 +00:00
Ladislau Szomoru
ffda2da513 Sessions - add action to open pull request (#308167)
* Sessions - add action to open pull request

* Disable action when a session is in progress
2026-04-07 09:27:38 +00:00
Johannes Rieken
5171cfeca7 inlineChat: clamp input widget horizontally to stay within editor viewport (#304795)
* inlineChat: clamp input widget horizontally to stay within editor viewport

* Update src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: update position check in InlineChatInputWidget to use read method

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2026-04-07 09:26:00 +00:00
Sandeep Somavarapu
2bdd5269f3 Revert "sessions: hide disabled chat input pickers (#307494)" (#308173)
* Revert "sessions: disable branch picker in folder mode (#307692)"

This reverts commit b9d09e3d65.

* Revert "sessions: hide disabled chat input pickers (#307494)"

This reverts commit c2f1a6ea43.
2026-04-07 09:16:04 +00:00
vs-code-engineering[bot]
e0dcd4dea8 [cherry-pick] [OSS Tool] Add license entry for tweetnacl (Unlicense / missing copyright) (#308170)
Co-authored-by: vs-code-engineering[bot] <vs-code-engineering[bot]@users.noreply.github.com>
2026-04-07 09:09:30 +00:00
Dmitriy Vasyura
68bc772a99 Preserve keybinding when default when clause becomes more specific (#306979) 2026-04-07 13:45:42 +05:00
João Moreno
8aa4cf8a0f Revert build breakages (#308162)
* Revert "agentHost: Hook up isRead/isDone (#308107)"

This reverts commit a3d69b7767.

* Revert "agentHost: support connections over tunnels (#307948)"

This reverts commit 75f21d0a8d.
2026-04-07 08:43:56 +00:00
João Moreno
b40d047e0c temporarily disable TSA (#308155) 2026-04-07 08:42:12 +00:00
João Moreno
b62de5701b Revert "fix build by removing non-current-platform prebuilds in postinstall script" (#308160)
Revert "fix build by removing non-current-platform prebuilds in postinstall s…"

This reverts commit e433503037.
2026-04-07 08:39:07 +00:00
João Moreno
e433503037 fix build by removing non-current-platform prebuilds in postinstall script (#308154) 2026-04-07 08:13:29 +00:00
Peng Lyu
2ecf0370de fix #304202. (#308128)
* fix #304202.

* resolve comments.
2026-04-06 23:03:28 -07:00
Maruthan G
7c4cbc79dc fix: preserve code block toolbar visibility during chat streaming (#307978)
fix: preserve code block toolbar visibility during chat streaming (#255290)

Add JavaScript-based hover tracking to CodeBlockPart so the toolbar
remains clickable through DOM detach/reattach cycles during streaming.
2026-04-07 05:25:14 +00:00
Rob Lourens
cfd197f7a5 Add more telemetry for chat model retainers (#308124) 2026-04-06 20:30:39 -07:00
Vijay Upadya
d5429a8edb Fix Agent Debug Panel flow chart for new JSONL-based debug events (#308126)
* Fix Agent Debug Panel flow chart for new JSONL-based debug events

* feedback updates
2026-04-06 20:30:36 -07:00
Don Jayamanne
1178013b81 fix: reset chat mode when switching to session with customAgentTarget (#308010)
* fix: reset chat mode when switching to session with customAgentTarget

Fixes #307118

When switching from Local to CLI, Ask/Plan modes persisted because:
1. ModePickerActionItem captured customAgentTarget once at construction,
   so the dropdown kept showing Local's modes even after switching to CLI.
2. chatInputPart validated the model on session switch but not the mode.

Now the mode picker dynamically evaluates the target on each dropdown
open, and a new checkModeInSessionPool() resets invalid modes to Agent.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: use explicit session type in checkModeInSessionPool

Pass newSessionType directly from the onDidChangeActiveSessionProvider
handler instead of deriving it from the session resource, which may
not yet reflect the newly selected provider.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: dynamically evaluate customAgentTarget in mode picker dropdown

Make the mode picker evaluate the custom agent target each time the
dropdown is opened instead of capturing it once at construction time.
This ensures the correct modes are shown after switching session types.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 13:29:22 +10:00
Justin Chen
719c62b60e perf: improve thinking layout thrashing (#308122)
less thikning layout thrashing - cache thinking heights
2026-04-06 20:03:53 -07:00
Anthony Kim
4f24877577 Fix ctrl+v img file path paste in windows powershell (#308097)
* Fix ctrl+v img file path paste in windows powershell

* better

* comment
2026-04-06 20:02:54 -07:00
Courtney Webster
469880ff30 Merge pull request #308044 from microsoft/copilot/start-implementation-copilot-cli-tip
Add Copilot CLI chat tip
2026-04-06 20:49:01 -05:00
Josh Spicer
d50b48b975 chat: add policy for chat.plugins.enabled (#308084)
* chat: add policy for chat.plugins.enabled

Add a managed policy 'ChatPluginsEnabled' to the chat.plugins.enabled
setting so that organizations can control whether agent plugin
integration is enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update src/vs/workbench/contrib/chat/browser/chat.contribution.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update build/lib/policies/policyData.jsonc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-04-06 18:44:33 -07:00
Josh Spicer
4f71da1273 Detect extension-sourced items in provider path for correct grouping (#308115)
* Detect extension-sourced items in provider path for correct grouping

Items from VS Code extensions (under extensions/ directory) were
classified as 'user' storage because _inferStorageAndGroup only
checked workspace folders, plugins, and file: scheme. Now detects
extension install directories by finding 'extensions' in the path
segments and extracting the extension ID from the folder name.
Items from the default chat extension are classified as Built-in;
items from other extensions as Extensions.

This aligns the provider path grouping with how the core (Local)
path handles extension-contributed skills, agents, and other items.

Fixes microsoft/vscode-internalbacklog#7330

* Make built-in and extension items read-only in provider path

Set storage alongside groupKey in _inferStorageAndGroup so that
built-in items (non-file schemes, chat extension) always have
PromptsStorage.extension as their storage. This ensures the
delete action's when-clause correctly hides the trash icon for
read-only items without needing a groupKey fallback hack.

Fixes microsoft/vscode-internalbacklog#7330
2026-04-06 18:33:10 -07:00
Josh Spicer
bda49a1b25 Enable chat.customizations.providerApi.enabled by default (#308116)
Enable chat.customizations.providerApi.enabled by default

Set the default value of 'chat.customizations.providerApi.enabled' to
true and remove the experimental tag, graduating this setting to stable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-07 01:11:23 +00:00
Rob Lourens
62b45362b0 chat: Remove startup revive of chat sessions with pending edits (#308113)
Remove startup revive of chat sessions with pending edits

Remove reviveSessionsWithEdits() and the whenSessionsRevived property from
IChatService. This code eagerly loaded sessions at startup if they had
pending edits, which is no longer needed.

Also removes the modelsKeptAliveOnlyForEdits telemetry metric that was
specific to this revive path. The hasPendingEdits field is kept on the
serialized data and storage index for potential future use.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-06 17:58:12 -07:00
Rob Lourens
a3d69b7767 agentHost: Hook up isRead/isDone (#308107)
* agentHost: Hook up isRead/isDone

Co-authored-by: Copilot <copilot@github.com>

* comments

* Fix build

Co-authored-by: Copilot <copilot@github.com>

* Fix test

---------

Co-authored-by: Copilot <copilot@github.com>
2026-04-06 17:50:53 -07:00
Josh Spicer
bb14e18d79 ChatSessionCustomizationProvider: fix groupKey, deletion refresh, section visibility, and dropdown UX (#308096)
* Show provider items with custom groupKey in Chat Customizations

Items from external customization providers that use a custom
groupKey (not matching predefined groups like Workspace, User, etc.)
were silently dropped. Dynamically create a group for unknown
groupKeys so the items appear under a collapsible header using
the groupKey as the label.

Fixes microsoft/vscode-internalbacklog#7402

* Refresh list after deleting a customization item

After deleting a file through the Chat Customizations UI, explicitly
refresh the list widget. This ensures the deleted item is removed
immediately even if the provider's onDidChange doesn't fire (e.g.
when the provider doesn't watch the filesystem for changes).

Fixes microsoft/vscode-internalbacklog#7401

* Reset section counts on harness switch to prevent stale flash

When switching between customization harnesses (e.g. Local → Copilot
CLI), reset all section counts to zero immediately before starting
the async count refresh. This prevents stale counts from the
previous harness briefly appearing in the sidebar.

Fixes microsoft/vscode-internalbacklog#7400

* Add tooltip to harness dropdown button in Chat Customizations

Show the active provider's label as a managed hover tooltip on
the harness dropdown button, so long provider names that are
truncated by CSS ellipsis can still be read.

Fixes microsoft/vscode-internalbacklog#7396

* Prevent harness dropdown from jumping when providers register late

Keep the dropdown container in the DOM when the harness selector
setting is enabled, even if only one harness is available. The
visibility is controlled by CSS display:none in updateHarnessDropdown
based on harness count. This prevents the dropdown from being
destroyed and recreated at the wrong position when a provider
registers asynchronously after the editor has already laid out.

Fixes microsoft/vscode-internalbacklog#7398

* Fix focus outline clipping on plugin page buttons

Add margin to focused buttons in the button group to prevent the
focus outline from being clipped by the parent widget's
overflow:hidden. The outline-offset: -1px alone was not sufficient
because the outline still extended to the container edge.

Fixes microsoft/vscode-internalbacklog#7385

* Classify plugin-sourced items correctly in provider path

Items from installed plugins (under agent-plugins directory) were
classified as 'user' storage because _inferStorageAndGroup only
checked workspace folders and file: scheme. Now checks against
IAgentPluginService.plugins URIs to detect plugin-sourced items
and classify them as PromptsStorage.plugin. Also adds Plugin
group to the provider grouping layout so these items appear
under a proper 'Plugins' header instead of 'User'.

Fixes microsoft/vscode-internalbacklog#7330

* Add horizontal padding to search-and-button container for outline room

Restore 2px horizontal padding on .list-search-and-button-container
so the focus outline on the rightmost button has room to render
without being clipped by the parent widget's overflow:hidden.

Fixes microsoft/vscode-internalbacklog#7385
2026-04-07 00:27:33 +00:00
Osvaldo Ortega
910529e09d Sessions: Add #file context completions to new-chat input (#308095)
* Sessions: Add #file context completions to new-chat input

Adds # completions to the sessions NewChatViewPane input editor,
scoped to the workspace selected in the dropdown picker.

- New VariableCompletionHandler registers a completion provider on the
  sessions-chat URI scheme (same pattern as SlashCommandHandler)
- Typing # shows files from the selected workspace via ISearchService
  (local/remote) or IFileService tree walk (virtual filesystems)
- Recent workspace-scoped files from editor history are always shown
- Accepted completions insert #file:<name> text with slash-command-style
  decorations (colored background/foreground, rounded corners)
- Files are also added as attachment pills via NewChatContextAttachments
- Added public addAttachments() method to NewChatContextAttachments

* Review comment

* Address review: fix JSDoc to say #file: for files and folders

* Support folder
2026-04-07 00:27:10 +00:00
Justin Chen
f2199e406c fix overflow issue in chat (#308108) 2026-04-07 00:05:33 +00:00
Ben Villalobos
cf22cdfc96 Allow version bump PRs with package-lock.json changes (#308100)
Extends the bot exception in no-engineering-system-changes to handle
version bump PRs that include package-lock.json alongside package.json.

The previous change (#308090) only allowed single-file package.json
changes. Version bumps also run npm install which updates the lock file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-07 00:04:20 +00:00
Rob Lourens
2bfd243feb agentHost: Simplify SSH relay reconnect with dispose-and-recreate pattern (#308106)
Refactor SSHConnection to use the same dispose-and-recreate pattern as
TunnelConnection instead of the more complex isActiveRelay/replaceRelay
approach.

Key changes:
- Remove isActiveRelay() and replaceRelay() from SSHConnection
- Make _relay readonly (immutable connection objects)
- Add detachSshClient() for ownership transfer during reconnect
- Add removeListener to SSHClient interface for proper cleanup
- Simplify relay close handlers to just call conn.dispose()
- Add try/catch in reconnect to clean up SSH client on failure

Add 18 new unit tests covering relay message routing, multi-host
isolation, SSH close lifecycle, CLI install flow, reconnect failure
cleanup, and listener cleanup across reconnects (33 total, up from 15).
2026-04-06 17:03:39 -07:00
Osvaldo Ortega
66c2fef3d2 Sessions: telemetry fix (#308093) 2026-04-06 16:37:35 -07:00
Josh Spicer
dc5a5460f4 ChatSessionCustomizationProvider testing fixes (#308071)
* Delete individual hooks instead of entire hooks file

When deleting a hook from the Chat Customizations UI, parse the hook
item ID to identify the specific entry within the JSON file. Remove
only that entry and write the file back, instead of deleting the
entire hooks file. If no hooks remain after removal, the file is
deleted.

Also passes the item ID through the action context so the delete
handler can distinguish individual hook entries from whole files.

Fixes microsoft/vscode-internalbacklog#7381

* Throw CancellationError when plugin trust dialog is declined

When the user cancels the trust dialog during plugin installation,
throw a CancellationError instead of silently returning. This allows
the install button's catch handler to properly reset to 'Install'
state instead of incorrectly showing 'Installed'.

Fixes microsoft/vscode-internalbacklog#7378

* Check installed state when rendering marketplace plugin items

When rendering marketplace plugin items in the plugin list, check
whether the plugin is already installed by comparing install URIs
with the agent plugin service's plugin list. Show 'Installed' with
the button disabled instead of offering a redundant install option.

Fixes microsoft/vscode-internalbacklog#7379

* Replace floppy disk icon with newFile icon for create plugin button

The save/floppy disk icon is misleading for a create action. Use the
newFile codicon instead, which better communicates the intent and is
consistent with other create actions in the UI.

Fixes microsoft/vscode-internalbacklog#7373

* Fix plugin page CSS: padding, back button, and focus outlines

- Add padding-bottom to marketplace plugin footer for proper Install
  button alignment (fixes #7377)
- Restyle back-to-installed link as a button with muted foreground
  color and rounded hover background instead of link styling
  (fixes #7384)
- Add outline-offset: -1px to button group buttons to prevent focus
  outline clipping by parent container (fixes #7385)

Fixes microsoft/vscode-internalbacklog#7377
Fixes microsoft/vscode-internalbacklog#7384
Fixes microsoft/vscode-internalbacklog#7385

* Show workspace folder name in provider path for multi-root workspaces

When rendering items from external customization providers (e.g.
Copilot CLI), use the label service to produce workspace-relative
paths for file: URIs instead of bare filenames. This shows the
folder name (e.g. 'tankgame • AGENTS.md') in multi-root workspaces,
matching the core (Local) path behavior.

Fixes microsoft/vscode-internalbacklog#7330
2026-04-06 16:03:04 -07:00
Ben Villalobos
d843b57fb4 Allow vs-code-engineering bot to update version field in package.json (#308090) 2026-04-06 22:57:34 +00:00
Osvaldo Ortega
d15541a5ef Sessions: center approval row (#307676)
* Sessions: center approval row

* Remove old align
2026-04-06 15:36:56 -07:00
Elijah King
27f3ec77a9 Merge pull request #307717 from microsoft/copilot/update-ghe-button-label
Change GHE enterprise sign-in button label from "GHE.com" to "GHE"
2026-04-06 15:31:33 -07:00
Megan Rogge
992a6847a2 make terminal timeout mandatory (#308081)
fixes #308037
2026-04-06 15:11:32 -07:00
Justin Chen
b15c8fd37e fix stuck/stopping thinking parts (#307929)
* fix stuck/stopping thinking parts

* address comments
2026-04-06 14:57:20 -07:00
Megan Rogge
f1c30e9dc2 Fix listener leak from multiple background OutputMonitors on same terminal (#308069) 2026-04-06 21:12:26 +00:00
Megan Rogge
6ad7758ef9 use backticks for sent terminal commands (#308075) 2026-04-06 21:11:19 +00:00
vs-code-engineering[bot]
6c8b1e5763 [cherry-pick] fix padding in solo tool calls (#308077)
Co-authored-by: vs-code-engineering[bot] <vs-code-engineering[bot]@users.noreply.github.com>
2026-04-06 21:03:05 +00:00
Vijay Upadya
493ca793c1 Agent Debug: Use fileLogging.enabled as sole authoritative setting for agent debug logging (#308061)
* Consolidate flag for debug panel

* feedback changes
2026-04-06 13:40:38 -07:00
cwebster-99
59296f8b9e Remove dismiss 2026-04-06 15:19:10 -05:00