* sessions: tweak session files widget in changes view
- Use default ResourceLabels (no supportIcons) so file icons render
- Drop the resource path from the file description
- Only open a diff for modified files when the original has content
- Show A/M/D change decoration badges like the changes view
- Remove strikethrough for deleted files
- Add an Open File action to the row toolbar matching the changes view
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: remove file count from session files header
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Reinstate colors of symbol codicons when used in custom tree views
* Attestation commit
* Attestation commit
* Attestation commit
* Attestation commit
---------
Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
When multiple editors are closed at once (Close All Editors, Close Others, etc.), Reopen Closed Editor now reopens them all as a batch instead of one at a time.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Give the Pinned section a leading pin icon (mirroring the Chats section's
chat icon) and make both section headers share the standard section-header
font/styling. Also keep the Pinned section always visible with a
"No pinned sessions" placeholder when empty, matching the Chats section.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Non-active agent-host session PR icons don't refresh until the session is activated. The per-session poller in GitHubPullRequestPollingContribution keeps a shared PR model warm only once its identity resolves, but the previous trace collapsed all four bail-out stages into one generic message and gave no visibility into how many sessions were actually tracked.
Disambiguate the identity derivation into a discriminated PullRequestIdentityState (ok / archived / no-workspace / no-git-repository / no-pull-request) and log the precise stage where a session's PR model is not kept warm, plus the total tracked poller count on each sessions change. Behavior is unchanged; only the 'ok' state starts polling as before.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sessions: hide subagent chats by default, persist closed chats, and add chat capabilities
Improves chat management in the Agents window session view:
- Subagent (tool-origin) worker chats are hidden from the chat tab strip by
default and surface as a tab only when explicitly opened (e.g. from the
Subagents dropdown); closing one hides it again without adding it to the
reopenable closed set. Reverts on reload.
- Closing a chat is remembered across reload/restart (closed-chat set is
persisted per session and restored on startup); subagents are excluded from
the persisted set.
- Adds "Close All Chats" command (Ctrl/Cmd+K W, mirroring "Close All Editors in
Group"), gated on SessionHasMultipleOpenChats so it targets the focused
session and does not collide with "Close All Sessions" (Ctrl/Cmd+K Ctrl/Cmd+W).
- Introduces per-chat IChatCapabilities (canRename/canDelete) with a central
getChatCapabilities resolver that folds in the main-chat invariant (never
deletable). Subagent chats report neither rename nor delete; the tab context
menu, delete keybinding, and context keys now go through capabilities instead
of ad-hoc origin/main-chat checks.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the experimental chat.cacheBreakHint.enabled setting and its gate so
the model/options picker cache-break hint shows by default (still respecting
dismissal and cache-warm state).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Refactor agent chat operations to resolve chats uniformly
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Refactor chat ops to use concrete chat URIs
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: tolerate a session URI at the chat-context chokepoint (fix CI)
The chat-addressing refactor removed the agents' tolerance for addressing the
default chat by its session URI (the AHP convention: default chat URI == session
URI). This broke integration tests that address the default chat by the session
URI (Malformed AHP chat URI) and restore via the mock agent (0 restored turns).
- Claude/Copilot `_getChatContext`: accept either a chat channel URI or a bare
session URI, normalizing to the default-chat URI in the single resolution
chokepoint (not re-derived per operational method). Codex already tolerant.
- MockAgent.getSessionMessages: normalize a default-chat channel URI back to the
session URI, mirroring the real agents.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: remove the dead onDidEndChat membership channel
onDidEndChat was declared by Claude and Copilot but never fired: a completed
subagent chat stays live and is removed only on session teardown (via a direct
removeChat), so subagent_completed intentionally has no end event. Remove the
unused channel end-to-end — the agents' emitters, the optional
IAgent.onDidEndChat member, the orchestrator subscription + _onChatEnded handler,
and the synthetic test. onDidSpawnChat (which is fired) remains as a spawn-only
membership channel.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: rename IResolvedAgentChat.session to chatSession
Address CCR feedback: `session` overwhelmingly means the owning session URI in
this codebase, so `IResolvedAgentChat.session` (the resolved chat session
instance) was easy to misread. Rename to `chatSession` and update the two call
sites in claudeAgent.ts / copilotAgent.ts.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: quick chats — workspace-less single-chat sessions
Adds quick chats to the Agents window: lightweight chats not scoped to a
workspace, backed by an agent-host session. The host infers workspace-less
from an absent workingDirectory (forks excluded) and assigns a stable scratch
dir; the workspaceless tag rides the generic _meta bag. Quick chats are
single-chat, use the normal session presentation (Done hidden), render in an
always-visible in-list "Chats" section, and persist across reloads.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: New from a quick chat opens another quick chat (Round 23)
The primary "New" action gated quick-chat routing on `isCreated &&
isQuickChat`, but a quick-chat draft is Untitled (isCreated=false), so it
fell through to the workspace composer seeded with a throwaway scratch dir
(no session-type picker, "No models available").
Route on `isQuickChat` alone so a quick chat — draft or committed — opens
another quick chat mirroring its harness. Extract the routing into a pure,
side-effect-free `openNewChatOrQuickChat` helper so it is unit-testable
(chat.contribution.ts is not test-importable). Supersedes Round 14(2) and
updates Round 22(3); the Round 14(2) discard branch and Round 17 picker
re-parent are kept as internal defense.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: quick-chat list & layout polish (Round 22 items 1-2)
- Suppress the redundant per-row chat icon when a quick chat is rendered
under the always-visible "Chats" section (the section header already
carries a chat icon); keep it in Pinned/custom/date groups where the
chat identity is useful.
- Disable the "Toggle Side Panel" command for quick chats via
precondition IsQuickChatSessionContext.negate(), since a quick chat has
no side pane (the empty aux bar is hidden and the chat is full-width).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: persist empty peer-chat catalog sentinel to avoid re-running legacy migration
When a session has no legacy peer chats, write an empty catalog so
_readPersistedPeerChatCatalog returns [] on subsequent restores and
_migrateLegacyPeerChats never re-runs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: Cmd+N always creates a new session; New Quick Chat gets Cmd+K Cmd+N (Round 24)
Per user feedback, Cmd+N must always open a NEW SESSION — never a quick
chat. Drop the context-aware quick-chat routing from
NewChatInSessionsWindowAction (rename its title "New Chat" -> "New Session",
keep the id) so it unconditionally calls openNewSession from the active
session; the helper is renamed openNewChatOrQuickChat -> openNewSessionFromActive.
Quick chats are created only via the Chats-section "+" (NewQuickChatAction),
which now has a default Cmd+K Cmd+N chord. The peer-chat "+" (Cmd+T) is
unaffected. Supersedes the Round 22(3)/23 mirror routing; the Round 14(2)
discard branch and Round 17 picker re-parent are untouched.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: Cmd+N never inherits a quick chat's folder into the workspace composer (Round 25)
New from a quick chat must always land on the clean New Session composer with
a visible session-type picker. Gate openNewSessionFromActive's folder
inheritance on isQuickChat so a quick chat never carries a (possibly leaked
scratch) workspace URI into openNewSession.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: re-seed workspace draft when composer swaps out of quick-chat mode (Round 25b)
Cmd+N from a quick chat reuses the new-session composer and only
_activate(undefined), leaving it session-less. The session-type picker hides
itself when it has no folder types (no active session), so no picker showed.
Re-run the constructor's workspace-draft seed from an autorun when the composer
transitions out of quick-chat mode with no active session, matching a freshly
opened new-session composer (folder + visible picker).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: quick-chat untitled title falls back to "New Chat" via shared helper (Round 26)
An untitled quick chat's titlebar showed "New Session" because the empty-title
fallback was hardcoded and not quick-chat aware. Add getUntitledSessionTitle(isQuickChat)
to the common layer and route all 5 fallback sites (titlebar, session header x2,
list hover, sessions picker) through it.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: track isQuickChat in titlebar re-render autorun (Round 27)
The SessionsTitleBarWidget re-render autorun read the active session's
title and workspace but not isQuickChat, which _render() consumes for the
untitled title fallback. Track it as a reactive dependency for
forward-safety and consistency with other reactive render sites.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: move workspace-less marker ownership to the AH service
Each agent used to persist and re-emit its own workspace-less (quick chat)
marker (copilot.workspaceless / claude.workspaceless) in the shared session
database, and agents that persist nothing (Codex) lost the marker on restart.
Make the AH service the single owner: AgentService persists a single
agentHost.workspaceless key at create/materialize (from the value it already
infers in _buildInitialSummary) and overlays _meta.workspaceless onto every
agent's summary in listSessions. Agents no longer write or namespace the
marker; Copilot reads the shared key for its resume system prompt, and the
now-dead workspace-less plumbing is removed from the Claude session. This
fixes restored quick chats for every agent (including Codex) with no
per-agent code.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions/agentHost: address review feedback (naming + inline)
- Rename the workspace-less launch-plan flag from isQuickChat to
workspaceless in CopilotSessionLaunchPlan and IAgentHostPromptContext (and
the disposeSession local) so the flag matches the workspaceless marker it
flows from throughout the AH layer. Feature-descriptive names
(COPILOT_AGENT_HOST_QUICK_CHAT_INSTRUCTIONS, _quickChatScratchDir) are kept.
- Inline openNewSessionFromActive back into NewChatInSessionsWindowAction.run
and remove the single-caller seam module + its test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: make the AH service the sole owner of the workspaceless marker
Following the earlier ownership move, the agents still read + re-emitted
_meta.workspaceless in their metadata projections, which was redundant on the
listSessions path (AgentService overlays it centrally) and only load-bearing
on the single-session restore path.
Centralize the restore overlay in AgentService.restoreSession (reads
agentHost.workspaceless in its existing batch metadata read and merges it into
the restored summary _meta), then drop the per-agent re-emit: remove it from
the Claude metadata store entirely (Claude has no runtime need) and from the
Copilot listSessions/getSessionMetadata projections. Copilot keeps reading the
AH key for its resume system prompt and scratch-dir cleanup. Codex is now
covered centrally with no Codex code.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: inline openQuickChatAndFocus into NewQuickChatAction
Single-caller helper folded into the action's run().
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: make ISessionsProvider.createQuickChat mandatory
Replace the optional createQuickChat with a mandatory method that throws when
the provider does not support quick chats; callers now gate solely on the
supportsQuickChats capability instead of probing for the method. Workspace-bound
providers (Copilot chat, local chat) get an explicit throwing implementation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: use "workspace-less chat" terminology instead of "quick chat"
Rename the agent-host-internal quick-chat identifiers, prompt tags, and prose to
workspace-less: COPILOT_AGENT_HOST_QUICK_CHAT_INSTRUCTIONS ->
COPILOT_AGENT_HOST_WORKSPACELESS_INSTRUCTIONS, the <quick_chat> system-message
tag -> <workspaceless_chat>, and the scratch-dir helpers
(_quickChatScratchDir/_ensure*/_cleanup*/_withQuickChatScratch). The workbench
UI term "Quick Chat" is kept only where the agent host documents that mapping.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: address Copilot Code Review feedback on quick chats
- sessionsList: select the row chat icon from isQuickChatSession(), not from
workspace === undefined, so a workspace session with a transiently-undefined
workspace no longer briefly shows the chat icon.
- sessionContextKeys: correct the isQuickChat comment to reflect that the key
is sourced from the isQuickChat tag, never inferred from workspace absence.
- Agents window accessibility help: document the New Quick Chat command
(Cmd/Ctrl+K Cmd/Ctrl+N) and the Chats section plus button, and note that the
workspace picker does not apply and Toggle Side Panel is disabled for quick chats.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* wip on mcp auth through AH
* Preserve live MCP server state across customization re-syncs
The Agents window showed a connected GitHub MCP server flipping back to
'Starting' when navigating away from and back to a session. A client
re-subscribe re-published the session's customizations, and the
SessionCustomizationsChanged full-replace reset each MCP entry's state to
the 'Starting' default baked into makeMcpServerCustomization.
- Skip no-op customization re-syncs in SessionPluginController.sync so an
identical re-publish (e.g. navigating back) does no work.
- SessionPluginController now overlays live MCP runtime state/channel onto
every published customization via _projectForPublish, so a genuine
single-customization change no longer resets otherwise-unchanged MCP
servers. The overlay is driven by an ISettableObservable kept up to date
by the session from McpCustomizationController.
- McpCustomizationController._live is now an observable and exposes
runtimeStates as a derived; mutations are batched in transactions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Persist agent-host MCP auth and improve auth-required prompts
- Key remembered MCP auth on a stable id (session authority + server name +
resource URL) instead of the unstable customization id, so grants survive
reloads and don't require re-auth.
- Record agent-host metadata (authority + host label) on allowed MCP servers
and surface agent-host servers in their own section of the Manage Trusted
MCP Servers picker instead of filtering them out.
- Make the auth-required chat prompt reactive: servers is now an observable so
servers whose auth requirement surfaces later join the existing prompt, and
the part marks itself used once hidden so later requirements re-prompt.
- Show an 'Authenticating <server>...' progress state while each server auths.
- Drop the never-serialized mcpAuthenticationRequired part from the serialized
response-part unions.
- Add unit tests for the stable-id helper, agentHost metadata persistence, and
query-service exposure.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Address CI failure and Copilot review on MCP auth prompt
- Don't emit an empty mcpAuthenticationRequired progress part (was adding a
stray part and breaking AgentHostChatContribution tool-progress tests).
- Guard the async auth filter with a run id so out-of-order completions can't
overwrite a newer server list.
- Group agent-host servers in the Manage Trusted MCP Servers picker by stable
authority (sorted by label) instead of label, which could collide.
- Scope the authenticate link to the #authenticate target and give it button
semantics (role=button, cleared href).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds ChatInteractivity (Full/ReadOnly/Hidden) to IChat and hides the composer
for non-interactive chats (gated via chatIsReadonly context key). Surfaces agent
host subagent (tool-origin) chats as read-only peer tabs with a lock icon,
persisted across restart. Adds an inline "Open Subagent" pill in the transcript
and a "Subagents" dropdown above the chat input to reveal them.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: remove Claude dead legacy migration + drop redundant session param
PART 1: remove the unreachable claude.chats legacy peer-chat migration
(listLegacyChats, _readPersistedChats, _META_CHATS and the two dead
fallback call sites). Copilot's copilot.chats migration and the
orchestrator's generic migration are unchanged.
PART 2A: drop the redundant session parameter from IAgentChats.createChat
and fork. Each agent derives the parent session from the chat URI.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: demote default chat to a uniform chat-map entry
Restructure the shared AgentSessionEntry so a session's default (main)
chat lives in the SAME per-session chat map as its peers, keyed by its
default-chat URI. Send/abort/model/agent/history now resolve any chat
via one uniform getChat lookup with no default-vs-peer storage split.
- agentPeerChats.ts: single _chats map + _defaultChatKey; getChat is the
uniform lookup; defaultChat/setDefaultChat/clearDefaultChat replace the
separate default-session slot; peer accessors read the same map.
- Claude/Copilot seed the default chat into the map (setDefaultChat) and
read it via defaultChat; _findChat is a single uniform lookup.
- Two lifecycle guards kept at the session boundary: createSession seeds
the default entry; disposeChat/createChat refuse the default chat.
- Codex (single-chat) unchanged; still resolves through the session URI.
No protocol/state changes; behavior identical (Agent* suites green).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: resolve per-chat effective working directory in session projection
Generalize the mergeSessionWithDefaultChat projection so a chat's resolved
session-context view (working directory, active clients, config,
customizations/MCP scope, …) applies to ALL chats, not just the default one.
The projection already spreads the full SessionState onto every chat, but it
ignored ChatState.workingDirectory — a per-chat override the protocol allows so
a subordinate/peer chat can run in its own git worktree. Operational consumers
(changeset/commit/discard/git/PR/sync services + agentService) read the effective
cwd via getSessionState(...)?.workingDirectory, so a chat with its own worktree
incorrectly reported the session default. Layer chat.workingDirectory over the
session default in the projection so no code path has to walk back to the session.
Pure orchestrator-side projection: no wire-protocol, IAgent, or persisted-shape
change. Docs generalized from "default chat" to per-chat effective context.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: route MockAgent createChat/fork through the resolved chat URI
Address CCR feedback: createChat/fork resolved the session via
_resolveChatTarget but passed the original chat argument, so a default-chat
call (session URI) would use the session URI instead of the resolved
default-chat channel URI. Destructure and pass the resolved { session, chat }
to match the other chat-addressed methods in the mock.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add Responses API cache control markers
* Refactoring code
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Gate Responses API cache breakpoints by model support
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* sessions: add explicit "Open this folder" action to the mobile workspace picker
Tapping a folder in the mobile workspace picker drills into that folder, which re-renders the search results and removes the visible checked state for the selected folder. That made it unclear that Done would select the browsed folder.
Add a confirm-close sentinel to the reusable mobile picker sheet so stay-open pickers can explicitly confirm a row. Use it from the workspace picker to prepend an "Open this folder" row for the currently browsed folder, while preserving child-folder drill-down and Done confirmation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: redesign mobile workspace picker "Select folder" as a single pinned action
Replace the synthetic checked "Open {folder}" row (which produced two
checkmarks and a Done/Open redundancy) with one tinted-accent, pinned
"Select {folder}" primary action above the folder list. Folder rows now
carry a chevron to signal drill-down, recents show only at the root, and
the header button is a plain Cancel.
Adds reusable primitives to the mobile picker sheet:
- `IMobilePickerSheetItem.navigates` renders a trailing chevron and is
excluded from the radio-toggle.
- a pinned primary action driven declaratively by the search source via
`IMobilePickerSheetSearchSource.getPrimaryAction(query)`.
- `doneLabel` to override the dismiss button label.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Review comments
---------
Co-authored-by: osortega <osortega@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* policy: resolve managed settings per-key across delivery channels
Managed settings previously used a single authoritative source: the first
non-empty delivery channel (native MDM > server > file) won wholesale and the
others were ignored entirely. Switch to per-key precedence: the same order is
honored, but resolved key-by-key. A key locked by a higher-precedence channel
still cannot be overwritten, while keys a higher channel leaves unset are now
filled in by a lower channel.
Centralize the resolution in a new pickManagedSettings() (replacing
selectManagedSettings) that returns the merged bag, per-key provenance, and the
active sources, so policy evaluation and the Policy Diagnostics report share one
implementation. Build the merged bag with Object.fromEntries so an untrusted
__proto__ key cannot corrupt its prototype chain.
Rework the Policy Diagnostics report to show every contributing source, a per-key
Resolution table (effective value, winning source, and struck-through overrides),
and per-key policy attribution.
Add unit coverage for the per-key merge (provenance, fill-down, falsy values,
ordering, prototype-pollution guard) plus an end-to-end test proving two keys can
win from two different channels and both reach policy evaluation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* policy: iterate managed-settings bags with Object.keys over own props
Address PR feedback: switch pickManagedSettings from `for...in` to a guarded
`Object.keys` loop so only own enumerable properties are visited (managed-settings
bags are untrusted input) and absent channels are skipped explicitly.
Note: `for...in` over an undefined bag was already a no-op (never threw), so this is
a robustness/clarity improvement rather than a crash fix.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* policy: tidy pickManagedSettings unit suite
Drop two redundant cases (distinct-keys and standalone activeSources ordering,
both already covered by the headline and empty/absent tests) and fold the
non-contributing-middle-channel ordering check into the empty/absent snapshot.
Verified against the live node unit runner (all green).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Re-syncs common/state/protocol/* from the agent-host-protocol repo now that
AgentCapabilities has been upstreamed and merged there. PR #323625 had
hand-edited the generated channels-root/state.ts to add AgentCapabilities +
AgentInfo.capabilities?; this regenerates it from AHP so it is no longer a
DO-NOT-EDIT hand-edit that the next sync would silently overwrite.
The upstreamed shape evolved from the hand-edit: instead of flat
`supportsMultipleChats`/`supportsFork` booleans, the generated
AgentCapabilities now exposes an MCP-style nested `multipleChats?:
MultipleChatsCapability { fork? }` (presence signals support, absence =
unsupported). Consumers that produced/read the protocol capabilities were
adapted to the new shape with equivalent semantics; the vscode-internal
ISessionCapabilities (supportsMultipleChats/supportsFork) is unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add support for system-wide (OS global) keybindings
Allow user keybindings in keybindings.json to be marked with "systemWide": true so they register as operating-system global shortcuts that fire even when the window is not focused.
- Thread the systemWide flag through IUserFriendlyKeybinding, ResolvedKeybindingItem and KeybindingIO (read + serialize)
- New GlobalKeybindingsMainService owns Electron's globalShortcut, reconciles per-window registrations, resolves conflicts deterministically and routes triggers through the existing vscode:runAction path
- New renderer contribution syncs opted-in bindings to the main process, gated behind the experimental, off-by-default setting keyboard.enableSystemWideKeybindings with a one-time confirmation dialog
- Enable the GlobalShortcutsPortal feature on Linux/Wayland
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Avoid focusing the routing window on system-wide keybinding trigger
Force-focusing the routing (main) window before dispatching the command
pulled it to the foreground even when the command opens/reveals a different
window (e.g. openAgentsWindow reveals the agents window), producing a visible
flicker. Remove the force-focus and let the invoked command control what is
surfaced/focused, matching every other vscode:runAction sender.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Add workbench.action.focusWindow to raise the current window
Adds a generic command that brings the current window to the foreground and
focuses it using FocusMode.Force (which works even when the application is not
the active app). This lets users compose system-wide keybindings via
runCommands to reveal the window before running a command that surfaces UI in
it, e.g. [workbench.action.focusWindow, workbench.action.quickOpen].
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Address Copilot review: schema default, mnemonic comment, test grammar
- keybindingService.ts: correct 'systemWide' schema default to false to match
KeybindingIO parsing (defaults to false when absent/invalid)
- systemWideKeybindings.contribution.ts: add '&& denotes a mnemonic' translator
comment to the Enable button label
- keybindingEditing.test.ts: fix test title grammar (a user)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Always enable system-wide keybindings; drop the enablement setting
Removes the experimental `keyboard.enableSystemWideKeybindings` setting so the
feature is always active: any user keybinding with "systemWide": true is a
candidate. The one-time confirmation dialog is retained and now serves as the
opt-out - its Enable/Disable choice is persisted as a tri-state consent
(unset -> ask, granted -> register, denied -> stay off and never re-ask).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Make the first-run dialog an informational notice, not a permission prompt
The system-wide keybindings feature is always on, so the first-run dialog no
longer needs to grant/deny permission. Replace the Enable/Disable confirm dialog
with a single-button informational notice ("I Understand") shown once before the
first registration. Collapses the tri-state consent to a boolean acknowledged
flag; the feature has no decline path, so there is no stuck off-state.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
