microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-29 13:36:27 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

remove the last typescript-vscode-sh-plugin references

Browse Source
This commit is contained in:
Martin Aeschlimann
2022-02-01 14:47:41 +01:00
parent fc8a61280b
commit d971263085
2 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/typescript-language-features/extension.webpack.config.js
View File

@@ -14,9 +14,6 @@ module.exports = withDefaults({
resolve: {
mainFields: ['module', 'main']
},
externals: {
'typescript-vscode-sh-plugin': 'commonjs vscode' // used by build/lib/extensions to know what node_modules to bundle
},
entry: {
extension: './src/extension.ts',
}

8
extensions/typescript-language-features/src/languageFeatures/semanticTokens.ts
View File

@@ -33,11 +33,6 @@ export function register(
});
}
/**
* Prototype of a DocumentSemanticTokensProvider, relying on the experimental `encodedSemanticClassifications-full` request from the TypeScript server.
* As the results retured by the TypeScript server are limited, we also add a Typescript plugin (typescript-vscode-sh-plugin) to enrich the returned token.
* See https://github.com/aeschli/typescript-vscode-sh-plugin.
*/
class DocumentSemanticTokensProvider implements vscode.DocumentSemanticTokensProvider, vscode.DocumentRangeSemanticTokensProvider {
constructor(private readonly client: ITypeScriptServiceClient) {
@@ -111,10 +106,9 @@ class DocumentSemanticTokensProvider implements vscode.DocumentSemanticTokensPro
let tokenModifiers = 0;
let tokenType = getTokenTypeFromClassification(tsClassification);
if (tokenType !== undefined) {
// it's a classification as returned by the typescript-vscode-sh-plugin
tokenModifiers = getTokenModifierFromClassification(tsClassification);
} else {
// typescript-vscode-sh-plugin is not present
// an old TypeScript server that uses the original ExperimentalProtocol.ClassificationType's
tokenType = tokenTypeMap[tsClassification];
if (tokenType === undefined) {
continue;