microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-11 14:04:49 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Add "Click to view details" on extension list items' aria-labels (#51805)

Browse Source 
* Add "Click to view details" on extension list items' aria-labels

* Reword message
This commit is contained in:
Jackson Kearl
2018-06-21 17:01:37 -07:00
committed by Ramya Rao
parent 23f1fdcedc
commit 9dc98f3ff7
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts
View File

@@ -5,6 +5,7 @@
'use strict';
import { localize } from 'vs/nls';
import { append, $, addClass, removeClass, toggleClass } from 'vs/base/browser/dom';
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { Action } from 'vs/base/common/actions';
@@ -189,16 +190,20 @@ export class Renderer implements IPagedRenderer<IExtension, ITemplateData> {
private updateRecommendationStatus(extension: IExtension, data: ITemplateData) {
const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason();
let ariaLabel = extension.displayName + '. ';
if (!extRecommendations[extension.id.toLowerCase()]) {
data.root.setAttribute('aria-label', extension.displayName);
data.root.title = '';
removeClass(data.root, 'recommended');
data.root.title = '';
} else {
data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id]);
data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText;
addClass(data.root, 'recommended');
ariaLabel += extRecommendations[extension.id.toLowerCase()].reasonText + ' ';
data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText;
}
ariaLabel += localize('viewExtensionDetailsAria', "Press enter for extension details.");
data.root.setAttribute('aria-label', ariaLabel);
}
disposeTemplate(data: ITemplateData): void {