microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-29 22:20:49 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Fixes #19436: Add support to edit the php executable path as a non sharable workspace setting

Browse Source
This commit is contained in:
Dirk Baeumer
2017-01-30 17:12:02 +01:00
parent 6a4016f1c6
commit 9dc95af517
1 changed files with 31 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
extensions/php/src/phpMain.ts
View File

@@ -53,13 +53,13 @@ export function activate(context: vscode.ExtensionContext): any {
let settingsExecutablePath = readLocalExecutableSetting();
if (settingsExecutablePath) {
migrateExecutablePath(settingsExecutablePath).then((value) => {
context.workspaceState.update(MigratedKey, true);
// User has pressed escape;
if (!value) {
// activate the validator with the current settings.
validator.activate(context.subscriptions);
return;
}
context.workspaceState.update(MigratedKey, true);
context.workspaceState.update(PathKey, value);
validator.updateWorkspaceExecutablePath(value, false);
validator.activate(context.subscriptions);
@@ -121,12 +121,38 @@ function getExecutablePath(context: vscode.ExtensionContext): string {
}
function migrateExecutablePath(settingsExecutablePath: string): Thenable<string> {
return vscode.window.showInputBox(
return vscode.window.showInformationMessage(
localize('php.migrateWorkspaceSetting', 'Do you want to use {0} as your future PHP executable path?', settingsExecutablePath),
{
prompt: localize('php.migrateExecutablePath', 'Use the above path as the PHP executable path?'),
value: settingsExecutablePath
title: localize('php.yes', 'Yes'),
id: 'yes'
},
{
title: localize('php.edit', 'Edit'),
id: 'edit'
},
{
title: localize('php.more', 'Learn More'),
id: 'more'
}
);
).then((selected) => {
if (!selected) {
return undefined;
}
if (selected.id === 'yes') {
return settingsExecutablePath;
} else if (selected.id === 'edit') {
return vscode.window.showInputBox(
{
prompt: localize('php.migrateExecutablePath', 'Use the above path as the PHP executable path?'),
value: settingsExecutablePath
}
);
} else if (selected.id === 'more') {
vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://go.microsoft.com/fwlink/?linkid=839919'));
return undefined;
}
});
}
function readLocalExecutableSetting(): string {