microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-09 08:26:39 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Move state check ahead to ensure stale docs are not made visible #29468

Browse Source
This commit is contained in:
Ramya Achutha Rao
2017-06-26 10:14:25 -07:00
parent 8ace8efaf9
commit 99ffa6afcf
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/editor/contrib/suggest/browser/suggestWidget.ts
View File

@@ -850,6 +850,10 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
this.editor.layoutContentWidget(this);
this.telemetryService.publicLog('suggestWidget:collapseDetails', this.editor.getTelemetryData());
} else {
if (this.state !== State.Open && this.state !== State.Details) {
return;
}
this.updateExpandDocsSetting(true);
this.showDetails();
this.telemetryService.publicLog('suggestWidget:expandDetails', this.editor.getTelemetryData());
@@ -858,13 +862,10 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
}
showDetails(): void {
if (this.state !== State.Open && this.state !== State.Details) {
return;
}
this.expandSideOrBelow();
show(this.details.element);
this.renderDetails();
this.details.render(this.list.getFocusedElements()[0]);
this.details.element.style.maxHeight = this.maxWidgetHeight + 'px';
// Reset margin-top that was set as Fix for #26416
@@ -980,14 +981,6 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
}
}
private renderDetails(): void {
if (this.state === State.Details || this.state === State.Open) {
this.details.render(this.list.getFocusedElements()[0]);
} else {
this.details.render(null);
}
}
// Heights
private get maxWidgetHeight(): number {