microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-05 08:42:37 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Disable non syntax errors in files that don't have semantic capabilities (#134175)

Browse Source 
If we're on a host that supports semantic checking, but in a file that doesn't support semantic errors, we currently don't want to report semantic errors since these will likely complain about imports and other undefined symols
This commit is contained in:
Matt Bierner
2021-10-04 08:11:16 -07:00
committed by GitHub
parent 48272059d9
commit 9990843822
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/typescript-language-features/src/languageProvider.ts
View File

@@ -9,6 +9,7 @@ import { CommandManager } from './commands/commandManager';
import { DiagnosticKind } from './languageFeatures/diagnostics';
import FileConfigurationManager from './languageFeatures/fileConfigurationManager';
import { CachedResponse } from './tsServer/cachedResponse';
import { ClientCapability } from './typescriptService';
import TypeScriptServiceClient from './typescriptServiceClient';
import { Disposable } from './utils/dispose';
import { DocumentSelector } from './utils/documentSelector';
@@ -127,6 +128,10 @@ export default class LanguageProvider extends Disposable {
}
public diagnosticsReceived(diagnosticsKind: DiagnosticKind, file: vscode.Uri, diagnostics: (vscode.Diagnostic & { reportUnnecessary: any, reportDeprecated: any })[]): void {
if (diagnosticsKind !== DiagnosticKind.Syntax && !this.client.hasCapabilityForResource(file, ClientCapability.Semantic)) {
return;
}
const config = vscode.workspace.getConfiguration(this.id, file);
const reportUnnecessary = config.get<boolean>('showUnused', true);
const reportDeprecated = config.get<boolean>('showDeprecated', true);