microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-09 09:24:12 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Fixes #29771: Customizing a TypeScript build task should include the used ProblemMatcher

Browse Source
This commit is contained in:
Dirk Baeumer
2017-07-12 16:39:46 +02:00
parent 91637e06fd
commit 969ffcb995
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
View File

@@ -1033,6 +1033,9 @@ class TaskService extends EventEmitter implements ITaskService {
let identifier: TaskConfig.TaskIdentifier = Objects.assign(Object.create(null), task.defines);
delete identifier['_key'];
Object.keys(identifier).forEach(key => toCustomize[key] = identifier[key]);
if (task.problemMatchers && task.problemMatchers.length > 0 && Types.isStringArray(task.problemMatchers)) {
toCustomize.problemMatcher = task.problemMatchers;
}
}
if (!toCustomize) {
return TPromise.as(undefined);
@@ -1045,7 +1048,7 @@ class TaskService extends EventEmitter implements ITaskService {
}
}
} else {
if (task.problemMatchers === void 0 || task.problemMatchers.length === 0) {
if (toCustomize.problemMatcher === void 0 && task.problemMatchers === void 0 || task.problemMatchers.length === 0) {
toCustomize.problemMatcher = [];
}
}