mirror of
https://github.com/microsoft/vscode.git
synced 2026-04-11 13:03:20 -05:00
sessions - clarify instructions around compiling and testing (#299255)
This commit is contained in:
2
.github/copilot-instructions.md
vendored
2
.github/copilot-instructions.md
vendored
@@ -58,7 +58,7 @@ MANDATORY: Always check for compilation errors before running any tests or valid
|
||||
### TypeScript compilation steps
|
||||
- If the `#runTasks/getTaskOutput` tool is available, check the `VS Code - Build` watch task output for compilation errors. This task runs `Core - Build` and `Ext - Build` to incrementally compile VS Code TypeScript sources and built-in extensions. Start the task if it's not already running in the background.
|
||||
- If the tool is not available (e.g. in CLI environments) and you only changed code under `src/`, run `npm run compile-check-ts-native` after making changes to type-check the main VS Code sources (it validates `./src/tsconfig.json`).
|
||||
- If you changed built-in extensions under `extensions/` and the tool is not available, run the corresponding gulp task `gulp compile-extensions` instead so that TypeScript errors in extensions are also reported.
|
||||
- If you changed built-in extensions under `extensions/` and the tool is not available, run the corresponding gulp task `npm run gulp compile-extensions` instead so that TypeScript errors in extensions are also reported.
|
||||
- For TypeScript changes in the `build` folder, you can simply run `npm run typecheck` in the `build` folder.
|
||||
|
||||
### TypeScript validation steps
|
||||
|
||||
4
.github/skills/sessions/SKILL.md
vendored
4
.github/skills/sessions/SKILL.md
vendored
@@ -272,7 +272,9 @@ Views and contributions that should only appear in the agent sessions window (no
|
||||
|
||||
1. Run `npm run compile-check-ts-native` to run a repo-wide TypeScript compilation check (including `src/vs/sessions/`). This is a fast way to catch TypeScript errors introduced by your changes.
|
||||
2. Run `npm run valid-layers-check` to verify layering rules are not violated.
|
||||
3. Run tests under `src/vs/sessions/test/` to confirm nothing is broken.
|
||||
3. Use `scripts/test.sh` (or `scripts\test.bat` on Windows) for unit tests (add `--grep <pattern>` to filter tests)
|
||||
|
||||
**Important** do not run `tsc` to check for TypeScript errors always use above methods to validate TypeScript changes in `src/vs/**`.
|
||||
|
||||
### 10.3 Layout Changes
|
||||
|
||||
|
||||
Reference in New Issue
Block a user