microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 00:21:38 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Remove unnecessary return in tab close

Browse Source
This commit is contained in:
Logan Ramos
2022-03-18 17:28:34 -04:00
parent eb97cfdf6d
commit 8d99738d84
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts
View File

@@ -489,7 +489,7 @@ suite('vscode API - window', () => {
// Function to acquire the active tab within the active group
const getActiveTabInActiveGroup = () => {
const activeGroup = window.tabGroups.groups.filter(group => group.isActive)[0];
return activeGroup.activeTab;
return activeGroup?.activeTab;
};
await window.showTextDocument(docA, { viewColumn: ViewColumn.One, preview: false });
@@ -514,8 +514,7 @@ suite('vscode API - window', () => {
await commands.executeCommand('workbench.action.closeActiveEditor');
await commands.executeCommand('workbench.action.closeActiveEditor');
// TODO @lramos15 fix this failing piece
//assert.ok(!getActiveTabInActiveGroup());
assert.ok(!getActiveTabInActiveGroup());
});
/*

1
src/vs/workbench/api/browser/mainThreadEditorTabs.ts
View File

@@ -213,7 +213,6 @@ export class MainThreadEditorTabs implements MainThreadEditorTabsShape {
if (this._tabGroupModel[i].groupId === group.id) {
this._tabGroupModel.splice(i, 1);
this._groupLookup.delete(group.id);
return;
}
}
}