microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-30 06:56:29 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

cli: bubble error from setup to the remote server (#210967)

Browse Source 
cli: bubble error from setup to the remote server logs
This commit is contained in:
Connor Peet
2024-04-22 14:57:44 -07:00
committed by GitHub
parent 3ea914bb70
commit 85178f0fb4
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cli/src/tunnels/code_server.rs
View File

@@ -407,7 +407,8 @@ impl<'a> ServerBuilder<'a> {
&self.server_params.release.commit,
);
self.launcher_paths
let result = self
.launcher_paths
.server_cache
.create(name, |target_dir| async move {
let tmpdir =
@@ -460,7 +461,12 @@ impl<'a> ServerBuilder<'a> {
Ok(())
})
.await?;
.await;
if let Err(e) = result {
error!(self.logger, "Error installing server: {}", e);
return Err(e);
}
debug!(self.logger, "Server setup complete");
@@ -607,7 +613,9 @@ impl<'a> ServerBuilder<'a> {
// Partial fix: https://github.com/microsoft/vscode/pull/184621
#[cfg(target_os = "windows")]
let cmd = cmd.creation_flags(
winapi::um::winbase::CREATE_NO_WINDOW | winapi::um::winbase::CREATE_NEW_PROCESS_GROUP | winapi::um::winbase::CREATE_BREAKAWAY_FROM_JOB,
winapi::um::winbase::CREATE_NO_WINDOW
| winapi::um::winbase::CREATE_NEW_PROCESS_GROUP
| winapi::um::winbase::CREATE_BREAKAWAY_FROM_JOB,
);
let child = cmd