microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-10 16:58:55 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Clean up onTypesInstallerInitializationFailed

Browse Source 
- Convert to async
- don't require using inline type with id
This commit is contained in:
Matt Bierner
2020-04-27 16:42:45 -07:00
parent 2e44999bd4
commit 686ad17217
1 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
extensions/typescript-language-features/src/utils/typingsStatus.ts
View File

@@ -96,32 +96,24 @@ export class AtaProgressReporter extends Disposable {
}
}
private onTypesInstallerInitializationFailed() {
interface MyMessageItem extends vscode.MessageItem {
id: number;
}
private async onTypesInstallerInitializationFailed() {
const config = vscode.workspace.getConfiguration('typescript');
if (vscode.workspace.getConfiguration('typescript').get<boolean>('check.npmIsInstalled', true)) {
vscode.window.showWarningMessage<MyMessageItem>(
if (config.get<boolean>('check.npmIsInstalled', true)) {
const dontShowAgain: vscode.MessageItem = {
title: localize('typesInstallerInitializationFailed.doNotCheckAgain', "Don't Show Again"),
};
const selected = await vscode.window.showWarningMessage(
localize(
'typesInstallerInitializationFailed.title',
"Could not install typings files for JavaScript language features. Please ensure that NPM is installed or configure 'typescript.npm' in your user settings. Click [here]({0}) to learn more.",
'https://go.microsoft.com/fwlink/?linkid=847635'
), {
title: localize('typesInstallerInitializationFailed.doNotCheckAgain', "Don't Show Again"),
id: 1
),
dontShowAgain);
if (selected === dontShowAgain) {
config.update('check.npmIsInstalled', false, true);
}
).then(selected => {
if (!selected) {
return;
}
switch (selected.id) {
case 1:
const tsConfig = vscode.workspace.getConfiguration('typescript');
tsConfig.update('check.npmIsInstalled', false, true);
break;
}
});
}
}
}