microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-10 16:58:55 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

drop octicon usage in suggest

Browse Source 
fixes Microsoft/monaco-editor#52
This commit is contained in:
Joao Moreno
2016-08-12 11:57:27 +02:00
parent be4b9711f6
commit 4dc127e963
4 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/vs/editor/contrib/suggest/browser/back.svg Normal file
View File

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="-0.994 0 16 16" enable-background="new -0.994 0 16 16"><path fill="#808080" d="M13 6c0 1.461-.636 2.846-1.746 3.797l-5.584 4.951-1.324-1.496 5.595-4.962c.678-.582 1.061-1.413 1.061-2.29 0-1.654-1.345-3-2.997-3-.71 0-1.399.253-1.938.713l-1.521 1.287h2.448l-1.998 2h-3.996v-4l1.998-2v2.692l1.775-1.504c.899-.766 2.047-1.188 3.232-1.188 2.754 0 4.995 2.243 4.995 5z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 443 B

1
src/vs/editor/contrib/suggest/browser/info.svg Normal file
View File

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16"><path d="M8 1c-3.865 0-7 3.135-7 7s3.135 7 7 7 7-3.135 7-7-3.135-7-7-7zm1 12h-2v-7h2v7zm0-8h-2v-2h2v2z" fill="#1BA1E2"/><path d="M7 6h2v7h-2v-7zm0-1h2v-2h-2v2z" fill="#fff"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 243 B

8
src/vs/editor/contrib/suggest/browser/suggest.css
View File

@@ -69,6 +69,10 @@
.monaco-editor .suggest-widget .monaco-list .monaco-list-row .docs > .docs-details {
font-size: 1.4em;
opacity: 0.6;
width: 14px;
height: 14px;
background-image: url('./info.svg');
background-size: 14px;
}
.monaco-editor .suggest-widget .details > .header > .go-back,
@@ -176,6 +180,10 @@
.monaco-editor .suggest-widget .details > .header > .go-back {
cursor: pointer;
opacity: 0.6;
width: 14px;
height: 14px;
background-image: url('./back.svg');
background-size: 14px;
}
.monaco-editor .suggest-widget .details > .header > .go-back:hover {

4
src/vs/editor/contrib/suggest/browser/suggestWidget.ts
View File

@@ -71,7 +71,7 @@ class Renderer implements IRenderer<CompletionItem, ISuggestionTemplateData> {
const docs = append(text, $('.docs'));
data.documentation = append(docs, $('span.docs-text'));
data.documentationDetails = append(docs, $('span.docs-details.octicon.octicon-info'));
data.documentationDetails = append(docs, $('span.docs-details'));
data.documentationDetails.title = nls.localize('readMore', "Read More...{0}", this.triggerKeybindingLabel);
const configureFont = () => {
@@ -211,7 +211,7 @@ class SuggestionDetails {
const header = append(this.el, $('.header'));
this.title = append(header, $('span.title'));
this.back = append(header, $('span.go-back.octicon.octicon-mail-reply'));
this.back = append(header, $('span.go-back'));
this.back.title = nls.localize('goback', "Go back");
this.body = $('.body');