Implicitly activate only main language contribs (#179287)

This commit is contained in:
Joyce Er
2023-04-06 01:12:17 -07:00
committed by GitHub
parent 499fb52ae8
commit 413f98e499
2 changed files with 3 additions and 2 deletions

View File

@@ -525,7 +525,8 @@ function parseImplicitActivationEvents(tree: JsonNode): Set<string> {
const languageContributions = findNodeAtLocation(tree, ['contributes', 'languages']);
languageContributions?.children?.forEach(child => {
const id = findNodeAtLocation(child, ['id']);
if (id && id.type === 'string') {
const configuration = findNodeAtLocation(child, ['configuration']);
if (id && id.type === 'string' && configuration && configuration.type === 'string') {
activationEvents.add(`onLanguage:${id.value}`);
}
});

View File

@@ -107,7 +107,7 @@ export const languagesExtPoint: IExtensionPoint<IRawLanguageExtensionPoint[]> =
},
activationEventsGenerator: (languageContributions, result) => {
for (const languageContribution of languageContributions) {
if (languageContribution.id) {
if (languageContribution.id && languageContribution.configuration) {
result.push(`onLanguage:${languageContribution.id}`);
}
}