microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-10 16:58:55 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Show the devcontainer label value specified in portsAttributes within the port notification instead of "your application" (#200667)

Browse Source 
Fixes #192684
This commit is contained in:
Alex Ross
2023-12-12 17:53:31 +00:00
committed by GitHub
parent dc3b949a17
commit 40f2a588ce
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vs/workbench/contrib/remote/browser/remoteExplorer.ts
View File

@@ -385,8 +385,11 @@ class OnAutoForwardedAction extends Disposable {
});
}
private basicMessage(tunnel: RemoteTunnel) {
return nls.localize('remote.tunnelsView.automaticForward', "Your application running on port {0} is available. ",
private async basicMessage(tunnel: RemoteTunnel) {
const properties = await this.remoteExplorerService.tunnelModel.getAttributes([{ host: tunnel.tunnelRemoteHost, port: tunnel.tunnelRemotePort }], false);
const label = properties?.get(tunnel.tunnelRemotePort)?.label;
return nls.localize('remote.tunnelsView.automaticForward', "Your application{0} running on port {1} is available. ",
label ? ` (${label})` : '',
tunnel.tunnelRemotePort);
}
@@ -402,7 +405,7 @@ class OnAutoForwardedAction extends Disposable {
}
this.lastNotification?.close();
let message = this.basicMessage(tunnel);
let message = await this.basicMessage(tunnel);
const choices = [this.openBrowserChoice(tunnel)];
if (!isWeb || openPreviewEnabledContext.getValue(this.contextKeyService)) {
choices.push(this.openPreviewChoice(tunnel));
@@ -481,7 +484,7 @@ class OnAutoForwardedAction extends Disposable {
this.lastNotification?.close();
this.lastShownPort = newTunnel.tunnelRemotePort;
this.lastNotification = this.notificationService.prompt(Severity.Info,
this.basicMessage(newTunnel) + this.linkMessage(),
await this.basicMessage(newTunnel) + this.linkMessage(),
[this.openBrowserChoice(newTunnel), this.openPreviewChoice(tunnel)],
{ neverShowAgain: { id: 'remote.tunnelsView.autoForwardNeverShow', isSecondary: true } });
this.lastNotification.onDidClose(() => {