microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-13 21:47:12 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Merge pull request #191602 from microsoft/tyriar/190350

Browse Source 
Add GNU style link 'r-c.ce', 'r.c-re.ce'
This commit is contained in:
Daniel Imms
2023-08-29 07:35:50 -07:00
committed by GitHub
parent 7afc799159 fdb265d221
commit 3957463200
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts
View File

@@ -63,9 +63,11 @@ function generateLinkSuffixRegex(eolOnly: boolean) {
// The comments in the regex below use real strings/numbers for better readability, here's
// the legend:
// - Path = foo
// - Row = 339
// - Col = 12
// - Path = foo
// - Row = 339
// - Col = 12
// - RowEnd = 341
// - ColEnd = 14
//
// These all support single quote ' in the place of " and [] in the place of ()
const lineAndColumnRegexClauses = [
@@ -78,7 +80,9 @@ function generateLinkSuffixRegex(eolOnly: boolean) {
// "foo",339
// "foo",339:12
// "foo",339.12
`(?::| |['"],)${r()}([:.]${c()})?` + eolSuffix,
// "foo",339.12-14
// "foo",339.12-341.14
`(?::| |['"],)${r()}([:.]${c()}(?:-(?:${re()}\.)?${ce()})?)?` + eolSuffix,
// The quotes below are optional [#171652]
// "foo", line 339 [#40468]
// "foo", line 339, col 12

2
src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts
View File

@@ -47,6 +47,8 @@ const testLinks: ITestLink[] = [
{ link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false },
{ link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true },
{ link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true },
{ link: 'foo 339.12-14', prefix: undefined, suffix: ' 339.12-14', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true },
{ link: 'foo 339.12-341.14', prefix: undefined, suffix: ' 339.12-341.14', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true },
// Double quotes
{ link: '"foo",339', prefix: '"', suffix: '",339', hasRow: true, hasCol: false },