Merge pull request #20966 from IFTTT/fix-monaco-editor-371

Remove dependency on window.event in ListView
This commit is contained in:
João Moreno
2017-02-21 09:14:29 +01:00
committed by GitHub

View File

@@ -233,16 +233,20 @@ export class ListView<T> implements IDisposable {
let domNode = this.domNode;
if (MouseEventTypes.indexOf(type) > -1) {
handler = e => this.fireScopedEvent(userHandler, this.getItemIndexFromMouseEvent(e));
handler = e => this.fireScopedEvent(e, userHandler, this.getItemIndexFromMouseEvent(e));
} else if (type === TouchEventType.Tap) {
domNode = this.rowsContainer;
handler = e => this.fireScopedEvent(userHandler, this.getItemIndexFromGestureEvent(e));
handler = e => this.fireScopedEvent(e, userHandler, this.getItemIndexFromGestureEvent(e));
}
return DOM.addDisposableListener(domNode, type, handler, useCapture);
}
private fireScopedEvent(handler: (event: any) => void, index: number) {
private fireScopedEvent(
event: any,
handler: (event: any) => void,
index: number
) {
if (index < 0) {
return;
}
@@ -255,11 +259,11 @@ export class ListView<T> implements IDisposable {
this.render(e.scrollTop, e.height);
}
private onTouchChange(e: GestureEvent): void {
private onTouchChange(event: GestureEvent): void {
event.preventDefault();
event.stopPropagation();
this.scrollTop -= e.translationY;
this.scrollTop -= event.translationY;
}
// Util