microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-12 22:08:04 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

fix tab order for hidden status element when a message shows

Browse Source 
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4039
This commit is contained in:
Johannes
2023-04-27 17:50:40 +02:00
parent 726b7f51e0
commit 2a557e7102
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditor.css
View File

@@ -106,6 +106,10 @@
margin-left: auto;
}
.monaco-editor .interactive-editor .status .label.hidden {
display: none;
}
.monaco-editor .interactive-editor .markdownMessage {
padding-top: 10px;
}

1
src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorController.ts
View File

@@ -569,6 +569,7 @@ export class InteractiveEditorController implements IEditorContribution {
this._messageReply = reply.message.value;
this._requestPrompt = request.prompt;
const renderedMarkdown = renderMarkdown(reply.message, { inline: true });
this._zone.widget.updateStatus('');
this._zone.widget.updateMarkdownMessage(renderedMarkdown.element);
this._currentSession.addResponse(reply);
continue;

6
src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorWidget.ts
View File

@@ -120,7 +120,7 @@ class InteractiveEditorWidget {
h('div.previewCreate.hidden@previewCreate'),
h('div.status@status', [
h('div.actions.hidden@statusToolbar'),
h('div.label@statusLabel')
h('div.label.hidden@statusLabel')
]),
h('div.markdownMessage.hidden@markdownMessage', [
h('div.message@message'),
@@ -377,7 +377,6 @@ class InteractiveEditorWidget {
updateMarkdownMessage(message: Node) {
reset(this._elements.message, message);
this._elements.statusLabel.innerText = '';
this._elements.markdownMessage.classList.toggle('hidden', false);
this._onDidChangeHeight.fire();
}
@@ -393,9 +392,9 @@ class InteractiveEditorWidget {
} else if (!isTempMessage && !ops.keepMessage) {
this._elements.markdownMessage.classList.toggle('hidden', true);
}
this._elements.status.classList.toggle('hidden', false);
reset(this._elements.statusLabel, message);
this._elements.statusLabel.className = `label ${(ops.classes ?? []).join(' ')}`;
this._elements.statusLabel.classList.toggle('hidden', !message);
if (isTempMessage) {
this._elements.statusLabel.dataset['state'] = 'temp';
} else {
@@ -407,6 +406,7 @@ class InteractiveEditorWidget {
reset() {
this._ctxInputEmpty.reset();
reset(this._elements.statusLabel);
this._elements.statusLabel.classList.toggle('hidden', true);
this._elements.statusToolbar.classList.add('hidden');
this.hideCreatePreview();
this.hideEditsPreview();