microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-11 05:30:03 -05:00
Code Issues Packages Projects Releases 177 Wiki Activity

Split useCodeSnippetsOnMethodSuggest into js and ts specific settings

Browse Source 
Splits the old setting into `javascript.suggest.insertParametersForFunctionCalls` and `typescriptscript.suggest.insertParametersForFunctionCalls`

Fixes #58385
This commit is contained in:
Matt Bierner
2018-09-11 11:20:38 -07:00
parent cb1768b61f
commit 1ff383c64f
3 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/typescript-language-features/package.json
View File

@@ -145,6 +145,19 @@
"type": "boolean",
"default": false,
"description": "%typescript.useCodeSnippetsOnMethodSuggest.dec%",
"scope": "resource",
"deprecationMessage": "%typescript.useCodeSnippetsOnMethodSuggest.deprecationMessage%"
},
"javascript.suggest.insertParametersForFunctionCalls": {
"type": "boolean",
"default": false,
"description": "%configuration.suggest.insertParametersForFunctionCalls%",
"scope": "resource"
},
"typescript.suggest.insertParametersForFunctionCalls": {
"type": "boolean",
"default": false,
"description": "%configuration.suggest.insertParametersForFunctionCalls%",
"scope": "resource"
},
"typescript.reportStyleChecksAsWarnings": {

2
extensions/typescript-language-features/package.nls.json
View File

@@ -4,6 +4,8 @@
"reloadProjects.title": "Reload Project",
"configuration.typescript": "TypeScript",
"typescript.useCodeSnippetsOnMethodSuggest.dec": "Complete functions with their parameter signature.",
"typescript.useCodeSnippetsOnMethodSuggest.deprecationMessage": "Please use the new `javascript.suggest.insertParametersForFunctionCalls` and `typescriptscript.suggest.insertParametersForFunctionCalls` settings.",
"configuration.suggest.insertParametersForFunctionCalls": "Complete functions with their parameter signature.",
"typescript.tsdk.desc": "Specifies the folder path containing the tsserver and lib*.d.ts files to use.",
"typescript.disableAutomaticTypeAcquisition": "Disables automatic type acquisition.",
"typescript.tsserver.log": "Enables logging of the TS server to a file. This log can be used to diagnose TS Server issues. The log may contain file paths, source code, and other potentially sensitive information from your project.",

5
extensions/typescript-language-features/src/features/completions.ts
View File

@@ -241,7 +241,8 @@ interface CompletionConfiguration {
}
namespace CompletionConfiguration {
export const useCodeSnippetsOnMethodSuggest = 'useCodeSnippetsOnMethodSuggest';
export const useCodeSnippetsOnMethodSuggest = 'suggest.insertParametersForFunctionCalls';
export const useCodeSnippetsOnMethodSuggest_deprecated = 'useCodeSnippetsOnMethodSuggest';
export const nameSuggestions = 'suggest.names';
export const nameSuggestions_deprecated = 'nameSuggestions';
export const pathSuggestions = 'suggest.paths';
@@ -258,7 +259,7 @@ namespace CompletionConfiguration {
const typeScriptConfig = vscode.workspace.getConfiguration('typescript', resource);
return {
useCodeSnippetsOnMethodSuggest: typeScriptConfig.get<boolean>(CompletionConfiguration.useCodeSnippetsOnMethodSuggest, false),
useCodeSnippetsOnMethodSuggest: config.get<boolean>(CompletionConfiguration.useCodeSnippetsOnMethodSuggest, typeScriptConfig.get<boolean>(CompletionConfiguration.useCodeSnippetsOnMethodSuggest_deprecated, false)),
pathSuggestions: config.get<boolean>(CompletionConfiguration.pathSuggestions, true),
autoImportSuggestions: config.get<boolean>(CompletionConfiguration.autoImportSuggestions, typeScriptConfig.get<boolean>(CompletionConfiguration.autoImportSuggestions_deprecated, true)),
nameSuggestions: config.get<boolean>(CompletionConfiguration.nameSuggestions, vscode.workspace.getConfiguration('javascript', resource).get(CompletionConfiguration.nameSuggestions_deprecated, true))