Implements `WslcSetProcessSettingsIOCallback` and the use of those inputs for both initial and subsequent processes. A new thread is started to run the `MultiHandleWait` and the container/process objects hold a `shared_ptr` reference to it. The caller must keep one of the objects alive for the callback thread to keep working.
* Save state
* Rethink image parsing to correctly handle different reference formats
* Foramt
* Fix merge
* Apply PR feedback
* Format
* Apply PR feedback
* Use a regex based parser
* Format
* Reset the test session after termination
* Fix test case
* Apply PR feedback
* Move standard filesystem mounts to WSLA init startup
Move devtmpfs, proc, sysfs, devpts, and cgroup2 mounts from the
Windows-side ConfigureInitialMounts() to WSLAEntryPoint() in the
Linux init daemon. These mounts don't depend on host communication
and can be performed earlier during init startup.
Inline the remaining VHD-dependent mounts (root overlay and kernel
modules) directly into Initialize() and remove the now-unnecessary
ConfigureInitialMounts method.
* pr feedback
* MS_SHARED helper
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* test: enable virtiofs tests and enable WSLG during testing (#14387)
* test: enable virtiofs tests and enable WSLG during testing
* test fix
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* chore(distributions): Almalinux auto-update - 20260311 14:52:02 (#14404)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix CVE-2026-26127: bump .NET runtime from 10.0.0 to 10.0.4 (#14421)
Addresses Dependabot alerts #10 and #11. The Microsoft.NETCore.App.Runtime
packages (win-x64 and win-arm64) at version 10.0.0 are vulnerable to a
denial of service via out-of-bounds read when decoding malformed Base64Url
input (CVSS 7.5 High). Bumped to 10.0.4 which includes the fix.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Notice change from build: 141806547 (#14423)
Co-authored-by: WSL notice <noreply@microsoft.com>
* Ship initrd.img in MSI using build-time generation via powershell script (#14424)
* Ship initrd.img in MSI using build-time generation via tar.exe
Replace the install-time CreateInitrd/RemoveInitrd custom actions with a
build-time step that generates initrd.img using the Windows built-in
tar.exe (libarchive/bsdtar) and ships it directly in the MSI.
The install-time approach had a race condition: wsl.exe could launch
before the CreateInitrd custom action completed, causing
ERROR_FILE_NOT_FOUND for initrd.img.
Changes:
- Add CMake custom command to generate initrd.img via tar.exe --format=newc
- Add initrd.img as a regular file in the MSI tools component
- Remove CreateInitrd/RemoveInitrd custom actions from WiX, DllMain,
and wslinstall.def
- Remove CreateCpioInitrd helper and its tests (no longer needed)
- Update pipeline build targets to build initramfs instead of init
* pr feedback
* more pr feedback
* switch to using a powershell script instead of tar.exe
* powershell script feedback
* hopefully final pr feedback
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* virtiofs: update logic so querying virtiofs mount source does not require a call to the service (#14380)
* virtiofs: update logic so querying virtiofs mount source does not require a call to the service
* more pr feedback
* use std::filesystem::read_symlink
* pr feedback and use canonical path in virtiofs symlink
* make sure canonical path is always used
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* virtio networking: add support for ipv6 (#14350)
* VirtioProxy: Add IPv6 address, gateway, and route support
- Add PreferredIpv6Address field and GetBestGatewayV6* methods to NetworkSettings
- Extend GetHostEndpointSettings() to discover IPv6 unicast address and gateway
- Add UpdateIpv6Address() using ModifyGuestEndpointSettingRequest<IPAddress>
- Push IPv6 default route to guest via UpdateDefaultRoute(AF_INET6)
- Remove AF_INET6 early return in ModifyOpenPorts, use INETADDR_PORT()
- Add EndpointRoute::DefaultRoute() static factory
- Pass client_ip_ipv6 in devicehost options (not yet parsed by devicehost)
- Remove gateway_ip from devicehost options (only needed for DHCP)
- Include IPv6 DNS servers in non-tunneling DNS settings
- Add ConfigurationV6 and DnsResolutionAAAA tests
* cleanup and add more ipv6 tests
* added test coverage and minor updates
* clang format
* pr feedback
* format source
* pr feedback
* test fixes
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Track `bind` syscall when port is 0 (#14333)
* Initial work
* .
* pr feedback and add unit test
* minor tweaks an fix use after free in logging statement
* implement PR feedback
* hopefully final pr feedback
* pr feedback in test function
* Address PR feedback: add try/catch to TrackPort and PortZeroBind queue push
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Add iptables to list of apps to install in WSL (#14459)
There were instructions already on how to install tcpdump in WSL, but
iptables are also needed for the log collection to be complete, so this
PR adds instructions on how to also install iptables.
Co-authored-by: Andre Muezerie <andremue@linux.microsoft.com>
* Update Microsoft.WSL.DeviceHost to version 1.1.39-0 (#14460)
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Moves all Ubuntu distros to the tar-based format (#14463)
* Move all supported Ubuntu images to the new format
We backported the build pipeline so all current LTSes come out in the new tar-based format
* Remove the appx based distros
All WSL users can run tar-based distros by now, right?
There is no benefit in maintaining both formats.
* Enable DNS tunneling for VirtioProxy networking mode (#14461)
- Allow VirtioProxy to keep EnableDnsTunneling=true in config, but clear
socket-specific options (BestEffortDnsParsing, DnsTunnelingIpAddress)
- Suppress dedicated DNS tunneling hvsocket for VirtioProxy; tunneling
is handled through the VirtioNetworking device host instead
- Set DnsTunneling flag on VirtioNetworkingFlags so the device host
knows to tunnel DNS
- Expand SWIOTLB kernel cmdline to cover VirtioFs and VirtioProxy
- Bump DeviceHost package to 1.1.39-0
- Add VirtioProxy DNS test coverage for tunneling on/off
- Skip GuestPortIsReleasedV6 on Windows 10
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* test: disable LoopbackExplicit due to OS build 29555 regression (#14477)
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Refactor: trim unnecessary DLL deps from COMMON_LINK_LIBRARIES (#14426)
* Refactor: trim unnecessary DLL deps from COMMON_LINK_LIBRARIES
- Split MSI/Wintrust install functions from wslutil.cpp into install.cpp
- Remove MI.lib, wsldeps.lib, msi.lib, Wintrust.lib, computecore.lib,
computenetwork.lib, Iphlpapi.lib from COMMON_LINK_LIBRARIES
- Add per-target MSI_LINK_LIBRARIES, HCS_LINK_LIBRARIES, SERVICE_LINK_LIBRARIES
- Delay-load msi.dll and WINTRUST.dll for wsl.exe and wslg.exe
- Result: wslhost, wslrelay, wslcsdk, testplugin lose msi/wintrust startup imports;
wsl.exe and wslg.exe defer msi/wintrust loading until actually needed;
wslservice is the only target that imports computecore/computenetwork/Iphlpapi
* minor fixes to install.cpp that were caught during PR
* move to wsl::windows::common::install namespace
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* wslc: enable IPv6 and DNS tunneling for virtio proxy networking mode
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Co-authored-by: AlmaLinux Autobot <107999298+almalinuxautobot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Blue <OneBlue@users.noreply.github.com>
Co-authored-by: WSL notice <noreply@microsoft.com>
Co-authored-by: Daman Mulye <daman_mulye@hotmail.com>
Co-authored-by: Andre Muezerie <108841174+andremueiot@users.noreply.github.com>
Co-authored-by: Andre Muezerie <andremue@linux.microsoft.com>
Co-authored-by: Carlos Nihelton <carlos.santanadeoliveira@canonical.com>
If row[i].size() > m_widths[i], the unsigned subtraction wraps to a huge
value, causing std::wstring to allocate enormous memory or crash.
Clamp the padding to zero when the row value exceeds the column width.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Save state
* Save state
* Save state
* Save state
* Save state
* Fix last issues
* Format
* Save state
* Save state
* Save state
* Clear port status during shutdown
* Add checks for virtionet
* Cleanup before PR
* Keep track of port references
* Format
* Assign iterator
* Assign iterator
* Apply PR feedback
* Apply PR feedback
* Apply PR feedback
* Apply PR feedback
* Format
* Enforce read-only VirtioFS shares at the device host level
Pass the 'ro' option to AddGuestDevice when mounting a read-only
VirtioFS share, ensuring the device host enforces write protection
regardless of guest-side mount operations.
Updated DeviceHost package to 1.1.39-0. Added tests for read-only
mount enforcement via remount and unmount+remount.
* wslc: skip ejecting virtiofs flexiov device while hotplug issue is being fixed
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* Add session termination coverage for Export & Save
* clean up session termination test
* Skip delete-on-close during session termination
* Always use OpenAnonymousPipe in BlockingOperation
* Use unique_hfile in BlockingOperation
* Initial support for volume
* Clang format
* Clang format
* Revert
* Addressed comments
* Added more tests
* Added UT
* Added UT
* Added UT
* Added more tests
* CLang format
* CLang format
* Addressed comments
* Resolving copilot comments
* cLang format
* Resolving copilot comments
* Clang format
* fix test
* Clang format
* Addressed comments
* cleanup: remove wslaservice and combine with wslservice
* only call ClearWslaSessionsAndBlockNewInstances from ServiceStopped
---------
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Move both Import and Load options to use a shared file specification structure that can accept a path or HANDLE+length. Add image name to import options. Implement Import and Load using a shared path to normalize to HANDLE+length for runtime usage.
The throw keyword was accidentally dropped, causing the error to be
silently discarded when getxattr fails to read the socket protocol.
This corrupts port tracking state used by the mirrored-mode loopback
relay.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
The WI_ASSERT checking that LUN 0 maps to /dev/sda and LUN 1 maps to
/dev/sdb is not guaranteed after rapid VM create/destroy cycles. The
kernel SCSI device enumeration order can vary, and the code already
uses the paths returned by init rather than hardcoded device names.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Swaps the remaining functions to verb-noun and adds error strings to the functions that seem likely to need them (open to more/less if desired).
Improves the error string handling so that we initialize the output pointer to null and can capture the error string when appropriate in a more formal way.
Implements all but 6 of the remaining SDK APIs. Makes some changes to the header for alignment:
1. Enum naming / values for consistency with runtime
2. Use of `CONST` macro instead of `const` keyword directly
3. Make `WslcImageInfo` directly freeable by using a char array instead of pointer, reducing complexity for callers. Also removes values that the runtime does not provide to us.
Capture SocketAddress by value instead of by reference in the childLogic
lambda. When ForkType == Thread, the detached thread calls
childPid.set_value() before using SocketAddress on the next line. Once
set_value unblocks the parent, HandleMessageImpl can return and destroy
the stack-local SocketAddress before the thread reads it.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Standardize ShortDescription() strings to end with periods for
consistency. Complete truncated comment in ArgumentParser.cpp.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
DockerHTTPClient.cpp: Wrap std::stoul() in try-catch to handle malformed
Content-Length headers gracefully instead of crashing the session with an
unhandled exception.
ContainerEventTracker.cpp: Clamp event.size() to USHRT_MAX before
casting to UINT16 for TraceLoggingCountedString. Previously, events
larger than 64KB would wrap the size, causing TraceLogging to read an
incorrect number of bytes.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
The worker thread captures raw 'this' but can outlive the DmesgCollector
object. Restore shared_from_this() to extend the object lifetime, and
update member accesses to use Self-> instead of implicit this.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
exitMessage is dereferenced in WSL_LOG before the null check.
Move the log call inside the null-checked block.
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Improve chunk reader's handling of split buffers:
1. Only skips the initial `\r` or `\n` when `PendingBuffer` is empty ("between chunks")
2. Advances the buffer based on the amount read this time, not based on the total size of `PendingBuffer`
3. Checks for an empty header based on `PendingBuffer` size instead of the amount read this time
