Andrew Casey
eb5797fd36
Merge pull request #20211 from amcasey/GH20084
...
Update project on PackageInstalledResponse
2017-11-22 10:21:33 -08:00
Andrew Casey
5ed31cff8c
Use stricter types for event bodies
2017-11-21 16:38:58 -08:00
Andrew Casey
f483495408
Use {} instead of any to improve type checking
2017-11-21 16:24:05 -08:00
Andrew Casey
35545d4a0a
Update project on PackageInstalledResponse
...
As with `SetTypings`, new typings have been installed so the project
should be updated and the client should be notified (via event).
Changed PackageInstalledResponse from "event" to "action" for the sake
of explicitness.
Fixes #20084 .
2017-11-21 15:59:46 -08:00
Andrew Casey
39e6a00054
Unswap arguments
2017-11-21 15:59:45 -08:00
Andrew Casey
761c739824
Merge pull request #20181 from amcasey/TiRootPath
...
Correct project root path passed to Typings Installer
2017-11-21 10:39:28 -08:00
Andrew Casey
1793652373
Correct project root path passed to Typings Installer
...
`createInstallTypingsRequest` has its own logic for extracting the
project root path from the project name and it disagrees with the
versions in the project flavors. In particular, it only drops the last
component of the name if it exists. For folder projects and JS-only
contexts, this will not be the case, but the last entry should still be
dropped.
TL;DR: stop creating filewatchers for
"c:/foo/foo.csproj*jscontent/node_modules"
2017-11-20 18:56:27 -08:00
Andrew Casey
71e07df817
Check hasOwnProperty before copying property
2017-11-20 18:43:14 -08:00
Andrew Casey
9cbe4eb614
Convert legacy safe list keys to lowercase on construction
2017-11-20 18:30:28 -08:00
Bill Ticehurst
6c4c10c7cf
Merge pull request #20115 from Microsoft/dev/billti/port20109toMaster
...
Port #20109 to master
2017-11-17 21:03:17 -08:00
Arthur Ozga
65908ef8ba
Merge pull request #19864 from Microsoft/dev/aozgaa/eventPortTelemetry
...
Send events through a single stream
2017-11-17 20:22:57 -08:00
Arthur Ozga
d2cc4f15be
test overriding Session.event
2017-11-17 19:48:57 -08:00
Ryan Cavanaugh
574ceccf0a
Update editorServices.ts
...
Fix lint
2017-11-17 16:12:42 -08:00
Bill Ticehurst
805f191a57
Moved minified file exclusion
2017-11-17 14:39:33 -08:00
Bill Ticehurst
b244907074
Fixed internal safelist
2017-11-17 14:39:26 -08:00
Andy
e7adb1ce79
Bundle fileName with CodeActionCommand ( #19881 )
...
* Bundle fileName with CodeActionCommand
* Update test
* Fix API tests
* Add new overloads in services
* Fix overload
* Update API baselines
2017-11-17 14:16:38 -08:00
Arthur Ozga
890820b528
cleanup NodeTypingsInstaller
2017-11-16 19:19:05 -08:00
Arthur Ozga
8b0d3ab318
remove comments
2017-11-16 19:10:38 -08:00
Arthur Ozga
c098a5cf83
type event callback correctly
2017-11-16 19:06:08 -08:00
Arthur Ozga
49d92d844b
defer callback and remove handler object
2017-11-16 18:15:39 -08:00
Armando Aguirre
464ae31776
Merge pull request #20082 from armanio123/KendoOptionalMin
...
Modified Kendo regex to include -ui folders and files without min
2017-11-16 17:37:24 -08:00
Armando Aguirre
49c169a523
Fixed unbalanced parenthesis
2017-11-16 16:16:10 -08:00
Armando Aguirre
48aa83e13a
Modified Kendo regex to include -ui folders and files without min
2017-11-16 15:59:27 -08:00
Ryan Cavanaugh
a416826b64
Apply safelist exclusions even when include is not specified; recompute project contexts when installer reqs finish
2017-11-16 12:52:30 -08:00
Arthur Ozga
5c2fea4d4e
make eventSender required for TypingsInstaller
2017-11-15 19:49:34 -08:00
Arthur Ozga
a7822c550d
expose just eventSender
2017-11-15 19:39:02 -08:00
Arthur Ozga
d6c3a15ea6
Move event into IoSession
2017-11-15 18:51:25 -08:00
Arthur Ozga
005c86340f
move socketSender to IOSession
2017-11-15 13:12:48 -08:00
Arthur Ozga
93ff7ba2c5
lint more
2017-11-14 22:27:01 -08:00
Arthur Ozga
930be75e0c
lint
2017-11-14 18:14:15 -08:00
Arthur Ozga
6a910919ac
use arrow to capture this
2017-11-14 18:09:32 -08:00
Arthur Ozga
e341e52174
Merge branch 'master' into dev/aozgaa/eventPortTelemetry-IOSessionSocket
2017-11-14 16:50:54 -08:00
Arthur Ozga
bf8f9be677
expose event to overwrite in SessionOptions
...
* need to retain eventPort and canUseEvents arguments and functionality for backwards
compatibility.
2017-11-14 16:42:18 -08:00
Arthur Ozga
1746f4b3d3
factor out socket-event-sending
2017-11-14 15:10:44 -08:00
Ryan Cavanaugh
de7fbc041a
Merge pull request #19542 from RyanCavanaugh/fix19533
...
Exclude legacy safelist files in external projects
2017-11-10 15:28:35 -08:00
Andy
b94940525b
Allow applyCodeActionCommand to take an array ( #19870 )
...
* Allow applyCodeActionCommand to take an array
* Use this.host.newLine
2017-11-09 13:17:47 -08:00
Ryan Cavanaugh
b043edd61c
Merge
2017-11-09 12:42:37 -08:00
Arthur Ozga
9f991d375a
cleanup
2017-11-08 23:05:04 -08:00
Arthur Ozga
23da1cf822
send all events through common stream
2017-11-08 21:59:44 -08:00
Sheetal Nandi
fe40873664
Merge pull request #19786 from Microsoft/directoryRename
...
Handle the watch when folders are added/removed/renamed in wild card folder
2017-11-07 11:13:47 -08:00
Andy
57f247eff4
Add hyphen in completionEntryDetails-full ( #19808 )
2017-11-07 09:46:40 -08:00
Andy
bd2e97597d
Enable 'no-empty' tslint rule ( #19769 )
...
* Enable 'no-empty' tslint rule
* Fix bug
2017-11-07 09:22:28 -08:00
Ron Buckton
3f248ecfe1
Merge pull request #19452 from Microsoft/compareStrings
...
Clean up outdated string comparison logic
2017-11-06 18:48:15 -08:00
Andy
40efd1b3bd
Apply 'object-literal-key-quotes' tslint rule ( #19737 )
...
* Apply 'object-literal-key-quotes' tslint rule
* Convert to "consistent-as-needed"
2017-11-06 18:13:20 -08:00
Andy
381ca45787
Use an enum for Msg ( #19773 )
2017-11-06 18:10:02 -08:00
Sheetal Nandi
3f34525c81
Handle the folder create/delete in the configured project
2017-11-06 15:22:48 -08:00
Sheetal Nandi
ddbd654ecd
Merge pull request #19730 from Microsoft/fileNotOnDisk
...
Handles script infos that dont exist on the disk and are opened with non-rooted disk path
2017-11-06 12:21:32 -08:00
micbou
d97335e4e7
Silence NPM warnings when installing typings ( #19749 )
2017-11-06 09:45:52 -08:00
Andy
0a7b7e07ee
Apply 'variable-name' tslint rule ( #19743 )
2017-11-06 09:23:47 -08:00
Ron Buckton
31c3d444f1
Merge branch 'master' into compareStrings
2017-11-03 23:01:51 -07:00
