24467 Commits

Author SHA1 Message Date
Anders Hejlsberg
fb484c0d65 Accept new baselines 2018-07-25 10:35:19 -07:00
Anders Hejlsberg
205653adde Consistently include circularity check in type parameter constraints 2018-07-25 10:35:16 -07:00
Mohamed Hegazy
e94910f37f Update LKG 2018-07-24 16:48:26 -07:00
Mohamed Hegazy
dc6d8e04d4
Merge pull request #25909 from weswigham/port-25902
Ports #25902 to `release-3.0`
2018-07-24 16:43:04 -07:00
Mohamed Hegazy
65ba8e7c6b
Merge pull request #25910 from weswigham/port-25908
Ports #25908 to `release-3.0`
2018-07-24 16:42:54 -07:00
Wesley Wigham
2376e4eb73
Lookup files by resolved Path and not by fileName in sourcemapDecoder when querying program (#25908)
* Check if the file returned by the program actually refers to the same file as we intend

* Simplify
2018-07-24 15:44:59 -07:00
Wesley Wigham
b3baab5f4a
Fix #25820 - handle redirected files when comparing paths (#25902)
* Fix #25820 - handle redirected files when comparing paths

* Update test to do case check
2018-07-24 15:27:20 -07:00
Mohamed Hegazy
fe3bb5888c
Merge pull request #25904 from weswigham/port-25838
Call toPath on sourceRoot to ensure it is always absolute (#25838)
2018-07-24 15:01:00 -07:00
Mohamed Hegazy
5082081f61
Merge pull request #25903 from weswigham/port-25850
Ports #25850 to `release-3.0`
2018-07-24 14:57:03 -07:00
Wesley Wigham
0e4db0758b
Call toPath on sourceRoot to ensure it is always absolute (#25838)
* Call toPath on sourceRoot to ensure it is always absolute

* Leave canonicalization to avoid a Path/string union
2018-07-24 14:15:49 -07:00
Wesley Wigham
a4d3bddf62
Inspect all possible module paths when looking for the best one to create a specifier with (#25850)
* Inspect all possible specifier paths when looking for the best one

* Add missing secondary option from test
2018-07-24 14:12:44 -07:00
Mohamed Hegazy
bde711583c Add .mailmap and Test-results.xml to .npmignore 2018-07-24 12:41:08 -07:00
Andy
8817d9e5bc
Ensure fixSpelling and importFixes still trigger on "Did you mean the instance/static member ..." (#25847) (#25848) 2018-07-20 18:00:58 -07:00
Andy
f3dac771c6
findAllReferences/rename: Search in all open projects (#25648) (#25849)
* findAllReferences/rename: Search in all open projects

* Avoid needing a dummy location when location is unused

* Remove Program#getDeclarationEmitPath

* Only iterate over enabled projects
2018-07-20 18:00:47 -07:00
Mohamed Hegazy
03185a75b7
Merge pull request #25843 from Microsoft/port25817
Port #25817 to release-3.0
2018-07-20 16:32:10 -07:00
Anders Hejlsberg
d0796ea547 Accept new baselines 2018-07-20 15:38:36 -07:00
Anders Hejlsberg
d5f3cee35d Add regression test 2018-07-20 15:38:33 -07:00
Anders Hejlsberg
bac5f90af1 Properly handle all generic kinds of types in rest positions 2018-07-20 15:38:30 -07:00
Daniel Rosenwasser
5ed76973ed
Merge pull request #25781 from Microsoft/objectsAgainstArrays-3.0
[release 3.0] Avoid elaborating object literals against array-likes
2018-07-19 08:07:26 -07:00
Daniel Rosenwasser
11284e7a98 Accepted baselines. 2018-07-18 15:33:00 -07:00
Daniel Rosenwasser
f49679fff1 Elaborate on the first non-array type when object literals are compared against 'T | T[]'. 2018-07-18 15:31:32 -07:00
Daniel Rosenwasser
9d23080b58 Added test. 2018-07-18 15:31:16 -07:00
Andy
33df18de0c
Consistently use ScriptInfo for converting positions to Locations (#25623) (#25777)
* Consistently use ScriptInfo for converting positions to Locations

* Code review
2018-07-18 14:49:06 -07:00
Andy
53d240015c
Don't bother trying to get the name of a default export (#25773) (#25776)
* Don't bother trying to get the name of a default export

* Fix lint
2018-07-18 12:23:57 -07:00
Andy
83b29eddd7
Fix formatting at trailing comma (#25706) (#25743) 2018-07-17 17:05:49 -07:00
Mohamed Hegazy
a3c6c717cd Update LKG 2018-07-16 14:19:45 -07:00
Mohamed Hegazy
d71415a5e0
Merge pull request #25702 from Microsoft/mergeMaster-7-16
Merge master into release-3.0
2018-07-16 13:43:52 -07:00
Mohamed Hegazy
39a7891dc8 Merge branch 'master' into release-3.0 2018-07-16 13:18:08 -07:00
Mohamed Hegazy
75930f87fe
Merge pull request #25699 from Microsoft/revert-explicitly-typed-special-assignments
Revert explicitly typed special assignments
2018-07-16 13:15:06 -07:00
Mohamed Hegazy
d690835cb9
Merge pull request #25698 from Microsoft/navigationBarUnrelatedGrandchildren
navigationBar: Don't merge unrelated grandchildren
2018-07-16 13:02:35 -07:00
Nathan Shively-Sanders
16676f2707 Revert "Explicitly typed special assignments are context sensitive (#25619)"
This reverts commit 32e60a9647162bc72092827f28c7c54328a4ad57.
2018-07-16 12:39:08 -07:00
Andy Hanson
1038c76f88 navigationBar: Don't merge unrelated grandchildren 2018-07-16 12:38:38 -07:00
Nathan Shively-Sanders
ff8c30d636 Revert "Explicitly typed prototype assignments are context sensitive (#25688)"
This reverts commit 5b21cbc0c9f5b4501770c5994430c4e9af5f162e.
2018-07-16 12:38:27 -07:00
Daniel Rosenwasser
93ab352189
Merge pull request #25565 from Microsoft/popFirst
Make 'pop' the first method that uses 'T' in 'Array'
2018-07-16 11:41:44 -07:00
Andy
afdd47c9ce
Simplify rules for isControlFlowEndingStatement (#25693) 2018-07-16 11:17:46 -07:00
Mohamed Hegazy
8ef146e658
Merge pull request #25656 from j-oliveras/Fix_25653
Change jsDocTagNames to lower case.
2018-07-16 10:18:12 -07:00
Nathan Shively-Sanders
5b21cbc0c9
Explicitly typed prototype assignments are context sensitive (#25688)
* Explicitly typed prototype assignments:ctx sensitive

Follow up to #25619: Add the necessary code to type `prototype`
correctly in prototype assignments so that code like
`F.prototype = { ... }` properly makes the object literal context
sensitive.

* Fix lint
2018-07-16 10:03:39 -07:00
Daniel Rosenwasser
60986adee5
Merge pull request #25507 from ajafff/leftmost-expr-tagged-template
getLeftmostExpression: handle TaggedTemplateExpression
2018-07-13 23:56:32 -07:00
Andy
e25a23bb3c
Fix Buffer.from uses to handle node 5.4.1 bug (#25659) 2018-07-13 17:08:25 -07:00
Sheetal Nandi
7ad4fcf121
Merge pull request #25649 from Microsoft/jsonFilesOnCommandLine
Support resolveJsonModule option when files contain the json file
2018-07-13 16:24:42 -07:00
Jordi Oliveras Rovira
4f411a8cce Change jsDocTagNames to lower case. 2018-07-14 01:02:20 +02:00
Sheetal Nandi
49ac60f286 Support resolveJsonModule option when files contain the json file
Fixes #25636
2018-07-13 12:21:51 -07:00
Sheetal Nandi
47e513e151
Merge pull request #25627 from Microsoft/preserveOutputInConfig
Fix incorrect handling of preserveWatchOutput flag is in config file
2018-07-13 10:56:53 -07:00
Andy
3f4412b173
getContainingList: Handle TypeAliasDeclaration (#25614)
* getContainingList: Handle TypeAliasDeclaration

* Handle ClassExpression and InterfaceDeclaration
2018-07-13 10:30:22 -07:00
Andy
27da9eab8d
fixUnreachableCode: Don't delete whole block when non-first line is unreachable (#25625) 2018-07-13 09:57:04 -07:00
Andy
88c6ced3c6
indentMultilineCommentOrJsxText: Fix bug when 'parts' is empty (#25645) 2018-07-13 09:56:21 -07:00
Sheetal Nandi
ca083809a4 Fix incorrect handling of preserveWatchOutput flag is in config file
Fixes #25620
2018-07-12 18:29:02 -07:00
Andy
1fb050bcca
Don't report unused diagnostics when the unused node has a parse error (#25598)
* Don't report unused diagnostics when the unused node has a parse error

* Update test
2018-07-12 17:24:59 -07:00
Nathan Shively-Sanders
32e60a9647
Explicitly typed special assignments are context sensitive (#25619)
* Explicitly typed js assignments: context sensitive

Explicitly typed special assignments should be context sensitive if they
have an explicit type tag. Previously no special assignments were
context sensitive because they are declarations, and in the common,
untyped, case we inspect the right side of the assignment to get the
type of the left side, and inspect the right side of the assignment to
get the type of the left side, etc etc.

Note that some special assignments still return `any` from
checkExpression, so still don't get the right type.

Fixes #25571

* Change prototype property handling+update bselines

* Fix indentation in test

* Update baselines
2018-07-12 15:28:53 -07:00
Andy
f500289a44
Stricter test that JSDoc @type tag matches function signature (#25615) 2018-07-12 14:02:02 -07:00